From: Marc Zyngier <marc.zyngier@arm.com>
To: James Morse <james.morse@arm.com>, linux-arm-kernel@lists.infradead.org
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH] arm64: KVM: Guests can skip __install_bp_hardening_cb()s HYP work
Date: Fri, 19 Oct 2018 11:17:32 +0100 [thread overview]
Message-ID: <de8be744-525a-2b75-ef77-e66d7fbabc40@arm.com> (raw)
In-Reply-To: <20180921204919.5790-1-james.morse@arm.com>
On 21/09/18 21:49, James Morse wrote:
> enable_smccc_arch_workaround_1() passes NULL as the hyp_vecs start and
> end if the HVC conduit is in use, and ARM_SMCCC_ARCH_WORKAROUND_1 is
> detected.
>
> If the guest kernel happened to be built with KVM_INDIRECT_VECTORS,
> we go on to allocate a slot, memcpy() the empty workaround in and
> do the appropriate cache maintenance.
>
> This works as we always tell memcpy() the range is 0, so it never
> accesses the NULL src pointer, but we still do the cache maintenance.
>
> If hyp_vecs_start is NULL we know we're a guest, just update the fn
> like the !KVM_INDIRECT_VECTORS version.
>
> Signed-off-by: James Morse <james.morse@arm.com>
> Reviewed-by: Julien Thierry <julien.thierry@arm.com>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Catalin: could you sneak this one in for 4.20? It is strictly a KVM
patch, but its location makes it more suitable for the arm64 tree...
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2018-10-19 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 20:49 [PATCH] arm64: KVM: Guests can skip __install_bp_hardening_cb()s HYP work James Morse
2018-10-19 10:17 ` Marc Zyngier [this message]
2018-10-19 14:38 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de8be744-525a-2b75-ef77-e66d7fbabc40@arm.com \
--to=marc.zyngier@arm.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox