From: David Hildenbrand <david@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Huth <thuth@redhat.com>, Andrew Jones <drjones@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
linux-s390@vger.kernel.org, Janosch Frank <frankja@linux.ibm.com>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
kvmarm@lists.cs.columbia.edu
Subject: Re: [kvm-unit-tests PATCH v2 6/7] s390x: unify header guards
Date: Wed, 9 Jun 2021 16:48:06 +0200 [thread overview]
Message-ID: <e3fb2f65-fb36-d882-4b3b-f433d557f45a@redhat.com> (raw)
In-Reply-To: <20210609143712.60933-7-cohuck@redhat.com>
On 09.06.21 16:37, Cornelia Huck wrote:
> Standardize header guards to _ASMS390X_HEADER_H_, _S390X_HEADER_H_,
> and S390X_HEADER_H, respectively.
>
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
> lib/s390x/asm/arch_def.h | 4 ++--
> lib/s390x/asm/barrier.h | 4 ++--
> lib/s390x/asm/cpacf.h | 6 +++---
> lib/s390x/asm/facility.h | 4 ++--
> lib/s390x/asm/float.h | 4 ++--
> lib/s390x/asm/mem.h | 4 ++--
> lib/s390x/asm/sigp.h | 6 +++---
> lib/s390x/asm/spinlock.h | 4 ++--
> lib/s390x/asm/time.h | 4 ++--
> lib/s390x/asm/uv.h | 4 ++--
> lib/s390x/css.h | 4 ++--
> lib/s390x/interrupt.h | 4 ++--
> lib/s390x/mmu.h | 4 ++--
> lib/s390x/sclp.h | 6 +++---
> lib/s390x/sie.h | 6 +++---
> lib/s390x/smp.h | 4 ++--
> lib/s390x/uv.h | 4 ++--
> lib/s390x/vm.h | 6 +++---
> s390x/sthyi.h | 4 ++--
> 19 files changed, 43 insertions(+), 43 deletions(-)
>
> diff --git a/lib/s390x/asm/arch_def.h b/lib/s390x/asm/arch_def.h
> index 7e2c5e623ab2..76f9e3862965 100644
> --- a/lib/s390x/asm/arch_def.h
> +++ b/lib/s390x/asm/arch_def.h
> @@ -5,8 +5,8 @@
> * Authors:
> * David Hildenbrand <david@redhat.com>
> */
> -#ifndef _ASM_S390X_ARCH_DEF_H_
> -#define _ASM_S390X_ARCH_DEF_H_
> +#ifndef _ASMS390X_ARCH_DEF_H_
> +#define _ASMS390X_ARCH_DEF_H_
>
> struct stack_frame {
> struct stack_frame *back_chain;
> diff --git a/lib/s390x/asm/barrier.h b/lib/s390x/asm/barrier.h
> index 8e2fd6d90034..9534f9e8fa96 100644
> --- a/lib/s390x/asm/barrier.h
> +++ b/lib/s390x/asm/barrier.h
> @@ -6,8 +6,8 @@
> * Thomas Huth <thuth@redhat.com>
> * David Hildenbrand <david@redhat.com>
> */
> -#ifndef _ASM_S390X_BARRIER_H_
> -#define _ASM_S390X_BARRIER_H_
> +#ifndef _ASMS390X_BARRIER_H_
> +#define _ASMS390X_BARRIER_H_
>
> #include <asm-generic/barrier.h>
>
> diff --git a/lib/s390x/asm/cpacf.h b/lib/s390x/asm/cpacf.h
> index 805fcf1a2d71..685262b0ff62 100644
> --- a/lib/s390x/asm/cpacf.h
> +++ b/lib/s390x/asm/cpacf.h
> @@ -8,8 +8,8 @@
> * Harald Freudenberger (freude@de.ibm.com)
> * Martin Schwidefsky <schwidefsky@de.ibm.com>
> */
> -#ifndef _ASM_S390_CPACF_H
> -#define _ASM_S390_CPACF_H
> +#ifndef _ASMS390X_CPACF_H_
> +#define _ASMS390X_CPACF_H_
>
> #include <asm/facility.h>
> #include <linux/compiler.h>
> @@ -471,4 +471,4 @@ static inline void cpacf_pckmo(long func, void *param)
> : "cc", "memory");
> }
>
> -#endif /* _ASM_S390_CPACF_H */
> +#endif /* _ASMS390X_CPACF_H_ */
> diff --git a/lib/s390x/asm/facility.h b/lib/s390x/asm/facility.h
> index 95d4a15fe34f..ef0fd037ed35 100644
> --- a/lib/s390x/asm/facility.h
> +++ b/lib/s390x/asm/facility.h
> @@ -5,8 +5,8 @@
> * Authors:
> * David Hildenbrand <david@redhat.com>
> */
> -#ifndef _ASM_S390X_FACILITY_H_
> -#define _ASM_S390X_FACILITY_H_
> +#ifndef _ASMS390X_FACILITY_H_
> +#define _ASMS390X_FACILITY_H_
>
> #include <libcflat.h>
> #include <asm/facility.h>
> diff --git a/lib/s390x/asm/float.h b/lib/s390x/asm/float.h
> index 136794475849..eb752050b162 100644
> --- a/lib/s390x/asm/float.h
> +++ b/lib/s390x/asm/float.h
> @@ -5,8 +5,8 @@
> * Authors:
> * David Hildenbrand <david@redhat.com>
> */
> -#ifndef _ASM_S390X_FLOAT_H_
> -#define _ASM_S390X_FLOAT_H_
> +#ifndef _ASMS390X_FLOAT_H_
> +#define _ASMS390X_FLOAT_H_
>
> static inline void set_fpc(uint32_t fpc)
> {
> diff --git a/lib/s390x/asm/mem.h b/lib/s390x/asm/mem.h
> index 281390ebd816..1963cef7ec03 100644
> --- a/lib/s390x/asm/mem.h
> +++ b/lib/s390x/asm/mem.h
> @@ -5,8 +5,8 @@
> * Copyright IBM Corp. 2018
> * Author(s): Janosch Frank <frankja@de.ibm.com>
> */
> -#ifndef _ASM_S390_MEM_H
> -#define _ASM_S390_MEM_H
> +#ifndef _ASMS390X_MEM_H_
> +#define _ASMS390X_MEM_H_
>
> #define SKEY_ACC 0xf0
> #define SKEY_FP 0x08
> diff --git a/lib/s390x/asm/sigp.h b/lib/s390x/asm/sigp.h
> index 00844d26d15a..61d2c6256fed 100644
> --- a/lib/s390x/asm/sigp.h
> +++ b/lib/s390x/asm/sigp.h
> @@ -5,8 +5,8 @@
> * Copied from the Linux kernel file arch/s390/include/asm/sigp.h
> */
>
> -#ifndef ASM_S390X_SIGP_H
> -#define ASM_S390X_SIGP_H
> +#ifndef _ASMS390X_SIGP_H_
> +#define _ASMS390X_SIGP_H_
>
> /* SIGP order codes */
> #define SIGP_SENSE 1
> @@ -73,4 +73,4 @@ static inline int sigp_retry(uint16_t addr, uint8_t order, unsigned long parm,
> }
>
> #endif /* __ASSEMBLER__ */
> -#endif /* ASM_S390X_SIGP_H */
> +#endif /* _ASMS390X_SIGP_H_ */
> diff --git a/lib/s390x/asm/spinlock.h b/lib/s390x/asm/spinlock.h
> index 677d2cd6e287..22d4d3899569 100644
> --- a/lib/s390x/asm/spinlock.h
> +++ b/lib/s390x/asm/spinlock.h
> @@ -6,8 +6,8 @@
> * Thomas Huth <thuth@redhat.com>
> * David Hildenbrand <david@redhat.com>
> */
> -#ifndef __ASMS390X_SPINLOCK_H
> -#define __ASMS390X_SPINLOCK_H
> +#ifndef _ASMS390X_SPINLOCK_H_
> +#define _ASMS390X_SPINLOCK_H_
>
> #include <asm-generic/spinlock.h>
>
> diff --git a/lib/s390x/asm/time.h b/lib/s390x/asm/time.h
> index 0d67f7231992..7652a151e87a 100644
> --- a/lib/s390x/asm/time.h
> +++ b/lib/s390x/asm/time.h
> @@ -8,8 +8,8 @@
> * Copied from the s390/intercept test by:
> * Pierre Morel <pmorel@linux.ibm.com>
> */
> -#ifndef ASM_S390X_TIME_H
> -#define ASM_S390X_TIME_H
> +#ifndef _ASMS390X_TIME_H_
> +#define _ASMS390X_TIME_H_
>
> #define STCK_SHIFT_US (63 - 51)
> #define STCK_MAX ((1UL << 52) - 1)
> diff --git a/lib/s390x/asm/uv.h b/lib/s390x/asm/uv.h
> index b22cbaa87109..dc3e02dea1b4 100644
> --- a/lib/s390x/asm/uv.h
> +++ b/lib/s390x/asm/uv.h
> @@ -9,8 +9,8 @@
> * This code is free software; you can redistribute it and/or modify it
> * under the terms of the GNU General Public License version 2.
> */
> -#ifndef ASM_S390X_UV_H
> -#define ASM_S390X_UV_H
> +#ifndef _ASMS390X_UV_H_
> +#define _ASMS390X_UV_H_
>
> #define UVC_RC_EXECUTED 0x0001
> #define UVC_RC_INV_CMD 0x0002
> diff --git a/lib/s390x/css.h b/lib/s390x/css.h
> index 7e3d2613402e..d644971fb2b7 100644
> --- a/lib/s390x/css.h
> +++ b/lib/s390x/css.h
> @@ -6,8 +6,8 @@
> * Author: Pierre Morel <pmorel@linux.ibm.com>
> */
>
> -#ifndef CSS_H
> -#define CSS_H
> +#ifndef _S390X_CSS_H_
> +#define _S390X_CSS_H_
>
> #define lowcore_ptr ((struct lowcore *)0x0)
>
> diff --git a/lib/s390x/interrupt.h b/lib/s390x/interrupt.h
> index 1973d267c2f1..99fa0beee9ad 100644
> --- a/lib/s390x/interrupt.h
> +++ b/lib/s390x/interrupt.h
> @@ -1,5 +1,5 @@
> -#ifndef INTERRUPT_H
> -#define INTERRUPT_H
> +#ifndef _S390X_INTERRUPT_H_
> +#define _S390X_INTERRUPT_H_
> #include <asm/interrupt.h>
>
> int register_io_int_func(void (*f)(void));
> diff --git a/lib/s390x/mmu.h b/lib/s390x/mmu.h
> index 603f289e8e00..b995f85b839f 100644
> --- a/lib/s390x/mmu.h
> +++ b/lib/s390x/mmu.h
> @@ -7,8 +7,8 @@
> * Authors:
> * Janosch Frank <frankja@de.ibm.com>
> */
> -#ifndef _ASMS390X_MMU_H_
> -#define _ASMS390X_MMU_H_
> +#ifndef _S390X_MMU_H_
> +#define _S390X_MMU_H_
>
> void protect_page(void *vaddr, unsigned long prot);
> void protect_range(void *start, unsigned long len, unsigned long prot);
> diff --git a/lib/s390x/sclp.h b/lib/s390x/sclp.h
> index 7abf1038f5ee..28e526e2c915 100644
> --- a/lib/s390x/sclp.h
> +++ b/lib/s390x/sclp.h
> @@ -10,8 +10,8 @@
> * Author: Christian Borntraeger <borntraeger@de.ibm.com>
> */
>
> -#ifndef SCLP_H
> -#define SCLP_H
> +#ifndef _S390X_SCLP_H_
> +#define _S390X_SCLP_H_
>
> #define SCLP_CMD_CODE_MASK 0xffff00ff
>
> @@ -329,4 +329,4 @@ void sclp_memory_setup(void);
> uint64_t get_ram_size(void);
> uint64_t get_max_ram_size(void);
>
> -#endif /* SCLP_H */
> +#endif /* _S390X_SCLP_H_ */
> diff --git a/lib/s390x/sie.h b/lib/s390x/sie.h
> index 518613baf1fa..db30d6164ab6 100644
> --- a/lib/s390x/sie.h
> +++ b/lib/s390x/sie.h
> @@ -1,6 +1,6 @@
> /* SPDX-License-Identifier: GPL-2.0-or-later */
> -#ifndef SIE_H
> -#define SIE_H
> +#ifndef _S390X_SIE_H_
> +#define _S390X_SIE_H_
>
> #define CPUSTAT_STOPPED 0x80000000
> #define CPUSTAT_WAIT 0x10000000
> @@ -195,4 +195,4 @@ extern void sie_entry(void);
> extern void sie_exit(void);
> extern void sie64a(struct kvm_s390_sie_block *sblk, struct vm_save_area *save_area);
>
> -#endif /* SIE_H */
> +#endif /* _S390X_SIE_H_ */
> diff --git a/lib/s390x/smp.h b/lib/s390x/smp.h
> index 67ff16ca3c52..a2609f11e40b 100644
> --- a/lib/s390x/smp.h
> +++ b/lib/s390x/smp.h
> @@ -7,8 +7,8 @@
> * Authors:
> * Janosch Frank <frankja@linux.ibm.com>
> */
> -#ifndef SMP_H
> -#define SMP_H
> +#ifndef _S390X_SMP_H_
> +#define _S390X_SMP_H_
>
> #include <asm/arch_def.h>
>
> diff --git a/lib/s390x/uv.h b/lib/s390x/uv.h
> index 42608a967a03..2b23407a2fcf 100644
> --- a/lib/s390x/uv.h
> +++ b/lib/s390x/uv.h
> @@ -1,6 +1,6 @@
> /* SPDX-License-Identifier: GPL-2.0-or-later */
> -#ifndef UV_H
> -#define UV_H
> +#ifndef _S390X_UV_H_
> +#define _S390X_UV_H_
>
> bool uv_os_is_guest(void);
> bool uv_os_is_host(void);
> diff --git a/lib/s390x/vm.h b/lib/s390x/vm.h
> index 16722760cb46..7abba0ccae3d 100644
> --- a/lib/s390x/vm.h
> +++ b/lib/s390x/vm.h
> @@ -5,9 +5,9 @@
> * Copyright (c) 2020 Red Hat Inc
> */
>
> -#ifndef S390X_VM_H
> -#define S390X_VM_H
> +#ifndef _S390X_VM_H_
> +#define _S390X_VM_H_
>
> bool vm_is_tcg(void);
>
> -#endif /* S390X_VM_H */
> +#endif /* _S390X_VM_H_ */
> diff --git a/s390x/sthyi.h b/s390x/sthyi.h
> index bbd74c6197c3..0a47c2385dc7 100644
> --- a/s390x/sthyi.h
> +++ b/s390x/sthyi.h
> @@ -7,8 +7,8 @@
> * Authors:
> * Janosch Frank <frankja@linux.vnet.ibm.com>
> */
> -#ifndef _STHYI_H_
> -#define _STHYI_H_
> +#ifndef S390X_STHYI_H
> +#define S390X_STHYI_H
>
> #include <stdint.h>
>
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2021-06-09 14:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 14:37 [kvm-unit-tests PATCH v2 0/7] unify header guards Cornelia Huck
2021-06-09 14:37 ` [kvm-unit-tests PATCH v2 1/7] README.md: add guideline for header guards format Cornelia Huck
2021-06-09 14:45 ` David Hildenbrand
2021-06-09 15:19 ` Cornelia Huck
2021-06-09 15:00 ` Laurent Vivier
2021-06-14 9:01 ` Andrew Jones
2021-06-09 14:37 ` [kvm-unit-tests PATCH v2 2/7] lib: unify header guards Cornelia Huck
2021-06-09 14:45 ` David Hildenbrand
2021-06-09 15:13 ` Laurent Vivier
2021-06-09 15:37 ` Cornelia Huck
2021-06-09 15:49 ` Laurent Vivier
2021-06-09 14:37 ` [kvm-unit-tests PATCH v2 3/7] asm-generic: " Cornelia Huck
2021-06-09 14:46 ` David Hildenbrand
2021-06-09 15:15 ` Laurent Vivier
2021-06-09 14:37 ` [kvm-unit-tests PATCH v2 4/7] arm: " Cornelia Huck
2021-06-09 14:46 ` David Hildenbrand
2021-06-09 15:24 ` Laurent Vivier
2021-06-09 15:47 ` Cornelia Huck
2021-06-09 15:51 ` Laurent Vivier
2021-06-09 14:37 ` [kvm-unit-tests PATCH v2 5/7] powerpc: " Cornelia Huck
2021-06-09 14:47 ` David Hildenbrand
2021-06-09 14:59 ` Laurent Vivier
2021-06-09 14:37 ` [kvm-unit-tests PATCH v2 6/7] s390x: " Cornelia Huck
2021-06-09 14:48 ` David Hildenbrand [this message]
2021-06-09 14:37 ` [kvm-unit-tests PATCH v2 7/7] x86: " Cornelia Huck
2021-06-09 14:49 ` David Hildenbrand
2021-06-10 12:17 ` [kvm-unit-tests PATCH v2 0/7] " Paolo Bonzini
2021-06-10 13:04 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3fb2f65-fb36-d882-4b3b-f433d557f45a@redhat.com \
--to=david@redhat.com \
--cc=cohuck@redhat.com \
--cc=drjones@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-s390@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox