From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60D11C433EF for ; Wed, 22 Sep 2021 06:42:41 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id D1964611C9 for ; Wed, 22 Sep 2021 06:42:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D1964611C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 7E18049E57; Wed, 22 Sep 2021 02:42:40 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z67oIiIX9Qva; Wed, 22 Sep 2021 02:42:39 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 15201405A6; Wed, 22 Sep 2021 02:42:39 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DC72D401A2 for ; Wed, 22 Sep 2021 02:42:37 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 25kPms+Wvf7j for ; Wed, 22 Sep 2021 02:42:36 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 8B48F40191 for ; Wed, 22 Sep 2021 02:42:36 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632292956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WYW/P0Q1oqTDlsP5noOn+TZGFQp14YjumKQL9bn9bmM=; b=OwDlj4XQQpZT4OsqQaH31/flFA59cMPL27LqTTDDH7+e3S6KXkHQkCB1/NpJTOXokjOvJc kcWkh4xmATgF6Hm6EAO9v7SyeI8C/fzLdH8EywdpI339GOnUzdJ9cNVw+Phso+FKXikfnr Yuq8eq/NQ7Yxhdn1JzoPP1zcqQxlt6k= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-35-DR96ObNgNrSbckmQawVr8w-1; Wed, 22 Sep 2021 02:42:35 -0400 X-MC-Unique: DR96ObNgNrSbckmQawVr8w-1 Received: by mail-ed1-f69.google.com with SMTP id r11-20020aa7cfcb000000b003d4fbd652b9so1823218edy.14 for ; Tue, 21 Sep 2021 23:42:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WYW/P0Q1oqTDlsP5noOn+TZGFQp14YjumKQL9bn9bmM=; b=iejK91MKYfBkXxBfJ/uJTsCA4FZjnwMvn6ECA0tYDp/2UM61sdXOD3oRZ0uPYG7vxf m3DC0RMkQVz/PT51E4S+YlGi0TFmFbj5rdIykfo2sJJvpe+v6U2iGHo94O5biWejpocH u42JVo6qoDycIMsctsUGDB/fDhTPdT0BYA3q7POMuF16+nIxw9v/VfYzxYY4cfCJHkbK 8ubVzFMR1FsNfePemkjDenya9XGM3RT6R+SxhZdsFYs0+2SWsJB1czJ3GS5RNAC1Hx5/ XH9pQP51wZUXUoThuNHK/xtliFPZgQRG/uzbB1rqDKw+r9HbHxB1wDVBUNhZVfUxGqCo 9luA== X-Gm-Message-State: AOAM5322L8c0iyDHHrFt25cnZSZLxcqUapKHSXqa62sXujHVjrxfNbqG 4DvYc7MNu62Zk6DV1qIF288m7z0SWhcY+wahpPm7pzTaoXUMagC5ShMFAmN9E6PaQhK/addlCve taw3vExTG51vUtPG2MaypMAH7 X-Received: by 2002:a17:906:369a:: with SMTP id a26mr39372054ejc.539.1632292954031; Tue, 21 Sep 2021 23:42:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxkdDvJZEuqy4z2jeakskcrSYfL6dBq85KTjMRgyfnCoMn+hPyF2F91qCQRXVCbzc6p2Cz+kg== X-Received: by 2002:a17:906:369a:: with SMTP id a26mr39372025ejc.539.1632292953733; Tue, 21 Sep 2021 23:42:33 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id dh16sm622370edb.63.2021.09.21.23.42.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 23:42:33 -0700 (PDT) Subject: Re: [PATCH v3 00/16] perf: KVM: Fix, optimize, and clean up callbacks To: Sean Christopherson , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Will Deacon , Mark Rutland , Marc Zyngier , Guo Ren , Nick Hu , Greentime Hu , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , Boris Ostrovsky , Juergen Gross References: <20210922000533.713300-1-seanjc@google.com> From: Paolo Bonzini Message-ID: Date: Wed, 22 Sep 2021 08:42:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210922000533.713300-1-seanjc@google.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: Wanpeng Li , kvm@vger.kernel.org, Alexander Shishkin , Vitaly Kuznetsov , linux-riscv@lists.infradead.org, Jiri Olsa , kvmarm@lists.cs.columbia.edu, Stefano Stabellini , Joerg Roedel , linux-csky@vger.kernel.org, xen-devel@lists.xenproject.org, Namhyung Kim , Artem Kashkanov , linux-arm-kernel@lists.infradead.org, Jim Mattson , Like Xu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Zhu Lingshan X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 22/09/21 02:05, Sean Christopherson wrote: > Peter, I left the Intel PT mess as-is. Having to pass a NULL pointer > from KVM arm64 seemed to be a lesser evil than more exports and multiple > registration paths. > > This is a combination of ~2 series to fix bugs in the perf+KVM callbacks, > optimize the callbacks by employing static_call, and do a variety of > cleanup in both perf and KVM. > > Patch 1 fixes a mostly-theoretical bug where perf can deref a NULL > pointer if KVM unregisters its callbacks while they're being accessed. > In practice, compilers tend to avoid problematic reloads of the pointer > and the PMI handler doesn't lose the race against module unloading, > i.e doesn't hit a use-after-free. > > Patches 2 and 3 fix an Intel PT handling bug where KVM incorrectly > eats PT interrupts when PT is supposed to be owned entirely by the host. > > Patches 4-9 clean up perf's callback infrastructure and switch to > static_call for arm64 and x86 (the only survivors). > > Patches 10-16 clean up related KVM code and unify the arm64/x86 callbacks. > > Based on "git://git.kernel.org/pub/scm/virt/kvm/kvm.git queue", commit > 680c7e3be6a3 ("KVM: x86: Exit to userspace ..."). Looks nice apart from a couple nits, I will gladly accept a topic branch with both the perf and the KVM parts. Thanks, Paolo > v3: > - Add wrappers for guest callbacks to that stubs can be provided when > GUEST_PERF_EVENTS=n. > - s/HAVE_GUEST_PERF_EVENTS/GUEST_PERF_EVENTS and select it from KVM > and XEN_PV instead of from top-level arm64/x86. [Paolo] > - Drop an unnecessary synchronize_rcu() when registering callbacks. [Peter] > - Retain a WARN_ON_ONCE() when unregistering callbacks if the caller > didn't provide the correct pointer. [Peter] > - Rework the static_call patch to move it all to common perf. > - Add a patch to drop the (un)register stubs, made possible after > having KVM+XEN_PV select GUEST_PERF_EVENTS. > - Split dropping guest callback "support" for arm, csky, etc... to a > separate patch, to make introducing GUEST_PERF_EVENTS cleaner. > > v2 (relative to static_call v10): > - Split the patch into the semantic change (multiplexed ->state) and > introduction of static_call. > - Don't use '0' for "not a guest RIP". > - Handle unregister path. > - Drop changes for architectures that can be culled entirely. > > v2 (relative to v1): > - https://lkml.kernel.org/r/20210828003558.713983-6-seanjc@google.com > - Drop per-cpu approach. [Peter] > - Fix mostly-theoretical reload and use-after-free with READ_ONCE(), > WRITE_ONCE(), and synchronize_rcu(). [Peter] > - Avoid new exports like the plague. [Peter] > > v1: > - https://lkml.kernel.org/r/20210827005718.585190-1-seanjc@google.com > > v10 static_call: > - https://lkml.kernel.org/r/20210806133802.3528-2-lingshan.zhu@intel.com > > > Like Xu (1): > perf/core: Rework guest callbacks to prepare for static_call support > > Sean Christopherson (15): > perf: Ensure perf_guest_cbs aren't reloaded between !NULL check and > deref > KVM: x86: Register perf callbacks after calling vendor's > hardware_setup() > KVM: x86: Register Processor Trace interrupt hook iff PT enabled in > guest > perf: Stop pretending that perf can handle multiple guest callbacks > perf: Drop dead and useless guest "support" from arm, csky, nds32 and > riscv > perf: Add wrappers for invoking guest callbacks > perf: Force architectures to opt-in to guest callbacks > perf/core: Use static_call to optimize perf_guest_info_callbacks > KVM: x86: Drop current_vcpu for kvm_running_vcpu + kvm_arch_vcpu > variable > KVM: x86: More precisely identify NMI from guest when handling PMI > KVM: Move x86's perf guest info callbacks to generic KVM > KVM: x86: Move Intel Processor Trace interrupt handler to vmx.c > KVM: arm64: Convert to the generic perf callbacks > KVM: arm64: Drop perf.c and fold its tiny bits of code into arm.c / > pmu.c > perf: Drop guest callback (un)register stubs > > arch/arm/kernel/perf_callchain.c | 28 ++------------ > arch/arm64/include/asm/kvm_host.h | 9 ++++- > arch/arm64/kernel/perf_callchain.c | 13 ++++--- > arch/arm64/kvm/Kconfig | 1 + > arch/arm64/kvm/Makefile | 2 +- > arch/arm64/kvm/arm.c | 11 +++++- > arch/arm64/kvm/perf.c | 62 ------------------------------ > arch/arm64/kvm/pmu.c | 8 ++++ > arch/csky/kernel/perf_callchain.c | 10 ----- > arch/nds32/kernel/perf_event_cpu.c | 29 ++------------ > arch/riscv/kernel/perf_callchain.c | 10 ----- > arch/x86/events/core.c | 13 ++++--- > arch/x86/events/intel/core.c | 5 +-- > arch/x86/include/asm/kvm_host.h | 7 +++- > arch/x86/kvm/Kconfig | 1 + > arch/x86/kvm/pmu.c | 2 +- > arch/x86/kvm/svm/svm.c | 2 +- > arch/x86/kvm/vmx/vmx.c | 25 +++++++++++- > arch/x86/kvm/x86.c | 58 +++++----------------------- > arch/x86/kvm/x86.h | 17 ++++++-- > arch/x86/xen/Kconfig | 1 + > arch/x86/xen/pmu.c | 32 +++++++-------- > include/kvm/arm_pmu.h | 1 + > include/linux/kvm_host.h | 10 +++++ > include/linux/perf_event.h | 41 ++++++++++++++------ > init/Kconfig | 4 ++ > kernel/events/core.c | 39 +++++++++++++------ > virt/kvm/kvm_main.c | 44 +++++++++++++++++++++ > 28 files changed, 235 insertions(+), 250 deletions(-) > delete mode 100644 arch/arm64/kvm/perf.c > _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm