From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CEE8C17447 for ; Wed, 13 Nov 2019 10:14:30 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id D19FE204EC for ; Wed, 13 Nov 2019 10:14:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D19FE204EC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 82C754B159; Wed, 13 Nov 2019 05:14:28 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4oFWnSWJMwth; Wed, 13 Nov 2019 05:14:27 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 457614B148; Wed, 13 Nov 2019 05:14:27 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 816594B0D7 for ; Wed, 13 Nov 2019 05:14:26 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gUNVOr3nCVq8 for ; Wed, 13 Nov 2019 05:14:25 -0500 (EST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4E8214B0CD for ; Wed, 13 Nov 2019 05:14:25 -0500 (EST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DA7BD7A7; Wed, 13 Nov 2019 02:14:24 -0800 (PST) Received: from [10.1.196.63] (e123195-lin.cambridge.arm.com [10.1.196.63]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EC2B83F534; Wed, 13 Nov 2019 02:14:23 -0800 (PST) Subject: Re: [kvm-unit-tests PATCH 15/17] arm: gic: Provide FIQ handler To: Andre Przywara , Andrew Jones , Paolo Bonzini References: <20191108144240.204202-1-andre.przywara@arm.com> <20191108144240.204202-16-andre.przywara@arm.com> From: Alexandru Elisei Message-ID: Date: Wed, 13 Nov 2019 10:14:22 +0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191108144240.204202-16-andre.przywara@arm.com> Content-Language: en-US Cc: Marc Zyngier , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi, On 11/8/19 2:42 PM, Andre Przywara wrote: > When configuring an interrupt as Group 0, we can ask the GIC to deliver > them as a FIQ. For this we need a separate exception handler. > > Provide this to be used later. > > Signed-off-by: Andre Przywara > --- > arm/gic.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arm/gic.c b/arm/gic.c > index c68b5b5..6756850 100644 > --- a/arm/gic.c > +++ b/arm/gic.c > @@ -178,6 +178,30 @@ static void irq_handler(struct pt_regs *regs __unused) > smp_wmb(); /* pairs with rmb in check_acked */ > } > > +static inline void fiq_handler(struct pt_regs *regs __unused) > +{ > + u32 irqstat = gic_read_iar(0); > + u32 irqnr = gic_iar_irqnr(irqstat); > + > + if (irqnr == GICC_INT_SPURIOUS) { > + ++spurious[smp_processor_id()]; > + smp_wmb(); > + return; > + } > + > + gic_write_eoir(irqstat, 0); > + > + smp_rmb(); /* pairs with wmb in stats_reset */ > + ++acked[smp_processor_id()]; > + if (irqnr < GIC_NR_PRIVATE_IRQS) { > + check_ipi_sender(irqstat); > + check_irqnr(irqnr, IPI_IRQ); > + } else { > + check_irqnr(irqnr, SPI_IRQ); > + } > + smp_wmb(); /* pairs with rmb in check_acked */ > +} If I'm not mistaken, this is identical to irq_handler, with the exception that gic_read_iar and gic_write_eoir take group 0 as argument here. Maybe we can abstract the common code into a function that takes the group as the argument? What do you think? Thanks, Alex > + > static void gicv2_ipi_send_self(void) > { > writel(2 << 24 | IPI_IRQ, gicv2_dist_base() + GICD_SGIR); _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm