From: Gavin Shan <gshan@redhat.com>
To: Joey Gouly <joey.gouly@arm.com>,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev
Cc: anshuman.khandual@arm.com, james.morse@arm.com,
Marc Zyngier <maz@kernel.org>,
Oliver Upton <oliver.upton@linux.dev>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Jing Zhang <jingzhangos@google.com>,
Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH v4 2/7] arm64/sysreg: Convert existing MPAM sysregs and add the remaining entries
Date: Wed, 9 Oct 2024 14:12:00 +1000 [thread overview]
Message-ID: <f2ddc184-fdf8-4281-b8a2-c2ea5a35b447@redhat.com> (raw)
In-Reply-To: <20241004110714.2051604-3-joey.gouly@arm.com>
On 10/4/24 9:07 PM, Joey Gouly wrote:
> From: James Morse <james.morse@arm.com>
>
> Move the existing MPAM system register defines from sysreg.h to
> tools/sysreg and add the remaining system registers.
>
> Signed-off-by: James Morse <james.morse@arm.com>
> Signed-off-by: Joey Gouly <joey.gouly@arm.com>
> ---
> arch/arm64/include/asm/sysreg.h | 12 ---
> arch/arm64/tools/sysreg | 166 ++++++++++++++++++++++++++++++++
> 2 files changed, 166 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h
> index 9ea97dddefc4..345e81e0d2b3 100644
> --- a/arch/arm64/include/asm/sysreg.h
> +++ b/arch/arm64/include/asm/sysreg.h
> @@ -542,18 +542,6 @@
>
> #define SYS_MAIR_EL2 sys_reg(3, 4, 10, 2, 0)
> #define SYS_AMAIR_EL2 sys_reg(3, 4, 10, 3, 0)
> -#define SYS_MPAMHCR_EL2 sys_reg(3, 4, 10, 4, 0)
> -#define SYS_MPAMVPMV_EL2 sys_reg(3, 4, 10, 4, 1)
> -#define SYS_MPAM2_EL2 sys_reg(3, 4, 10, 5, 0)
> -#define __SYS__MPAMVPMx_EL2(x) sys_reg(3, 4, 10, 6, x)
> -#define SYS_MPAMVPM0_EL2 __SYS__MPAMVPMx_EL2(0)
> -#define SYS_MPAMVPM1_EL2 __SYS__MPAMVPMx_EL2(1)
> -#define SYS_MPAMVPM2_EL2 __SYS__MPAMVPMx_EL2(2)
> -#define SYS_MPAMVPM3_EL2 __SYS__MPAMVPMx_EL2(3)
> -#define SYS_MPAMVPM4_EL2 __SYS__MPAMVPMx_EL2(4)
> -#define SYS_MPAMVPM5_EL2 __SYS__MPAMVPMx_EL2(5)
> -#define SYS_MPAMVPM6_EL2 __SYS__MPAMVPMx_EL2(6)
> -#define SYS_MPAMVPM7_EL2 __SYS__MPAMVPMx_EL2(7)
>
> #define SYS_VBAR_EL2 sys_reg(3, 4, 12, 0, 0)
> #define SYS_RVBAR_EL2 sys_reg(3, 4, 12, 0, 1)
> diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
> index 8d637ac4b7c6..73243cfca2d2 100644
> --- a/arch/arm64/tools/sysreg
> +++ b/arch/arm64/tools/sysreg
> @@ -2737,6 +2737,126 @@ Field 1 E2SPE
> Field 0 E0HSPE
> EndSysreg
>
> +Sysreg MPAMHCR_EL2 3 4 10 4 0
> +Res0 63:32
> +Field 31 TRAP_MPAMIDR_EL1
> +Res0 30:9
> +Field 8 GSTAPP_PLK
> +Res0 7:2
> +Field 1 EL1_VPMEN
> +Field 0 EL0_VPMEN
> +EndSysreg
> +
> +Sysreg MPAMVPMV_EL2 3 4 10 4 1
> +Res0 63:32
> +Field 31 VPM_V31
> +Field 30 VPM_V30
> +Field 29 VPM_V29
> +Field 28 VPM_V28
> +Field 27 VPM_V27
> +Field 26 VPM_V26
> +Field 25 VPM_V25
> +Field 24 VPM_V24
> +Field 23 VPM_V23
> +Field 22 VPM_V22
> +Field 21 VPM_V21
> +Field 20 VPM_V20
> +Field 19 VPM_V19
> +Field 18 VPM_V18
> +Field 17 VPM_V17
> +Field 16 VPM_V16
> +Field 15 VPM_V15
> +Field 14 VPM_V14
> +Field 13 VPM_V13
> +Field 12 VPM_V12
> +Field 11 VPM_V11
> +Field 10 VPM_V10
> +Field 9 VPM_V9
> +Field 8 VPM_V8
> +Field 7 VPM_V7
> +Field 6 VPM_V6
> +Field 5 VPM_V5
> +Field 4 VPM_V4
> +Field 3 VPM_V3
> +Field 2 VPM_V2
> +Field 1 VPM_V1
> +Field 0 VPM_V0
> +EndSysreg
> +
> +Sysreg MPAM2_EL2 3 4 10 5 0
> +Field 63 MPAMEN
> +Res0 62:59
> +Field 58 TIDR
> +Res0 57
> +Field 56 ALTSP_HFC
> +Field 55 ALTSP_EL2
> +Field 54 ALTSP_FRCD
> +Res0 53:51
> +Field 50 EnMPAMSM
> +Field 49 TRAPMPAM0EL1
> +Field 48 TRAPMPAM1EL1
> +Field 47:40 PMG_D
> +Field 39:32 PMG_I
> +Field 31:16 PARTID_D
> +Field 15:0 PARTID_I
> +EndSysreg
> +
> +Sysreg MPAMVPM0_EL2 3 4 10 6 0
> +Field 63:48 PhyPARTID3
> +Field 47:32 PhyPARTID2
> +Field 31:16 PhyPARTID1
> +Field 15:0 PhyPARTID0
> +EndSysreg
> +
> +Sysreg MPAMVPM1_EL2 3 4 10 6 1
> +Field 63:48 PhyPARTID7
> +Field 47:32 PhyPARTID6
> +Field 31:16 PhyPARTID5
> +Field 15:0 PhyPARTID4
> +EndSysreg
> +
> +Sysreg MPAMVPM2_EL2 3 4 10 6 2
> +Field 63:48 PhyPARTID11
> +Field 47:32 PhyPARTID10
> +Field 31:16 PhyPARTID9
> +Field 15:0 PhyPARTID8
> +EndSysreg
> +
> +Sysreg MPAMVPM3_EL2 3 4 10 6 3
> +Field 63:48 PhyPARTID15
> +Field 47:32 PhyPARTID14
> +Field 31:16 PhyPARTID13
> +Field 15:0 PhyPARTID12
> +EndSysreg
> +
> +Sysreg MPAMVPM4_EL2 3 4 10 6 4
> +Field 63:48 PhyPARTID19
> +Field 47:32 PhyPARTID18
> +Field 31:16 PhyPARTID17
> +Field 15:0 PhyPARTID16
> +EndSysreg
> +
> +Sysreg MPAMVPM5_EL2 3 4 10 6 5
> +Field 63:48 PhyPARTID23
> +Field 47:32 PhyPARTID22
> +Field 31:16 PhyPARTID21
> +Field 15:0 PhyPARTID20
> +EndSysreg
> +
> +Sysreg MPAMVPM6_EL2 3 4 10 6 6
> +Field 63:48 PhyPARTID27
> +Field 47:32 PhyPARTID26
> +Field 31:16 PhyPARTID25
> +Field 15:0 PhyPARTID24
> +EndSysreg
> +
> +Sysreg MPAMVPM7_EL2 3 4 10 6 7
> +Field 63:48 PhyPARTID31
> +Field 47:32 PhyPARTID30
> +Field 31:16 PhyPARTID29
> +Field 15:0 PhyPARTID28
> +EndSysreg
> +
> Sysreg CONTEXTIDR_EL2 3 4 13 0 1
> Fields CONTEXTIDR_ELx
> EndSysreg
> @@ -2769,6 +2889,10 @@ Sysreg FAR_EL12 3 5 6 0 0
> Field 63:0 ADDR
> EndSysreg
>
> +Sysreg MPAM1_EL12 3 5 10 5 0
> +Fields MPAM1_ELx
> +EndSysreg
> +
> Sysreg CONTEXTIDR_EL12 3 5 13 0 1
> Fields CONTEXTIDR_ELx
> EndSysreg
> @@ -2941,6 +3065,22 @@ Res0 1
> Field 0 EN
> EndSysreg
>
> +Sysreg MPAMIDR_EL1 3 0 10 4 4
> +Res0 63:62
> +Field 61 HAS_SDEFLT
> +Field 60 HAS_FORCE_NS
> +Field 59 SP4
> +Field 58 HAS_TIDR
> +Field 57 HAS_ALTSP
> +Res0 56:40
> +Field 39:32 PMG_MAX
> +Res0 31:21
> +Field 20:18 VPMR_MAX
> +Field 17 HAS_HCR
> +Res0 16
> +Field 15:0 PARTID_MAX
> +EndSysreg
> +
> Sysreg LORID_EL1 3 0 10 4 7
> Res0 63:24
> Field 23:16 LD
> @@ -2948,6 +3088,32 @@ Res0 15:8
> Field 7:0 LR
> EndSysreg
>
> +Sysreg MPAM1_EL1 3 0 10 5 0
> +Field 63 MPAMEN
> +Res0 62:59
> +Field 58 TIDR
> +Res0 57
> +Field 56 ALTSP_HFC
> +Field 55 ALTSP_EL2
> +Field 54 ALTSP_FRCD
> +Res0 53:51
> +Field 50 EnMPAMSM
> +Field 49 TRAPMPAM0EL1
> +Field 48 TRAPMPAM1EL1
> +Field 47:40 PMG_D
> +Field 39:32 PMG_I
> +Field 31:16 PARTID_D
> +Field 15:0 PARTID_I
> +EndSysreg
> +
The layout of SYS_MPAM1_EL1 is exactly same to that of SYS_MPAM2_EL2, is it
intentional or a mistake, even SYS_MPAM1_EL1 is the alias to SYS_MPAM2_EL2
when HCR_EL2.E2H is set?
> +Sysreg MPAM0_EL1 3 0 10 5 1
> +Res0 63:48
> +Field 47:40 PMG_D
> +Field 39:32 PMG_I
> +Field 31:16 PARTID_D
> +Field 15:0 PARTID_I
> +EndSysreg
> +
Shall we add the definition for SYS_MPAMSM_EL1, which is visible in section
D23.12 of "ARM DDI 0487K.a"?
> Sysreg ISR_EL1 3 0 12 1 0
> Res0 63:11
> Field 10 IS
Thanks,
Gavin
next prev parent reply other threads:[~2024-10-09 4:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 11:07 [PATCH v4 0/7] KVM: arm64: Hide unsupported MPAM from the guest Joey Gouly
2024-10-04 11:07 ` [PATCH v4 1/7] arm64: head.S: Initialise MPAM EL2 registers and disable traps Joey Gouly
2024-10-09 3:59 ` Gavin Shan
2024-10-04 11:07 ` [PATCH v4 2/7] arm64/sysreg: Convert existing MPAM sysregs and add the remaining entries Joey Gouly
2024-10-09 4:12 ` Gavin Shan [this message]
2024-10-04 11:07 ` [PATCH v4 3/7] arm64: cpufeature: discover CPU support for MPAM Joey Gouly
2024-10-09 5:50 ` Gavin Shan
2024-10-04 11:07 ` [PATCH v4 4/7] KVM: arm64: Fix missing traps of guest accesses to the MPAM registers Joey Gouly
2024-10-07 11:05 ` Marc Zyngier
2024-10-09 5:53 ` Gavin Shan
2024-10-10 10:18 ` Joey Gouly
2024-10-04 11:07 ` [PATCH v4 5/7] KVM: arm64: Add a macro for creating filtered sys_reg_descs entries Joey Gouly
2024-10-09 6:12 ` Gavin Shan
2024-10-04 11:07 ` [PATCH v4 6/7] KVM: arm64: Disable MPAM visibility by default and ignore VMM writes Joey Gouly
2024-10-09 6:40 ` Gavin Shan
2024-10-04 11:07 ` [PATCH v4 7/7] KVM: arm64: selftests: Test ID_AA64PFR0.MPAM isn't completely ignored Joey Gouly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2ddc184-fdf8-4281-b8a2-c2ea5a35b447@redhat.com \
--to=gshan@redhat.com \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=jingzhangos@google.com \
--cc=joey.gouly@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox