Re: [PATCH v5 23/26] KVM: arm/arm64: GICv4: Prevent a VM using GICv4 from being saved

Auger Eric
2017-11-07T15:24:32Z

Hi Marc,

Hi Marc,
On 27/10/2017 16:28, Marc Zyngier wrote:
> The GICv4 architecture doesn't make it easy for save/restore to
> work, as it doesn't give any guarantee that the pending state
> is written into the pending table.

I don't understand where does the limitation exactly come from. Can't we
use the GICR_VPENDBASER table data?

Thanks

Eric
>
> So let's not take any chance, and let's return an error if
> we encounter any LPI that has the HW bit set. In order for
> userspace to distinguish this error from other failure modes,
> use -EACCES as an error code.
>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
> Documentation/virtual/kvm/devices/arm-vgic-its.txt | 2 ++
> virt/kvm/arm/vgic/vgic-its.c | 9 +++++++++
> 2 files changed, 11 insertions(+)
>
> diff --git a/Documentation/virtual/kvm/devices/arm-vgic-its.txt b/Documentation/virtual/kvm/devices/arm-vgic-its.txt
> index eb06beb75960..1eec7bcb2d52 100644
> --- a/Documentation/virtual/kvm/devices/arm-vgic-its.txt
> +++ b/Documentation/virtual/kvm/devices/arm-vgic-its.txt
> @@ -60,6 +60,8 @@ Groups:
> -EINVAL: Inconsistent restored data
> -EFAULT: Invalid guest ram access
> -EBUSY: One or more VCPUS are running
> + -EACCES: The virtual ITS is backed by a physical GICv4 ITS, and the
> + state is not available
>
> KVM_DEV_ARM_VGIC_GRP_ITS_REGS
> Attributes:
> diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c
> index eb72eb027060..2710834d0920 100644
> --- a/virt/kvm/arm/vgic/vgic-its.c
> +++ b/virt/kvm/arm/vgic/vgic-its.c
> @@ -1989,6 +1989,15 @@ static int vgic_its_save_itt(struct vgic_its *its, struct its_device *device)
> list_for_each_entry(ite, &device->itt_head, ite_list) {
> gpa_t gpa = base + ite->event_id * ite_esz;
>
> + /*
> + * If an LPI carries the HW bit, this means that this
> + * interrupt is controlled by GICv4, and we do not
> + * have direct access to that state. Let's simply fail
> + * the save operation...
> + */
> + if (ite->irq->hw)
> + return -EACCES;
> +
> ret = vgic_its_save_ite(its, device, ite, gpa, ite_esz);
> if (ret)
> return ret;
>