From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2901FC49EAB for ; Thu, 24 Jun 2021 10:21:12 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 95C48613FE for ; Thu, 24 Jun 2021 10:21:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95C48613FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 0ED224B26E; Thu, 24 Jun 2021 06:21:11 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GUsi68C-IdAP; Thu, 24 Jun 2021 06:21:09 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D89694B26D; Thu, 24 Jun 2021 06:21:09 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4A2814B26D for ; Thu, 24 Jun 2021 06:21:08 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DAsOC6hlAsjG for ; Thu, 24 Jun 2021 06:21:07 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 433474B268 for ; Thu, 24 Jun 2021 06:21:07 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624530067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oKXkBJKG47HF5zZ+T34yALxUp2DCGSnnk7HiRaaGJBk=; b=OyOYIhkFlD72RXa4ApycBznJ8h/A4rxQkZYFz4zqo5MtkH1geetKyPWMfBX0ch0jh7q3Lg qnz7zGgvlyQUIzPbypEimxNaD0+gpIcj0/R+UxQuP9AGOacLVchr1yQsGXdxC66zyvRmgz DHDojJLPq7Dlhzp9U4RjDK0rp/NxRo4= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-443-wtO5CTofM5WUVNGRpdLbyg-1; Thu, 24 Jun 2021 06:21:05 -0400 X-MC-Unique: wtO5CTofM5WUVNGRpdLbyg-1 Received: by mail-ed1-f69.google.com with SMTP id t11-20020a056402524bb029038ffacf1cafso3091079edd.5 for ; Thu, 24 Jun 2021 03:21:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oKXkBJKG47HF5zZ+T34yALxUp2DCGSnnk7HiRaaGJBk=; b=t7De3nTSkjkM+eLrmgccqWuoLk1yqE/F4dTm4nZGupKmc9cPQg3vM7IJ0+Ir/iTcKZ 4ikjgYgoA6s0Dd4uodecfwZ+Hqy/wPicYOTLtYZ0Nw7awknKGpSYbC7voUcH/NIOTV2u XQoAQqmJprAOCPYKJmcPbKqlwDKAkoLosc8UvLx6UbIgnhRZSYa/Z5chjxTDN5LGxXtb JsKLRwF80De61aB0NXkKnKrLP/3cEbou6hgvR5vxqPeYlsrrWexgYt1Vav5CGsQoFXqU 6KzXesFxcXouQQRLU95n8QrckGLVgJd5nAjZxKI2rN76ZqK20eUDxc66/suqSX7IG7K3 GMKQ== X-Gm-Message-State: AOAM531cfHOGMg6WafN/wbpk9hGif3t7Ol7Kkp1gsrkIHvloBWq2o9bh 9er+nm/5sjarsYVz1jECXkwZyEvgOB6SqjCEVTuLM5hAXEenAxySrbsB4RSiU5RGcxFEt0IOghO 7hhIi6V9qABNjEJHbgwSlVLDN X-Received: by 2002:a05:6402:220d:: with SMTP id cq13mr6001647edb.214.1624530064632; Thu, 24 Jun 2021 03:21:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzs51nnE9ArY9tBUvtcT3K4P6rQ2AL9pfX67ccTlvEZ5+BaJldlaSdGdhR+tmPYnfTJgtakmA== X-Received: by 2002:a05:6402:220d:: with SMTP id cq13mr6001609edb.214.1624530064420; Thu, 24 Jun 2021 03:21:04 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id e7sm493571ejm.93.2021.06.24.03.21.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jun 2021 03:21:03 -0700 (PDT) Subject: Re: [PATCH 2/6] KVM: mmu: also return page from gfn_to_pfn To: Nicholas Piggin , Aleksandar Markovic , Huacai Chen , Marc Zyngier , Paul Mackerras , David Stevens , Zhenyu Wang , Zhi Wang References: <20210624035749.4054934-1-stevensd@google.com> <20210624035749.4054934-3-stevensd@google.com> <1624524331.zsin3qejl9.astroid@bobo.none> <201b68a7-10ea-d656-0c1e-5511b1f22674@redhat.com> <1624528342.s2ezcyp90x.astroid@bobo.none> <1624529635.75a1ann91v.astroid@bobo.none> From: Paolo Bonzini Message-ID: Date: Thu, 24 Jun 2021 12:21:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <1624529635.75a1ann91v.astroid@bobo.none> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: Wanpeng Li , kvm@vger.kernel.org, intel-gfx@lists.freedesktop.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, kvmarm@lists.cs.columbia.edu, Will Deacon , kvm-ppc@vger.kernel.org, Sean Christopherson , Vitaly Kuznetsov , linux-mips@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Jim Mattson X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 24/06/21 12:17, Nicholas Piggin wrote: >> If all callers were updated that is one thing, but from the changelog >> it sounds like that would not happen and there would be some gfn_to_pfn >> users left over. >> >> But yes in the end you would either need to make gfn_to_pfn never return >> a page found via follow_pte, or change all callers to the new way. If >> the plan is for the latter then I guess that's fine. > > Actually in that case anyway I don't see the need -- the existence of > gfn_to_pfn is enough to know it might be buggy. It can just as easily > be grepped for as kvm_pfn_page_unwrap. Sure, but that would leave us with longer function names (gfn_to_pfn_page* instead of gfn_to_pfn*). So the "safe" use is the one that looks worse and the unsafe use is the one that looks safe. > And are gfn_to_page cases also > vulernable to the same issue? No, they're just broken for the VM_IO|VM_PFNMAP case. Paolo > So I think it could be marked deprecated or something if not everything > will be converted in the one series, and don't need to touch all that > arch code with this patch. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm