From: Russell Stuart <russell-tcatm@stuart.id.au>
To: lartc@vger.kernel.org
Subject: Re: [LARTC] Patch accurate packet scheduling for ATM/ADSL
Date: Thu, 26 Jul 2007 09:38:44 +0000 [thread overview]
Message-ID: <1185442724.4200.185.camel@ras> (raw)
In-Reply-To: <81c11a560707250614h6d89b614t8c906f8e552248a4@mail.gmail.com>
On Wed, 2007-07-25 at 15:14 +0200, Edouard Thuleau wrote:
> I use the patch
> (http://ace-host.stuart.id.au/russell/files/tc/tc-atm/) for accurate
> the packet scheduling on ATM/ADSL link and i think I've found a bug.
> I tried to write to the author but he didn't answer me.
Sorry. :( I have now.
> I work on a Linux 2.6.17 with the iproute2-2.6.18-061002 package.
> I change the type of the cell_align char to short of the struct
> tc_ratespec in the file pkt_sched.h (in the include/linux/ directories
> of iproute package and the kernel source) :
>
> struct tc_ratespec
> {
> unsigned char cell_log;
> unsigned char __reserved;
> unsigned short feature; /* Always 0 in pre-atm patch kernels */
> - char cell_align; /* Always 0 in pre-atm patch kernels */
> - unsigned char __unused;
> + short cell_align; /* Always 0 in pre-atm patch kernels */
> unsigned short mpu;
> __u32 rate;
> };
>
> The results are much better and with my tests, it works very nicely.
>
> If it can help someone,
I can't see how that would change things as the cell align
always lies within the range -7..0. The only thing that
springs to mind is perhaps you aren't using i386, and your
CPU doesn't sign extend char's??? What CPU are you using?
_______________________________________________
LARTC mailing list
LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/cgi-bin/mailman/listinfo/lartc
next prev parent reply other threads:[~2007-07-26 9:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-25 13:14 [LARTC] Patch accurate packet scheduling for ATM/ADSL Edouard Thuleau
2007-07-26 9:38 ` Russell Stuart [this message]
2007-07-26 10:22 ` Edouard Thuleau
2007-07-26 18:11 ` Philippe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185442724.4200.185.camel@ras \
--to=russell-tcatm@stuart.id.au \
--cc=lartc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox