public inbox for lartc@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Furniss <adf.lists@gmail.com>
To: lartc@vger.kernel.org
Subject: Re: tc and IPv6 : any experiences ?
Date: Fri, 13 Jan 2017 18:02:22 +0000	[thread overview]
Message-ID: <5879162E.1080807@gmail.com> (raw)
In-Reply-To: <200173d8-5856-c64e-55d2-6ce34752882f@auf.org>

Dave Taht wrote:
> On Fri, Jan 13, 2017 at 5:49 AM, Alan Goodman
> <notifications@yescomputersolutions.com> wrote:
>> 'Just works' for me.
>>
>> TF + HFSC + FQ_Codel.  QoS categoriser written in iptables rules which mark
>> the traffic was 'cloned' across using ip6tables. Slight adjustments needed.
>
> I pointed to a common mistake folk tend to make when dealing with
> ipv6, in writing a filter rule, or a default bin, here:
>
> https://www.bufferbloat.net/projects/cerowrt/wiki/Wondershaper_Must_Die/
>
> When I started that rant I was seeing in nearly every off the shelf
> shaper a tc pattern match that looked like this:
>
> tc filter add dev $DEV parent ffff: protocol ip prio 50 u32 match ip src \
>     0.0.0.0/0 police rate ${DOWNLINK}kbit burst 10k drop flowid :1
>
> Instead of
>
> tc filter add dev ${DEV} parent ffff: protocol all match u32 0 0 \
> police rate ${DOWNLINK}kbit burst 100k drop flowid :1
>
>
> Not matching protocol "all", thus ipv4 only - and thus the instant you
> added ipv6 to a network, the shaper (or policer in this case),  failed
> to shape successfully any traffic. Additional problems listed in the
> link above. I went on a search-and-destroy mission on every shaper I
> could find that was public to fix it a few years ago, but there's so
> much copy/pasted tc code out there...

I was about to post that ip is just v4, but would also add - be careful
with protocol all as well. You may end up shaping/dropping "critical"
packets like arp.


  parent reply	other threads:[~2017-01-13 18:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-13 13:21 tc and IPv6 : any experiences ? Willy MANGA
2017-01-13 13:49 ` Alan Goodman
2017-01-13 17:50 ` Dave Taht
2017-01-13 18:02 ` Andy Furniss [this message]
2017-01-13 18:08 ` Dave Taht
2017-01-13 18:25 ` Andy Furniss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5879162E.1080807@gmail.com \
    --to=adf.lists@gmail.com \
    --cc=lartc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox