Linux Advanced Routing and Traffic Control list
 help / color / mirror / Atom feed
From: Amit Gandhi <subscribeamit@yahoo.com>
To: lartc@vger.kernel.org
Subject: Re: [LARTC] Forwarded traffic bypassing filter
Date: Fri, 17 Oct 2003 21:17:38 +0000	[thread overview]
Message-ID: <marc-lartc-106642598311541@msgid-missing> (raw)
In-Reply-To: <marc-lartc-106634010031680@msgid-missing>

I found out the culprit piece of code in the u32 filter classifier. Some
foundation first. I am using 2.4.18 kernel on MPC855T the powerpc
version. 

Now the following code snippet from 'cls_u32.c'

static int u32_classify(struct sk_buff *skb, struct tcf_proto *tp,
struct tcf_result *res)
{
   struct {
      struct tc_u_knode *knode;
      u8      *ptr;
   } stack[TC_U32_MAXDEPTH];

   struct tc_u_hnode *ht = (struct tc_u_hnode*)tp->root;
   u8 *ptr = skb->nh.raw;
   struct tc_u_knode *n;
   int sdepth = 0;
   int off2 = 0;
   int sel = 0;
   int i;

/********* CULPRIT CODE *******/
#if !defined(__i386__) && !defined(__mc68000__)
   if ( (unsigned long)ptr & 3 )
      return -1;
#endif
/********* CULPRIT CODE *******/

......
.........

The above code checks for word alignment of a packet on PowerPC
platforms and it somehow fails for forwarded packets then packets
generated by the local host. Now, I checked newer versions of kernel &
it seems that this piece of code has been removed from them. 

So, this issue is closed.

Thanks,
+Amit

__________________________________
Do you Yahoo!?
The New Yahoo! Shopping - with improved product search
http://shopping.yahoo.com
_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

      parent reply	other threads:[~2003-10-17 21:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-16 21:26 [LARTC] Forwarded traffic bypassing filter Amit Gandhi
2003-10-17 12:38 ` Lawrence MacIntyre
2003-10-17 13:25 ` Amit Gandhi
2003-10-17 13:31 ` Lawrence MacIntyre
2003-10-17 14:59 ` Amit Gandhi
2003-10-17 21:17 ` Amit Gandhi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=marc-lartc-106642598311541@msgid-missing \
    --to=subscribeamit@yahoo.com \
    --cc=lartc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox