From mboxrd@z Thu Jan  1 00:00:00 1970
From: Miguel Bolanos <mike@linuxlabs.com>
Subject: ** Applied ** Re: MAKEDEV patch
Date: Thu, 03 Jun 2004 21:08:24 -0600
Sender: linux-8086-owner@vger.kernel.org
Message-ID: <1086318503.3695.22.camel@talena.hsol.net>
References: <20040602210438.55227.qmail@web51308.mail.yahoo.com>
	 <20040603122107.GD26330@duckman.distro.conectiva>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-U5jC8yxhg4SQXicOsiPC"
Return-path: <linux-8086-owner@vger.kernel.org>
In-Reply-To: <20040603122107.GD26330@duckman.distro.conectiva>
List-Id: <linux-8086.vger.kernel.org>
To: Eduardo Pereira Habkost <ehabkost@conectiva.com.br>
Cc: linux-8086@vger.kernel.org


--=-U5jC8yxhg4SQXicOsiPC
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Applied.

Mike

On Thu, 2004-06-03 at 06:21, Eduardo Pereira Habkost wrote:
> Hi, Tommy,
>=20
> On Wed, Jun 02, 2004 at 02:04:38PM -0700, Tommy McCabe wrote:
> > Fixes the bugs with MAKEDEV:
> >=20
> > 1. Leftovers from trying to move the script off the
> > ELKS disks to save space (All the $DEVDIRS).
>=20
> If a change is unnecessary, I suggest you that you don't include them on
> your patches, because it will make more difficult to check your patches,
> as they are bigger.
>=20
> BTW, your patch file seems to be broken. Did you edited
> it by hand?
>=20
> $ patch -p2 < /tmp/mkdev.patch
> patching file elkscmd/rootfs_template/dev/MAKEDEV
> patch: **** malformed patch at line 23: @@ -28,80 +30,80 @@
>=20
>=20
> >=20
> > 2. ln and mknod are used instead of /bin/ln and
> > /bin/mknod, in case someone doesn't have them in /bin.
>=20
> Good.
>=20
> >=20
> > 3. Proper location is given for MAKESET: in the same
> > directory as MAKEDEV, not in the /dev directory on the
> > hard drive.
>=20
> Good.
>=20
> >=20
> > 4. Changes /bin/test to test, in case it's not in
> > /bin.
>=20
> Good.
>=20
> >=20
> > 5. Reduces the number of partition devices used per
> > hard drive from 64 to 8.
>=20
> Could you explain why? You also changed the meaning
> of the minor numbers. hdb4 was (5,68) and now is
> (5,12).
>=20
> >=20
> > 6. Changes "d" devices to block (or "b") devices,
> > their proper name.
>=20
> Good.
>=20
> >=20
> > 7. Removes the partitions on CD-ROM drives
> > (unimplemented, of course, but who has partitions on a
> > CD?).
>=20
> They are not partitions, they are multiple CD-ROM drives. You can have
> many CD-ROM drives, right?
>=20
> >=20
> > And although I didn't remove this, who really owns a
> > Conrad Electronic Parallel Port Radio Clock? Even
> > Debian doesn't have that.
>=20
> IMO we can drop this one. Linux has it on devices.txt, but I haven't
> seen a driver for it.
>=20
> I redid your patch without the unnecessary changes, below, and a change
> was missing:
>=20
> > --- Mkdev.old	2004-06-03 08:36:04.866192040 -0300
> > +++ MAKEDEV	2004-06-03 08:56:03.164023080 -0300
> > @@ -12,14 +12,14 @@
> >  #
>=20
> (Skipping changes for 2, 3, 4 and 5).
>=20
> > =20
> >  ######################################################################=
########
> >  # Joysticks. These are not yet supported.
> > =20
> > -#	$MKSET   0 15 $MKDEV js c 15
> > -#	$MKSET 128 15 $MKDEV djs c 15
> > +#	$MKDEV js	c 15
> > +#	$MKDEV djs	c 15
>=20
> If joysticks are supported, I guess that we can support multiple
> joysticks.
>=20
> >
> (skipping more changes)
> >=20
>=20
> I redid your patch including just (2), (3), (4) and (6), as those fixes
> can be included. Attached.
>=20
> --
> Eduardo
--=20
--------------------miguel bolanos, systems administrator, linuxlabs
... ........ ..... ....                 230 peachtree st nw ste 2701
the original linux labs                          atlanta.ga.us 30303
       -since 1995                          http://www.linuxlabs.com
                                office 404.577.7747 fax 404.577.7743
--------------------------------------------------------------------

--=-U5jC8yxhg4SQXicOsiPC
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQBAv+endQCX3Gg3xVoRAvQBAKCGY5rrz9rqw1f9tmmOIkL1Ti/NxgCfX2HV
3IVYuizWZfoqCObR6eJluyA=
=Wu9k
-----END PGP SIGNATURE-----

--=-U5jC8yxhg4SQXicOsiPC--