** Applied ** Re: MAKEDEV patch

Miguel Bolanos
2004-06-04T03:08:24Z

[-- Attachment #1: Type: text/plain, Size: 3163 bytes --]

Applied.

Mike

On Thu, 2004-06-03 at 06:21, Eduardo Pereira Habkost wrote:
> Hi, Tommy,
>
> On Wed, Jun 02, 2004 at 02:04:38PM -0700, Tommy McCabe wrote:
> > Fixes the bugs with MAKEDEV:
> >
> > 1. Leftovers from trying to move the script off the
> > ELKS disks to save space (All the $DEVDIRS).
>
> If a change is unnecessary, I suggest you that you don't include them on
> your patches, because it will make more difficult to check your patches,
> as they are bigger.
>
> BTW, your patch file seems to be broken. Did you edited
> it by hand?
>
> $ patch -p2 < /tmp/mkdev.patch
> patching file elkscmd/rootfs_template/dev/MAKEDEV
> patch: **** malformed patch at line 23: @@ -28,80 +30,80 @@
>
>
> >
> > 2. ln and mknod are used instead of /bin/ln and
> > /bin/mknod, in case someone doesn't have them in /bin.
>
> Good.
>
> >
> > 3. Proper location is given for MAKESET: in the same
> > directory as MAKEDEV, not in the /dev directory on the
> > hard drive.
>
> Good.
>
> >
> > 4. Changes /bin/test to test, in case it's not in
> > /bin.
>
> Good.
>
> >
> > 5. Reduces the number of partition devices used per
> > hard drive from 64 to 8.
>
> Could you explain why? You also changed the meaning
> of the minor numbers. hdb4 was (5,68) and now is
> (5,12).
>
> >
> > 6. Changes "d" devices to block (or "b") devices,
> > their proper name.
>
> Good.
>
> >
> > 7. Removes the partitions on CD-ROM drives
> > (unimplemented, of course, but who has partitions on a
> > CD?).
>
> They are not partitions, they are multiple CD-ROM drives. You can have
> many CD-ROM drives, right?
>
> >
> > And although I didn't remove this, who really owns a
> > Conrad Electronic Parallel Port Radio Clock? Even
> > Debian doesn't have that.
>
> IMO we can drop this one. Linux has it on devices.txt, but I haven't
> seen a driver for it.
>
> I redid your patch without the unnecessary changes, below, and a change
> was missing:
>
> > --- Mkdev.old 2004-06-03 08:36:04.866192040 -0300
> > +++ MAKEDEV 2004-06-03 08:56:03.164023080 -0300
> > @@ -12,14 +12,14 @@
> > #
>
> (Skipping changes for 2, 3, 4 and 5).
>
> >
> > ##############################################################################
> > # Joysticks. These are not yet supported.
> >
> > -# $MKSET 0 15 $MKDEV js c 15
> > -# $MKSET 128 15 $MKDEV djs c 15
> > +# $MKDEV js c 15
> > +# $MKDEV djs c 15
>
> If joysticks are supported, I guess that we can support multiple
> joysticks.
>
> >
> (skipping more changes)
> >
>
> I redid your patch including just (2), (3), (4) and (6), as those fixes