From: Phil Goembel <phil-goembel@wi.rr.com>
To: Dieter Kedrowitsch <dieter.kedrowitsch@gmail.com>
Cc: linux-8086@vger.kernel.org
Subject: Re: Console output corruption
Date: Sun, 18 Apr 2010 09:50:13 -0500 [thread overview]
Message-ID: <1271602213.19039.16.camel@castle> (raw)
In-Reply-To: <ba3128e11003101025medb7497j9c1b8d1bdb7ea263@mail.gmail.com>
On Wed, 2010-03-10 at 13:25 -0500, Dieter Kedrowitsch wrote:
> Hans, thanks for the reply.
<snip>
> If anyone who is still following the list has the time and ability to
> help me out, please feel free to chime in!
>
> Thanks!
In elks/kernel/printk.c is the following code for parsing a format
string (line 139, right after detecting a '%'):
width = zero = '0';
if (c == '0')
zero++;
while (c >= '0' && c <= '9') {
width *= 10;
width += c - '0';
c = *fmt++;
}
Notice the width is being set to the value of an ASCII '0' character. I
think it should have been set to the integer value 0 (zero) instead.
It looks like, by default, all fields will have a width of whatever the
ASCII code for '0' (48?).
Phil
next prev parent reply other threads:[~2010-04-18 14:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-10 14:28 Console output corruption Dieter Kedrowitsch
2010-03-10 17:53 ` Hans
2010-03-10 18:25 ` Dieter Kedrowitsch
2010-04-18 14:50 ` Phil Goembel [this message]
2010-04-18 15:17 ` Mario Frasca
2010-04-18 15:45 ` Phil Goembel
2010-04-18 16:07 ` Mario Frasca
-- strict thread matches above, loose matches on Subject: below --
2010-04-18 16:34 Hans
2010-04-18 18:40 ` Phil Goembel
2010-04-18 20:04 ` Mario Frasca
[not found] ` <v2w5a4d65ae1004181614m86200731mcc4a1fcab0cc3a56@mail.gmail.com>
2010-04-19 1:12 ` Kirn Gill
2010-04-19 14:05 ` Mario Frasca
2010-04-19 14:35 ` Mario Frasca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1271602213.19039.16.camel@castle \
--to=phil-goembel@wi.rr.com \
--cc=dieter.kedrowitsch@gmail.com \
--cc=linux-8086@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox