From mboxrd@z Thu Jan  1 00:00:00 1970
From: Phil Goembel <phil-goembel@wi.rr.com>
Subject: Re: Console output corruption
Date: Sun, 18 Apr 2010 09:50:13 -0500
Message-ID: <1271602213.19039.16.camel@castle>
References: <ba3128e11003100628y5b7cd69fy8086f52e5f81837a@mail.gmail.com>
	 <7A01080381764DE0B2C2FF7F21F4DF7E@linux104>
	 <ba3128e11003101025medb7497j9c1b8d1bdb7ea263@mail.gmail.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <linux-8086-owner@vger.kernel.org>
In-Reply-To: <ba3128e11003101025medb7497j9c1b8d1bdb7ea263@mail.gmail.com>
Sender: linux-8086-owner@vger.kernel.org
List-ID: <linux-8086.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
To: Dieter Kedrowitsch <dieter.kedrowitsch@gmail.com>
Cc: linux-8086@vger.kernel.org

On Wed, 2010-03-10 at 13:25 -0500, Dieter Kedrowitsch wrote:
> Hans, thanks for the reply.
<snip>
> If anyone who is still following the list has the time and ability to
> help me out, please feel free to chime in!
> 
> Thanks!

In elks/kernel/printk.c is the following code for parsing a format
string (line 139, right after detecting a '%'):

    width = zero = '0';
    if (c == '0')
        zero++;
    while (c >= '0' && c <= '9') {
        width *= 10;
        width += c - '0';
        c = *fmt++;
    }
 
Notice the width is being set to the value of an ASCII '0' character. I
think it should have been set to the integer value 0 (zero) instead.

It looks like, by default, all fields will have a width of whatever the
ASCII code for '0' (48?).

Phil