From mboxrd@z Thu Jan 1 00:00:00 1970 From: Georg Potthast 2 Subject: Re: Moved eth_* to ne2k_* for future expansion Date: Mon, 6 Mar 2017 13:28:44 +0100 (CET) Message-ID: <1300581257.173577.1488803325070@com4.strato.de> References: <732b2b8d-c4f7-e78f-722a-e50f162a481c@jodybruchon.com> <5F3114D4BFAD484086638649225A66F2@PotthastHP> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1488803698; l=4581; s=domk; d=georgpotthast.de; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Subject: References:In-Reply-To:To:From:Date; bh=8jVbPdcCnEl/Bmoa0nDRmG/ys3SjaDqJBrLpDLUPXvg=; b=I6uDW4WXfpjIPjuwkmar9FGPa1uhVCgAh7IWfML5a22wbgeBqpFCXc8TkjLENVULQz F0LgoS+Fh1oL2kaJNevHaHTYhOnCqshdWQ+tLhNyLBseb6YAw0zLXuh8fCOaufaP3Aom kwE9pzgsANY/3px1Bf+clsn7MnaeNo8o9BjJI= In-Reply-To: Sender: linux-8086-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="utf-8" To: ELKS , "Marc-F. LUCCA-DANIAU" Marc-F., maybe someone else will find a way to support PCI using 16bit code in the f= uture and will want to add an additional driver. So I would use a code stru= cture which allows for additional NIC drivers. I know supporting wireless is difficult but it would be an interesting addi= tion. Georg > "Marc-F. LUCCA-DANIAU" hat am 5. M=C3=A4rz 2017 um 22= :30 geschrieben: >=20 >=20 > Sorry Georg, but I won't spend any time in supporting more Ethernet=20 > devices, because I think that: >=20 > 1) NE2K is the only ISA device provided by QEMU, other need PCI support,= =20 > and ELKS has no PCI support. I don't think adding PCI support would be=20 > in the scope of this project, because PCI came with the 32 bits generatio= n. >=20 > 2) My goal is to run ELKS on my real SBC, that has a NE2K clone chip. I= =20 > am therefore not interested in any other Ethernet chip. >=20 > 3) ELKS is missing the network driver framework, so a discussion for a=20 > generic driver is biased by this limitation. IMHO, the best driver=20 > framework is one generic Ethernet driver, and specialized packet=20 > drivers, with a standard "packet ops" interface for clean branching. The= =20 > template you are dealing with should be not at Ethernet driver level,=20 > but at packet driver level. But again, back to 1) and 2), I see no need= =20 > to develop that framework. >=20 > MFLD >=20 >=20 > Le 05/03/2017 =C3=A0 21:37, Georg Potthast a =C3=A9crit : > > When I look at the drivers in the char directory, most implement their= =20 > > own version of a fops structure and have an init function for the=20 > > kernel. So I would expect that an RTL NIC driver would have the same=20 > > structure as the NE2K driver, again with a fops structure and an init= =20 > > function. I would rather use this template than branch to various=20 > > specific functions from a generic ethernet driver. This mainly because= =20 > > that has been the pattern used by ELKS so far and the developers may=20 > > be more familiar with it. > > > > The *_un and *_in files have been deleted in the=20 > > "elkscmd/test/socket/echo" directory and are replaced with echoserver= =20 > > and echoclient files that will use unix domain sockets if "-u" is=20 > > passed on the command line. > > > > Georg > > > > -----Urspr=C3=BCngliche Nachricht----- From: Marc-Fran=C3=A7ois LUCCA-D= ANIAU > > Sent: Saturday, March 4, 2017 6:48 PM > > To: ELKS > > Subject: Re: Moved eth_* to ne2k_* for future expansion > > > > OK for the changes that seem logical to me, except: > > > > * elks/arch/i86/drivers/net/ne2k-main.c : I actually planned to rename > > this file eth-main.c, because the pattern of any Ethernet driver is > > the same, and will implement the same "fops". Only the call to ne2k_* > > functions are specific. So we should keep the eth_* functions inside > > this module, that are generic. > > > > * elks/arch/i86/drivers/net/ne2k-test.c : renaming the variables > > related to Ethernet protocol and not linked to the NE2K has no sense : > > ne2k_from and ne2k_to, for example, are MAC adresses, and do not > > depend on the underlying Ethernet device. So we should rename them > > back to eth_from and eth_to. > > > > * elkscmd/test/socket/echo/.gitignore : I believe that Georg removed > > *_un and *_in programs, and replaced them by more generic programs ? > > If confirmed, remove *_un and *_in. > > > > * qemu.sh : "system" keyword means that we use the "QEMU system > > emulator". Not the "QEMU program emulator", that is not the same. So > > keep that accurate comment. > > > > MFLD > > > > > > > > > > 2017-03-04 17:46 GMT+01:00 Jody Bruchon : > >> I generalized some network stuff in case other network adapters are > >> supported in the future. Make sure I didn't break anything, > >> > >> -Jody > >> --=20 > >> To unsubscribe from this list: send the line "unsubscribe linux-8086" = in > >> the body of a message to majordomo@vger.kernel.org > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > --=20 > > To unsubscribe from this list: send the line "unsubscribe linux-8086" i= n > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > >=20 > -- > To unsubscribe from this list: send the line "unsubscribe linux-8086" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html