From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eduardo Pereira Habkost <ehabkost@conectiva.com.br>
Subject: Re: Experimental fix for my memcpy_{to,from}fs problem
Date: Thu, 3 Jun 2004 11:14:39 -0300
Sender: linux-8086-owner@vger.kernel.org
Message-ID: <20040603141438.GG26330@duckman.distro.conectiva>
References: <20040601213231.GT21172@duckman.distro.conectiva> <20040601220235.GU21172@duckman.distro.conectiva> <20040601223034.GW21172@duckman.distro.conectiva> <1086145026.3220.41.camel@talena.hsol.net> <20040602162521.GC26330@duckman.distro.conectiva> <1086271338.3227.3.camel@talena.hsol.net>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="3xoW37o/FfUZJwQG"
Return-path: <linux-8086-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <1086271338.3227.3.camel@talena.hsol.net>
List-Id: <linux-8086.vger.kernel.org>
To: linux-8086@vger.kernel.org


--3xoW37o/FfUZJwQG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi, Mike,

On Thu, Jun 03, 2004 at 08:02:18AM -0600, Miguel Bolanos wrote:
> Applied, but i did some changes on the patch, please read bellow.
>=20
> >=20
> >=20
> > --- elks/arch/i86/mm/user.c	2 Jun 2004 03:06:01 -0000	1.16
> > +++ elks/arch/i86/mm/user.c	2 Jun 2004 15:10:16 -0000
> > @@ -39,11 +39,11 @@
> >  	mov	dx,es
> >  	mov	bx,ds
> >  	mov	es,bx
> > -	mov	ax,[bp-2]	! source segment (local variable)
> > +	mov	ax,[bp+.memcpy_fromfs.ds]	! source segment (local variable)
> >  	mov	ds,ax
> > -	mov	di,[bp+4]	! destination address
> > -	mov	si,[bp+6]	! source address
> > -	mov	cx,[bp+8]	! number of bytes to copy
> > +	mov	di,[bp+.memcpy_fromfs.daddr]	! destination address
> > +	mov	si,[bp+.memcpy_fromfs.saddr]	! source address
> > +	mov	cx,[bp+.memcpy_fromfs.len]	! number of bytes to copy
> >  	cld
> >  	rep
> >  	movsb
>=20
> This was already applied on a the previous patch

I think I am missing something. What was applied? The code on CVS is not
using .<function>.<variable> to access the function parameters and
variables. This is what is being changed.

>=20
> > @@ -77,11 +77,11 @@
> >  	push	si
> >  	push	di
> >  	mov	dx,es
> > -	mov	ax,[bp-2]	! source segment (local variable)
> > +	mov	ax,[bp+.memcpy_tofs.es]	! source segment (local variable)
> >  	mov	es,ax
> > -	mov	di,[bp+4]	! destination address
> > -	mov	si,[bp+6]	! source address
> > -	mov	cx,[bp+8]	! number of bytes to copy
> > +	mov	di,[bp+.memcpy_tofs.daddr]	! destination address
> > +	mov	si,[bp+.memcpy_tofs.saddr]	! source address
> > +	mov	cx,[bp+.memcpy_tofs.len]	! number of bytes to copy
> >  	cld
> >  	rep
> >  	movsb
>=20
> This was already done as well.

The CVS don't contain these changes, too. I just 'cvs update'd.

>=20
> > @@ -167,17 +167,17 @@
> >  #ifndef S_SPLINT_S
> >  #asm
> > =20
> > -	mov	ax,[bp-6]	! source segment (local variable)
> > +	mov	ax,[bp+.strlen_fromfs.ds]	! source segment (local variable)
> >  	mov	es,ax
> > -	mov	di,[bp+4]	! source address
> > +	mov	di,[bp+.strlen_fromfs.saddr]	! source address
> >  	cld
> >  	xor	al,al		! search for NULL byte
> >  	mov	cx,#-1
> >  	rep
> >  	scasb
> > -	sub	di,[bp+4]	! calc len +1
> > +	sub	di,[bp+.strlen_fromfs.saddr]	! calc len +1
> >  	dec	di
> > -	mov	[bp-6],di	! save in local var ds
> > +	mov	[bp+.strlen_fromfs.ds],di	! save in local var ds
> >  #endasm
> >  #endif
> > =20
>=20
> This part was applied.

The changes are on CVS? I did an 'cvs update', and the last revision of
user.c (1.17) doesn't contain any of these changes.

--=20
Eduardo

--3xoW37o/FfUZJwQG
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAvzJOcaRJ66w1lWgRAvCaAJ0aMRf577MIiLiL80DJ9m1RSVb0AACgjEEx
sd2T/XuZPj0BOyv2AleiNnE=
=tDdZ
-----END PGP SIGNATURE-----

--3xoW37o/FfUZJwQG--