From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tommy McCabe Subject: Re: Cleanup patch Date: Sat, 5 Jun 2004 10:16:09 -0700 (PDT) Sender: linux-8086-owner@vger.kernel.org Message-ID: <20040605171609.40951.qmail@web51309.mail.yahoo.com> References: Mime-Version: 1.0 Return-path: In-Reply-To: List-Id: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-8086@vger.kernel.org --- claudio@conectiva.com wrote: > On Fri, 4 Jun 2004, Tommy McCabe wrote: > > > This patch cleans up the routines for copying > > rootfs_template into /mnt/test, removing mention > of rootfs_template.tar. > > > > mount_full3fs: $(FULL3_TARGET_FS) > $(ELKSCMD_DIR)/rootfs_template/etc/issue > > $(MKFS) $(MKFS_OPTS) $(FULL3_TARGET_FS) > $(FULL3_TARGET_BLKS) > > sudo -u root mount $(FULL3_TARGET_FS) > $(TARGET_MNT) $(LOOP) > > - (cd $(ELKSCMD_DIR)/rootfs_template ; tar > cf - --exclude CVS *) | \ > > - (cd $(TARGET_MNT) ; tar xpvf -) > > - (cd $(TARGET_MNT)/dev ; ./MAKEDEV) > > + cd $(TARGET_MNT); cp -r > $(ELKSCMD_DIR)/rootfs_template ./ > > + ./dev/MAKEDEV > > > > Copying with tar and excluding CVS is probably a > better idea than using cp, > so you won't have problem with symlinks or special > files, and won't copy CVS > metadata. Symlinks and special file can be taken care of with -a, or -dpR. > Also the sudo won't help here if used only for > mounting the device, it's > a better idea to run the entire make with sudo > otherwise you won't be able > to create the device nodes and set the correct > permissions on files. Good point. Feel free to add sudo wherever necessary. > Perhaps we could write a single disk image building > target and pass parameters > to it from the image specific targets. > > - > To unsubscribe from this list: send the line > "unsubscribe linux-8086" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html __________________________________ Do you Yahoo!? Friends. Fun. Try the all-new Yahoo! Messenger. http://messenger.yahoo.com/