From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tommy McCabe Subject: Re: Vjhc patch Date: Mon, 19 Jul 2004 10:53:41 -0700 (PDT) Sender: linux-8086-owner@vger.kernel.org Message-ID: <20040719175341.23926.qmail@web51308.mail.yahoo.com> References: <20040719152335.GG2830@duckman.distro.conectiva> Mime-Version: 1.0 Return-path: In-Reply-To: <20040719152335.GG2830@duckman.distro.conectiva> List-Id: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-8086@vger.kernel.org --- Eduardo Pereira Habkost wrote: > On Sat, Jul 17, 2004 at 04:51:33PM -0700, Tommy > McCabe wrote: > > Gets rid of the function to define a function > which > > causes errors in elksnet/ktcp/vjhc.c. > > I guess that there was a reason to use DEFUN(), > probably due to support > of different function declaration styles, on > different compilers. If we > choose to remove DEFUN(), I guess that we should > remove because we know > it is not needed for anything, not because of > building errors that can > be caused by errors in other places, not by the use > of DEFUN(). > > And, if you get errors when building, I think that > is good to show which > erros you see. It is not possible to review your > fixes, if we don't know > what is the real reason for you making those > changes. > > For example: ktcp builds without problems here, so I > am very interested > to see why do you get errors on your system, but I > don't see any errors > here. Could you show us the error messages? Look at vjhc.h. There are two definitions of DEFUN, depending on some parameter. One defines a function. The other doesn't. For some reason, the parameter got changed over the years, so now anything using DEFUn comes out as gibberish to the compiler. > > --- ./elkscomp/elksnet/ktcp/vjhc.c 2002-07-28 > 11:45:45.000000000 -0400 > > +++ ./elkscurr/elksnet/ktcp/vjhc.c 2004-07-17 > 19:46:40.000000000 -0400 > > @@ -113,10 +113,8 @@ > > } > > } > > > > -DEFUN > > -(int ip_vjhc_compress, (pkt), > > - pkt_ut *pkt > > -) > > +int ip_vjhc_compress(pkt_ut *pkt) > > + > > { > > iphdr_t *ip_hdr, *oip_hdr; > > tcphdr_t *tcp_hdr, *otcp_hdr; > > @@ -388,10 +386,8 @@ > > return PPP_TYPE_VJHC_COMPR; > > } > > > > -DEFUN > > -(void ip_vjhc_arr_uncompr, (pkt), > > - pkt_ut *pkt > > -) > > +void ip_vjhc_arr_uncompr(pkt_ut *pkt) > > + > > { > > rcv_state_ut *state; > > iphdr_t *ip_hdr; > > @@ -430,10 +426,8 @@ > > > > } > > > > -DEFUN > > -(void ip_vjhc_arr_compr, (pkt), > > - pkt_ut *pkt > > -) > > +void ip_vjhc_arr_compr(pkt_ut *pkt) > > + > > { > > iphdr_t *ip_hdr; > > tcphdr_t *tcp_hdr; > > > -- > Eduardo > > ATTACHMENT part 2 application/pgp-signature __________________________________ Do you Yahoo!? New and Improved Yahoo! Mail - Send 10MB messages! http://promotions.yahoo.com/new_mail