From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bojan Popovic Subject: Re: [PATCH] Ansi-C compatibility fixes Date: Mon, 20 Aug 2012 21:30:56 +0200 Message-ID: <20120820213056.23a78842@deathstar.universe> References: <502678AC.2060307@jodybruchon.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:subject:message-id:in-reply-to:references :x-mailer:mime-version:content-type:content-transfer-encoding; bh=jdQSK4NserSnBGmm7FJDUHmlsywlg7DVQKV6dfQSUfs=; b=aYFdZ+qB/zzw4T/mobreYaf69DspDIhHZqpX8SRQVW9XkadFXQrRTvyrN7elUTOReM gy6zssSXAjbUsFmAYxOOpkQmNGWxiNINgxlgmb4QzLMsujIjyCh5sknW29r4+9kY27dN gmTo3Uvnfkaj7bK9LRg5QMdRoSzghBj+ApDxE+7EKcBkJsDiQXzWqZUVSO3XFpKMwCMq N4Qr6Be0dNFTY+tcsNsJFDn/WUli+qecvCqdRbocL6M0tQ5N8KPXqawZs98m6IkEQrZx kmk2ga+kpnYZAeHqw8dnsAOnjgzJdBSNrZ2Rp4iHWxIWiStVuQLxdvT+LaQsm8i8iE3b 2sXg== In-Reply-To: <502678AC.2060307@jodybruchon.com> Sender: linux-8086-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: linux-8086@vger.kernel.org Hi, I tried building the current git snapshot. It builds fine (tested on Slackware 14.0rc2) and the image runs nicely in Qemu 1.1.1. But there is a small problem in elks/arch/i86/Makefile. Newline (\n) is not parsed by echo and it gets in asm-offsets.h (ie: \n#endif instead of #endif). --- Makefile.orig 2012-08-20 20:54:06.000000000 +0200 +++ Makefile 2012-08-20 21:06:07.197644614 +0200 @@ -88,7 +88,7 @@ $(BASEDIR)/include/arch/asm-offsets.h: kernel/asm-offsets.c $(CC) $(CFLAGS) -S -o asm-offsets.s kernel/asm-offsets.c echo '#ifndef ASM_OFFSETS_H' > $(BASEDIR)/include/arch/asm-offsets.h - echo '#define ASM_OFFSETS_H\n' >> $(BASEDIR)/include/arch/asm-offsets.h + echo -e '#define ASM_OFFSETS_H\n' >> $(BASEDIR)/include/arch/asm-offsets.h sed -e '/^[^m].*/ d' \ -e 's/\],/ /' \ -e 's/ #/ /' \ @@ -97,7 +97,7 @@ -e 's/^.*\[_/#define /' \ -e 's/ax/0/' \ < asm-offsets.s | grep -e define >> $(BASEDIR)/include/arch/asm-offsets.h - echo '\n#endif' >> $(BASEDIR)/include/arch/asm-offsets.h + echo -e '\n#endif' >> $(BASEDIR)/include/arch/asm-offsets.h rm asm-offsets.s ######################################################################### Bojan. On Sat, 11 Aug 2012 11:22:20 -0400 Jody Bruchon wrote: > Juan and everyone else, I just wanted to let you all know that the > patches submitted to this point have been pushed to the Git > repository on SourceForge. Thank you Juan! You've done some pretty > amazing work on the ELKS project. I'm definitely impressed at what > you've managed to do. > > I'm thinking of dropping another "release" of 0.1.5 after some more > testing. It couldn't hurt to get these serious bug fixes out there as > a version bump. > > Jody Bruchon