From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: SPLINT: sys_open missing a parameter in init/main.c
Date: Mon, 29 Apr 2002 01:11:45 +0100 (BST)
Sender: linux-8086-owner@vger.kernel.org
Message-ID: <E171yle-0004y2-00@the-village.bc.nu>
References: <Pine.LNX.4.21.0204281819010.8763-100000@Consulate.UFP.CX>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <linux-8086-owner@vger.kernel.org>
In-Reply-To: <Pine.LNX.4.21.0204281819010.8763-100000@Consulate.UFP.CX> from "Riley Williams" at Apr 28, 2002 10:15:21 PM
List-Id: <linux-8086.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
To: Riley@Williams.Name
Cc: Harry Kalogirou <harkal@gmx.net>, Linux 8086 <linux-8086@vger.kernel.org>

> The funtion sys_open is defined with three parameters...
> 	int sys_open(char *filename, int flags, int mode);
> 
> ...but in init/main.c it is called with only two parameters...

Thats sort of fine. The third parameter is optional in open() syscalls and
is the mode for creation. Historically ancient unix had creat() and no
3 argument open.

> ...and I haven't the foggiest how to correct this. Can somebody rather
> more knowledgable than I am advise regarding this please?

Stuff a ",0" on the end - its not needed but its good for correctness and
portability