From: Robert de Bath <robert$@mayday.cix.co.uk>
To: Riley Williams <Riley@Williams.Name>
Cc: Manuel Novoa III <mjn3@codepoet.org>,
Linux-8086 <linux-8086@vger.kernel.org>
Subject: Re: More dev86 changes (0.16.5)
Date: Fri, 26 Jul 2002 09:22:25 +0100 (BST) [thread overview]
Message-ID: <e37d8208b918d458@mayday.cix.co.uk> (raw)
In-Reply-To: <Pine.LNX.4.21.0207242221470.30515-100000@Consulate.UFP.CX>
On Wed, 24 Jul 2002, Riley Williams wrote:
> Hi Robert.
>
> >> 1) #elif support.
>
> > In 0.16.5
> > Do we want #elifdef too?
>
> If we support it as a variant of #if then we also want it as a variant
> of #elif as well, in my opinion. Therefore, we will want...
>
> #elif
> #elifdef
> #elifndef
>
> ...together with any other variants that may exist.
Actually, thinking about this, where do these 'def' varients come from
IIRC 'elif' is Ansi-C but I don't think the others are, plus of course
you can use "#elif defined(VARNAME)"
> >> 2) #warning support (at least for non-continued lines).
>
> > In 0.16.5
>
> With or without the continued lines?
Without so far, I'll probably fix it later; and add #error (as a specific)
oh and skipping '#pragma'.
> Also (inspired by the way it's used in your example below, but taken
> from a C compiler I once used on a Burroughs B6700 mainframe), could
> support be added for the following...
>
> a. #debug msg
> b. #debugn msg
> c. #info msg
> d. #onerr msg
Possibly useful but I've _never_ come across them before and never though
of them as (WIBNI). IMO the '#debug' ones are useless, they'd (maybe)
be used once per program and as you mentioned '#warning' does the job.
_IF_ I implemented them I don't think it'd be directly as this, possibly
as '#pragma' varients would be ok. ("#pragma toplevel" perhaps)
> I would like to see the code produe a warning for the fact that the
> macro defenition for strong_alias() includes the terminating semicolon
> that should never be present on macro definitions - and yes, I know the
> Linux kernel uses several macros that break this rule. Linus himself
> states that they're wrong, but they're so well embedded that it's more
> hassle than it's worth to fix the problem...
NO. Null statments are frequently required in C and it's _very_ difficult
to guess it one is wrong; I have come across a compiler that could be
configured to warn about them and tried it, PITA.
Even the specific case of a semicolon at the end of a macro is dubious
though more easily detected. If I were going to start adding style
warnings I'd start with the potentially damaging ones (eg = rather
than ==).
--
Rob. (Robert de Bath <robert$ @ debath.co.uk>)
<http://www.cix.co.uk/~mayday>
next prev parent reply other threads:[~2002-07-26 8:22 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-14 14:05 C compiler, assembler and linker Harry Kalogirou
2002-07-14 17:27 ` Manuel Novoa III
2002-07-15 6:07 ` Riley Williams
2002-07-15 17:02 ` Manuel Novoa III
2002-07-15 19:13 ` Riley Williams
2002-07-15 22:02 ` Manuel Novoa III
2002-07-16 6:27 ` Riley Williams
2002-07-17 1:31 ` Manuel Novoa III
2002-07-17 6:33 ` Riley Williams
2002-07-18 12:03 ` Minix vs. ELKS Feher Tamas
2002-07-18 12:27 ` Javier Sedano
2002-07-02 15:07 ` (unknown) Miguel A. Bolanos
2002-07-18 13:40 ` Minix vs. ELKS Alan Cox
2002-07-22 21:41 ` C compiler, assembler and linker Robert de Bath
2002-07-23 8:16 ` Robert de Bath
2002-07-23 16:25 ` Manuel Novoa III
2002-07-23 19:09 ` Robert de Bath
2002-07-24 21:17 ` More dev86 changes (0.16.5) Robert de Bath
2002-07-24 22:02 ` Riley Williams
2002-07-25 15:42 ` Manuel Novoa III
2002-07-26 7:55 ` Robert de Bath
2002-07-26 15:12 ` Manuel Novoa III
2002-07-26 8:22 ` Robert de Bath [this message]
2002-07-24 22:26 ` Paul Nasrat
2002-07-25 16:34 ` Manuel Novoa III
2002-07-22 23:26 ` C compiler, assembler and linker Robert de Bath
2002-07-23 0:34 ` Riley Williams
2002-07-23 0:58 ` Manuel Novoa III
2002-07-23 0:46 ` Manuel Novoa III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e37d8208b918d458@mayday.cix.co.uk \
--to=robert$@mayday.cix.co.uk \
--cc=Riley@Williams.Name \
--cc=linux-8086@vger.kernel.org \
--cc=mjn3@codepoet.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox