From: Nigel Cunningham <ncunningham-oKK1aGe2n869koe0gwxAeg@public.gmane.org>
To: 'Lyle Seaman' <lws-RAHWjsxJnJUdnm+yROfE0A@public.gmane.org>
Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
'Herbert Nachtnebel'
<Herbert.Nachtnebel-8zxNtbQCHXIjuwv8T7myQQ@public.gmane.org>
Subject: RE: AW: Re: [PATCH] S4bios for 2.5.52.
Date: Fri, 20 Dec 2002 09:12:20 +1300 [thread overview]
Message-ID: <000b01c2a79a$f13045b0$0101010a@NigelLaptop> (raw)
In-Reply-To: <20021219150600.C5DBE1480A-RAHWjsxJnJUdnm+yROfE0A@public.gmane.org>
Hmm. I didn't think that carefully about what was causing the write to
occur. Hence I unrolled I took your patch further and completely separated
the submitting of _all_ of the pages from the block_flushpage calls for all
of the pages (ie two loops). (I saw much more than a one second gain, even
on my faster desktop computer!) After reading this, I think I should look
sooner at what is going. I was going to anyway, but I was concentrating on
getting my whole port from 2.4 working first.
I'm not promising anything quickly - I have plenty of 'real' work at the
moment :>
Regards,
Nigel
> Still, writing pages synchronously, one at a time, is going
> to be slow no
> matter what you do. *Especially* on slow laptop drives.
>
> What I sent Nigel was a little patch to write them 20 at a
> time, which reduced
> my suspend times from nearly 60 seconds to something around 2
> seconds. I
> stopped at 20 because going beyond that was chasing
> diminishing returns and I
> didn't think that chewing up a huge chunk of stack was
> justified for a
> one-second reduction in suspend times.
>
> I didn't send it on to the rest of the list because I figure
> Nigel's other
> changes will be coming along as well, and I didn't want to
> make merging too
> difficult for everyone.
-------------------------------------------------------
This SF.NET email is sponsored by: Geek Gift Procrastinating?
Get the perfect geek gift now! Before the Holidays pass you by.
T H I N K G E E K . C O M http://www.thinkgeek.com/sf/
next prev parent reply other threads:[~2002-12-19 20:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Herbert.Nachtnebel@tuwien.ac.at>
[not found] ` <B900970C7DD9474C972986EB3EC7C58F0D404E-PWLG29+z7hEKeIAE67mlpo2P0GrZ+RbP@public.gmane.org>
2002-12-19 15:05 ` AW: Re: [PATCH] S4bios for 2.5.52 Lyle Seaman
[not found] ` <20021219150600.C5DBE1480A-RAHWjsxJnJUdnm+yROfE0A@public.gmane.org>
2002-12-19 20:12 ` Nigel Cunningham [this message]
2002-12-19 20:04 ` Nigel Cunningham
2002-12-19 9:49 AW: " Herbert Nachtnebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000b01c2a79a$f13045b0$0101010a@NigelLaptop' \
--to=ncunningham-okk1age2n869koe0gwxaeg@public.gmane.org \
--cc=Herbert.Nachtnebel-8zxNtbQCHXIjuwv8T7myQQ@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=lws-RAHWjsxJnJUdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox