From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Sricharan" Subject: RE: [PATCH V7 09/11] arm64: dma-mapping: Remove the notifier trick to handle early setting of dma_ops Date: Mon, 30 Jan 2017 13:34:18 +0530 Message-ID: <005201d27acf$7924a7b0$6b6df710$@codeaurora.org> References: <1485188293-20263-1-git-send-email-sricharan@codeaurora.org> <1485188293-20263-10-git-send-email-sricharan@codeaurora.org> <20170128210611.GF20550@bhelgaas-glaptop.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170128210611.GF20550-1RhO1Y9PlrlHTL0Zs8A6p5iNqAH0jzoTYJqu5kTmcBRl57MIdRCFDg@public.gmane.org> Content-Language: en-us List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: 'Bjorn Helgaas' Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-acpi@vger.kernel.org >> With arch_setup_dma_ops now being called late during device's probe after >> the device's iommu is probed, the notifier trick required to handle the >> early setup of dma_ops before the iommu group gets created is not >> required. So removing the notifier's here. > >s/notifier's/notifiers/ > ok, will change. >Personally I'd capitalize "IOMMU" in the English text above, too. > ok, will change this too. Regards, Sricharan >> Acked-by: Will Deacon >> Signed-off-by: Sricharan R >> [rm: clean up even more] >> Signed-off-by: Robin Murphy >> --- >> arch/arm64/mm/dma-mapping.c | 132 ++++---------------------------------------- >> 1 file changed, 12 insertions(+), 120 deletions(-) > >Nice :)