public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Joyful Lee <joy@joyfullee.me>
Cc: "Bjorn Helgaas" <helgaas@kernel.org>,
	platform-driver-x86@vger.kernel.org,
	"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	linux-pci@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
	linux-acpi@vger.kernel.org,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	linux-kernel@vger.kernel.org, "Lukas Wunner" <lukas@wunner.de>
Subject: Re: [BUG] ASUS ProArt PX13 HN7306WU: amd_pmc s2idle S0ix corrupts AMD 1022:150b root port, NVIDIA dGPU returns header type 7f
Date: Fri, 3 Apr 2026 16:05:35 -0500	[thread overview]
Message-ID: <024bce0e-5bc7-40ca-be01-278ef9935531@amd.com> (raw)
In-Reply-To: <CADj6jrgEwySW_A=-0o947aGg+CmaZD+qR4NnopVFoQptdHz=bQ@mail.gmail.com>

On 4/3/26 3:47 PM, Joyful Lee wrote:
> On Fri, Apr 3, 2026 at 4:03 PM Mario Limonciello
> <mario.limonciello@amd.com> wrote:
>> Can you do the exact same on the same branch/commit but without pciehp
>> enabled?  It will make comparison of all the impacts (not just this root
>> port) a lot easier.
> 
> Here you go. Unfortunately it's not *exactly* the same because I had to
> disable the nvidia driver to get a result.

Thanks - the most obvious observation is what you already noted - 
without hotplug support the root port skips PM all together.

[24.575705] pcieport 0000:00:01.2: PCI PM: Suspend power state: D0
[24.575707] pcieport 0000:00:01.2: PCI PM: Skipped
[24.575709] pcieport 0000:00:01.1: PCI PM: Suspend power state: D0
[24.575709] pcieport 0000:00:01.1: PCI PM: Skipped

vs

[29.279987] pcieport 0000:00:01.1: power state changed by ACPI to D3cold
[29.279991] pcieport 0000:00:01.1: PCI PM: Suspend power state: D3cold
[29.280214] pcieport 0000:00:01.2: power state changed by ACPI to D3cold
[29.280219] pcieport 0000:00:01.2: PCI PM: Suspend power state: D3cold

The hotplug support seems to apply to 3 ports.

   0000:00:01.1 (Bus 01):
   - Slot Capabilities: 0x00040060
   - Flags: HotPlug+ Surprise+ LLActRep+

   0000:00:01.2 (Bus 61):
   - Slot Capabilities: 0x00040060
   - Flags: HotPlug+ Surprise+ LLActRep+

   0000:00:03.1 (Bus c4):
   - Slot Capabilities: 0x000425e0
   - Flags: HotPlug+ Surprise+ LLActRep+
   - This port also has bandwidth control enabled: bwctrl: enabled with 
IRQ 38

The port stays in D0 because the child (the GPU) stays in D0 for suspend.

   [24.599889] pcieport 0000:00:03.1: PCI PM: Suspend power state: D0 
  
  

   [24.599890] pcieport 0000:00:03.1: PCI PM: Skipped

So I would say we should look at what the GPU isn't going to D3 for 
suspend for the next clue.

  reply	other threads:[~2026-04-03 21:05 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-02 18:49 [BUG] ASUS ProArt PX13 HN7306WU: amd_pmc s2idle S0ix corrupts AMD 1022:150b root port, NVIDIA dGPU returns header type 7f Joyful Lee
2026-04-02 19:58 ` Mario Limonciello
2026-04-02 20:59   ` Joyful Lee
2026-04-02 21:14     ` Mario Limonciello
2026-04-02 21:32       ` Joyful Lee
2026-04-03 13:23         ` Mario Limonciello
2026-04-03 14:11           ` Joyful Lee
2026-04-03 14:24             ` Mario Limonciello
2026-04-03 16:19               ` Joyful Lee
2026-04-03 16:48                 ` Mario Limonciello
2026-04-03 18:04                   ` Bjorn Helgaas
2026-04-03 18:41                     ` Mario Limonciello
2026-04-03 19:10                       ` Bjorn Helgaas
2026-04-03 19:11                         ` Mario Limonciello
2026-04-03 19:07                     ` Joyful Lee
2026-04-03 20:02                       ` Mario Limonciello
2026-04-03 20:47                         ` Joyful Lee
2026-04-03 21:05                           ` Mario Limonciello [this message]
2026-04-03 21:28                             ` Mario Limonciello
2026-04-05  7:16                               ` Lukas Wunner
2026-04-05  7:05                     ` Lukas Wunner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=024bce0e-5bc7-40ca-be01-278ef9935531@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=bhelgaas@google.com \
    --cc=hansg@kernel.org \
    --cc=helgaas@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=joy@joyfullee.me \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox