From: Dave Hansen <dave.hansen@intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
x86 Maintainers <x86@kernel.org>,
Linux PM <linux-pm@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Len Brown <lenb@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
"Gautham R. Shenoy" <gautham.shenoy@amd.com>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Linux ACPI <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v1 4/5] ACPI: processor: Rescan "dead" SMT siblings during initialization
Date: Thu, 5 Jun 2025 09:14:54 -0700 [thread overview]
Message-ID: <06122416-b24a-493b-9374-550e5c290436@intel.com> (raw)
In-Reply-To: <2005721.PYKUYFuaPT@rjwysocki.net>
On 6/5/25 08:07, Rafael J. Wysocki wrote:
> #ifdef CONFIG_ACPI_PROCESSOR_CSTATE
> +void acpi_idle_rescan_dead_smt_siblings(void)
> +{
> + if (cpuidle_get_driver() == &acpi_idle_driver)
> + arch_cpu_rescan_dead_smt_siblings();
> +}
My only thought in reading this is that maybe cpuidle_register_driver()
would be a better spot to force the arch_cpu_rescan_dead_smt_siblings().
That way, each driver would not have to do the rescan.
But that's just a little nit at worst, otherwise the series looks good
to me. Thanks for chasing this down.
For the x86 bits:
Acked-by: Dave Hansen <dave.hansen@linux.intel.com>
next prev parent reply other threads:[~2025-06-05 16:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 15:03 [PATCH v1 0/5] x86/smp: Restore the elimination of mwait_play_dead_cpuid_hint() Rafael J. Wysocki
2025-06-05 15:04 ` [PATCH v1 1/5] intel_idle: Use subsys_initcall_sync() for initialization Rafael J. Wysocki
2025-06-05 15:05 ` [PATCH v1 2/5] x86/smp: PM/hibernate: Split arch_resume_nosmt() Rafael J. Wysocki
2025-06-05 15:06 ` [PATCH v1 3/5] intel_idle: Rescan "dead" SMT siblings during initialization Rafael J. Wysocki
2025-06-05 15:07 ` [PATCH v1 4/5] ACPI: processor: " Rafael J. Wysocki
2025-06-05 16:14 ` Dave Hansen [this message]
2025-06-05 18:20 ` Rafael J. Wysocki
2025-06-05 15:09 ` [PATCH v1 5/5] Reapply "x86/smp: Eliminate mwait_play_dead_cpuid_hint()" Rafael J. Wysocki
2025-06-06 10:51 ` [PATCH v1 0/5] x86/smp: Restore the elimination of mwait_play_dead_cpuid_hint() Artem Bityutskiy
2025-06-06 10:53 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06122416-b24a-493b-9374-550e5c290436@intel.com \
--to=dave.hansen@intel.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=gautham.shenoy@amd.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox