From: Heiner Kallweit <hkallweit1@gmail.com>
To: Ruslan Babayev <ruslan@babayev.com>,
Wolfram Sang <wsa@the-dreams.de>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Russell King <linux@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>
Cc: xe-linux-external@cisco.com,
"David S. Miller" <davem@davemloft.net>,
linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: phy: sfp: enable i2c-bus detection on ACPI based systems
Date: Sun, 5 May 2019 21:51:15 +0200 [thread overview]
Message-ID: <085da32a-8c3a-bf91-38b0-4802375ae414@gmail.com> (raw)
In-Reply-To: <20190505193435.3248-1-ruslan@babayev.com>
On 05.05.2019 21:34, Ruslan Babayev wrote:
> Signed-off-by: Ruslan Babayev <ruslan@babayev.com>
> Cc: xe-linux-external@cisco.com
> ---
> drivers/i2c/i2c-core-acpi.c | 3 ++-
> drivers/net/phy/sfp.c | 33 +++++++++++++++++++++++++--------
> include/linux/i2c.h | 6 ++++++
> 3 files changed, 33 insertions(+), 9 deletions(-)
>
Regarding the formal part:
- It should be [PATCH net-next]
- Commit description is missing (scripts/checkpatch.pl should have complained)
And maybe it would be better to split exporting i2c_acpi_find_adapter_by_handle
and extending sfp.c to two patches. If Wolfram acks the i2c patch, then I think
the series could go through the netdev tree. Eventually up to David.
next prev parent reply other threads:[~2019-05-05 19:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-05 19:34 [PATCH] net: phy: sfp: enable i2c-bus detection on ACPI based systems Ruslan Babayev
2019-05-05 19:34 ` Ruslan Babayev
2019-05-05 19:51 ` Heiner Kallweit [this message]
2019-05-05 19:51 ` Heiner Kallweit
2019-05-05 20:51 ` [PATCH 1/2] i2c: acpi: export i2c_acpi_find_adapter_by_handle Ruslan Babayev
2019-05-05 20:51 ` Ruslan Babayev
2019-05-25 0:53 ` [PATCH net-next v2 " Ruslan Babayev
2019-05-27 8:39 ` Mika Westerberg
2019-05-28 2:26 ` Ruslan Babayev
2019-05-27 18:47 ` Wolfram Sang
2019-05-28 2:03 ` Ruslan Babayev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=085da32a-8c3a-bf91-38b0-4802375ae414@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mika.westerberg@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=ruslan@babayev.com \
--cc=wsa@the-dreams.de \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox