From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [alsa-devel] [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks Date: Thu, 22 Dec 2016 10:29:07 -0800 Message-ID: <08b66c14-eb0d-4b3e-7b10-906e10bc1454@codeaurora.org> References: <1481306510-7471-1-git-send-email-irina.tirdea@intel.com> <1481306510-7471-2-git-send-email-irina.tirdea@intel.com> <20161213232524.GQ5423@codeaurora.org> <32235fb3-0d54-211d-28f4-4655e4bc7812@linux.intel.com> <20161217013337.GW5423@codeaurora.org> <7f3d03dc-24fe-ec3f-4a3b-926c28f0ac86@linux.intel.com> <20161221230557.GK5423@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: platform-driver-x86-owner@vger.kernel.org To: Pierre-Louis Bossart Cc: Andy Shevchenko , ALSA Development Mailing List , linux-clk@vger.kernel.org, Irina Tirdea , Pierre-Louis Bossart , Michael Turquette , "x86@kernel.org" , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , Ingo Molnar , Mark Brown , "H. Peter Anvin" , Darren Hart , Takashi Iwai , platform-driver-x86@vger.kernel.org, Thomas Gleixner , Len Brown List-Id: linux-acpi@vger.kernel.org On 12/21/2016 05:07 PM, Pierre-Louis Bossart wrote: > On 12/21/16 5:05 PM, Stephen Boyd wrote: >> >> Ok, by clkdev design if a device is passed but there isn't a >> match in the lookup table it allows it to match based solely on >> the connection id. Given that the connection id is globally >> unique this will work. >> >> Hopefully we don't have two of these devices with pmc_plt_clk_ >> signals in a single system though. Then having the device name >> would help differentiate between the two. And then it may make >> sense to have some sort of ACPI lookup system, similar to how we >> have lookups for clks in DT. > > So in short we keep the existing solution for now and will only use > the device name if and when the pmc_plt_clk_ identifier is no > longer unique due to hardware changes. Did I get this right? Ok. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project