From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49FA6C77B73 for ; Thu, 1 Jun 2023 01:48:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229874AbjFABsz (ORCPT ); Wed, 31 May 2023 21:48:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229618AbjFABsy (ORCPT ); Wed, 31 May 2023 21:48:54 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57C5BA3; Wed, 31 May 2023 18:48:52 -0700 (PDT) Received: from dggpemm500002.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QWpqy5DdHzLqM9; Thu, 1 Jun 2023 09:45:50 +0800 (CST) Received: from [10.174.178.247] (10.174.178.247) by dggpemm500002.china.huawei.com (7.185.36.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 1 Jun 2023 09:48:49 +0800 Subject: Re: [PATCH] acpi: Fix header declaration of acpi_arch_dma_setup() w/o CONFIG_ACPI To: Dave Jiang , , CC: kernel test robot , Jianmin Lv , "Rafael J. Wysocki" , , , , , References: <168477156440.3873520.6153672647621739139.stgit@djiang5-mobl3> From: Hanjun Guo Message-ID: <0953941a-ad4e-ba7e-4f4e-64c47de71f0b@huawei.com> Date: Thu, 1 Jun 2023 09:48:32 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <168477156440.3873520.6153672647621739139.stgit@djiang5-mobl3> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.247] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500002.china.huawei.com (7.185.36.229) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi Dave, Sorry for the late reply, I have some comments inline. On 2023/5/23 0:06, Dave Jiang wrote: > arm64 build can be done without CONFIG_ACPI. The ifdef bits for > acpi_arch_dma_setup() is placed inside CONFIG_ACPI. When CONFIG_ACPI is > not set, this causes warning reported by kernel test bot. Move the > prototype declaration for acpi_arch_dma_setup() outside of CONFIG_ACPI. ... > >>> drivers/acpi/arm64/dma.c:7:6: warning: no previous prototype for function 'acpi_arch_dma_setup' [-Wmissing-prototypes] > void acpi_arch_dma_setup(struct device *dev) > ^ > drivers/acpi/arm64/dma.c:7:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > void acpi_arch_dma_setup(struct device *dev) > ^ > static > 1 warning generated. drivers/acpi can only be compiled with CONFIG_ACPI=y, so drivers/acpi/arm64/ will be the same, not sure how to trigger this compile warning. I disable CONFIG_ACPI on my ARM64 machine, but didn't get the warning you reported. > > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202305200933.afKCLlxS-lkp@intel.com/ How to generate the kernel config file as you kindly attached in the link? Thanks Hanjun