From: Woody Suwalski <terraluna977@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Guanbing Huang <albanhuang@outlook.com>,
Guanbing Huang <albanhuang@tencent.com>
Subject: Re: [PATCH v1 1/1] PNP: Export pnp_bus_type for modules
Date: Mon, 27 May 2024 18:20:09 -0400 [thread overview]
Message-ID: <0a1a22c8-ed43-532e-bd91-e82d404eaf89@gmail.com> (raw)
In-Reply-To: <20240527202424.1430103-1-andy.shevchenko@gmail.com>
Andy Shevchenko wrote:
> Since we have dev_is_pnp() macro that utilises the address of pnp_bus_type
> variable, the users, which can be compiled as modules, will be failed to
> build. Export the variable to the modules to prevent build breakage.
>
> Reported-by: Woody Suwalski <terraluna977@gmail.com>
> Closes: https://lore.kernel.org/r/cc8a93b2-2504-9754-e26c-5d5c3bd1265c@gmail.com
> Fixes: 2a49b45cd0e7 ("PNP: Add dev_is_pnp() macro")
> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
> drivers/pnp/driver.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pnp/driver.c b/drivers/pnp/driver.c
> index 0a5d0d8befa8..1394d17bd6f7 100644
> --- a/drivers/pnp/driver.c
> +++ b/drivers/pnp/driver.c
> @@ -265,6 +265,7 @@ const struct bus_type pnp_bus_type = {
> .pm = &pnp_bus_dev_pm_ops,
> .dev_groups = pnp_dev_groups,
> };
> +EXPORT_SYMBOL(pnp_bus_type);
>
> int pnp_register_driver(struct pnp_driver *drv)
> {
Confirm the patch works OK.
Tested-by: Woody Suwalski <terraluna977@gmail.com>
Thanks, Woody
next prev parent reply other threads:[~2024-05-27 22:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 20:24 [PATCH v1 1/1] PNP: Export pnp_bus_type for modules Andy Shevchenko
2024-05-27 22:20 ` Woody Suwalski [this message]
2024-05-28 4:58 ` Christoph Hellwig
2024-05-28 7:10 ` Andy Shevchenko
2024-05-28 7:12 ` Andy Shevchenko
2024-05-28 7:14 ` Christoph Hellwig
2024-05-28 9:42 ` Rafael J. Wysocki
2024-05-28 9:52 ` Andy Shevchenko
2024-05-28 9:58 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a1a22c8-ed43-532e-bd91-e82d404eaf89@gmail.com \
--to=terraluna977@gmail.com \
--cc=albanhuang@outlook.com \
--cc=albanhuang@tencent.com \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox