Re: [PATCH v5 1/4] ACPI: NHLT: Reintroduce types the table consists of

[Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>]

> +/* Values for link_type field above */
> +
> +#define ACPI_NHLT_LINKTYPE_HDA			0
> +#define ACPI_NHLT_LINKTYPE_DSP			1
> +#define ACPI_NHLT_LINKTYPE_PDM			2
> +#define ACPI_NHLT_LINKTYPE_SSP			3
> +#define ACPI_NHLT_LINKTYPE_SLIMBUS		4
> +#define ACPI_NHLT_LINKTYPE_SDW			5
> +#define ACPI_NHLT_LINKTYPE_UAOL			6

More than half of those values are not used. Is there really any benefit
in exposing them?

NHLT is really only useful for SSP and PDM...

> +
> +/* Values for device_id field above */
> +
> +#define ACPI_NHLT_DEVICEID_DMIC			0xAE20
> +#define ACPI_NHLT_DEVICEID_BT			0xAE30
> +#define ACPI_NHLT_DEVICEID_I2S			0xAE34
> +
> +/* Values for device_type field above */
> +
> +/* Device types unique to endpoint of link_type=PDM */
> +#define ACPI_NHLT_DEVICETYPE_PDM		0
> +#define ACPI_NHLT_DEVICETYPE_PDM_SKL		1

I never understood this _SKL part. is this used?

> +/* Device types unique to endpoint of link_type=SSP */
> +#define ACPI_NHLT_DEVICETYPE_BT			0
> +#define ACPI_NHLT_DEVICETYPE_FM			1
> +#define ACPI_NHLT_DEVICETYPE_MODEM		2
> +#define ACPI_NHLT_DEVICETYPE_CODEC		4