From: Randy Dunlap <rdunlap@infradead.org>
To: Yang Li <yang.lee@linux.alibaba.com>, rafael@kernel.org, lenb@kernel.org
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] ACPI: Add kernel-doc comments to handle_eject_request function
Date: Fri, 8 Mar 2024 08:02:27 -0800 [thread overview]
Message-ID: <0efda75a-dde6-42e0-86dc-993f0d1c4730@infradead.org> (raw)
In-Reply-To: <20240308073214.11262-1-yang.lee@linux.alibaba.com>
On 3/7/24 23:32, Yang Li wrote:
> This patch adds proper kernel-doc comments to the
> handle_eject_request function in the ACPI dock subsystem.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
LGTM. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> drivers/acpi/dock.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c
> index a89bdbe00184..a7c00ef78086 100644
> --- a/drivers/acpi/dock.c
> +++ b/drivers/acpi/dock.c
> @@ -380,6 +380,8 @@ static int dock_in_progress(struct dock_station *ds)
>
> /**
> * handle_eject_request - handle an undock request checking for error conditions
> + * @ds: The dock station to undock.
> + * @event: The ACPI event number associated with the undock request.
> *
> * Check to make sure the dock device is still present, then undock and
> * hotremove all the devices that may need removing.
--
#Randy
next prev parent reply other threads:[~2024-03-08 16:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 7:32 [PATCH -next] ACPI: Add kernel-doc comments to handle_eject_request function Yang Li
2024-03-08 16:02 ` Randy Dunlap [this message]
2024-03-13 20:03 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0efda75a-dde6-42e0-86dc-993f0d1c4730@infradead.org \
--to=rdunlap@infradead.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox