Re: [PATCH] warning: implicit declaration of function mp_config_ioapic_for_sci

["Sérgio Monteiro Basto" <sergiomb-5ng0By4jB+/QUPosyRRdSA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 793 bytes --]

First of all thanks for replying to this email and for the information.

so I remade the patch, and (I think) now is a good patch, because is not
need declared the mp_config_ioapic_for_sci function.


On Tue, 2002-10-08 at 07:59, Matthew Wilcox wrote: 
> On Tue, Oct 08, 2002 at 02:55:57AM -0400, Sérgio Monteiro Basto wrote:
> > +++ linux-2.4.19acpi/include/asm-i386/mpspec.h	Sun Oct  6 21:34:06 2002
>                                ^^^^^^^^
> > +#ifdef CONFIG_X86
> > +extern void mp_config_ioapic_for_sci(int irq);
> > +#endif /*CONFIG_X86*/
> 
> you really don't need to encase this in CONFIG_X86.  if it's in asm-i386
> and some other cpu type is including this file, things are already
> hideously wrong.
> 
> -- 
> Revolutions do not require corporate support.
> 

[-- Attachment #2: acpi_explicit2.diff --]
[-- Type: text/plain, Size: 558 bytes --]

--- linux-2.4.19orig/drivers/acpi/bus.c	Sun Oct  6 21:39:56 2002
+++ linux-2.4.19acpi/drivers/acpi/bus.c	Wed Oct  9 01:00:12 2002
@@ -1883,10 +1883,14 @@
 
 #ifdef CONFIG_X86
         /* Ensure the SCI is set to level-triggered, active-low */
+#ifdef CONFIG_X86_IO_APIC
         if (acpi_ioapic)
          	mp_config_ioapic_for_sci(acpi_fadt.sci_int);
 	else
                 eisa_set_level_irq(acpi_fadt.sci_int);
+#else
+	eisa_set_level_irq(acpi_fadt.sci_int);
+#endif
 #endif
 
 	status = acpi_enable_subsystem(ACPI_FULL_INITIALIZATION);