Re: Re: S4bios support for 2.5.63

Re: Re: S4bios support for 2.5.63

[Chris Bennett]

On Monday 03 March 2003 8:52 am, Alan Cox wrote:
> On Sun, 2003-03-02 at 20:21, bert hubert wrote:
> > On Mon, Mar 03, 2003 at 07:44:03AM +1300, Nigel Cunningham wrote:
> > > Hi.
> > >
> > > This bug is fixed in Linus tree. If you want swsusp to work in the mean
> > > time, look for a couple of patches Pavel sent recently.
> >
> > Ok,
> >
> > In 2.5.63bk5 I get a BUG on drivers/ide/ide-disk.c:1557:
> >
> >
> >         BUG_ON (HWGROUP(drive)->handler);
>
> Looks like swsuspend attempted to run an operation while one was in
> progress. IDE tries to catch that because the result of missing it isnt
> very pretty at fsck time.
>

Forgive me for my misunderstanding (i"m only new to acpi/kernel development), 
but if the problem is swsuspend running an operation while one is in 
progress, is there anyway way to pause the suspend process until all 
operations are done, so that IDE has nothing to catch....?

I have the same problem in 2.6.63 + acpi20030228 when entering S3, except it 
happens occasionally, not all the time.

Regards,

Chris Bennett


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

RE: Re: S4bios support for 2.5.63

[Breathnach, Proinnsias (Dublin)]

Simplify the link somewhat ... avoids wraparound problems :)
http://tardis.linux.ie/714/groups.google.com
tardis.linux.ie is there for this sort of thing ... just an FYI really :)
Proinnsias

> -----Original Message-----
> A data point may be that at one point, swsusp did work just fine for me.
> This was around 2.5.53, 2.5.54:
> 
> http://groups.google.com/groups?hl=en&lr=&ie=UTF-8&oe=UTF-8&threadm=200212
> 27142032.GA6945%40outpost.ds9a.nl&rnum=1&prev=/groups%3Fq%3Dswsusp%2Bbert%
> 2Bhubert%26hl%3Den%26lr%3D%26ie%3DUTF-8%26oe%3DUTF-8%26selm%3D200212271420
> 32.GA6945%2540outpost.ds9a.nl%26rnum%3D1
> 
> I now use gcc 3.2.2 for compiling though. I've tried suspending a few
> times
> with 2.5.63bk5 and I get the BUG every time, so it appears to be
> deterministic and not racey.
> 
> Regards,
> 
> bert
> 



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

Re: Re: S4bios support for 2.5.63

[Troels Haugboelle]

[-- Attachment #1: Type: text/plain, Size: 1280 bytes --]

Hi,

just to add my experience. Maybe it helps. I haven't been able to get
swsusp working on any 2.4.x kernel until i did an
    hdparm -u1 /dev/hda
now the strange thing: I tried to turn on the frame buffer device and
it started chrashing again until i did
    hdparm -u0 /dev/hda
Before I tried using suspend in 2.5.x with varying success. Now
everything runs like a charm. Without unmask irq's first the kernel
dumped
with either a kernel BUG statement or a fault in ide-disk.c

hope it helps, regards

Troels Haugboelle

PS. I am running on fujitsu lifebook P4-M laptop with reiserfs and intel
845 chipset.
I have only one hard disk too.

On Mon, 2003-03-03 at 13:41, Pavel Machek wrote:

> Hi!
> 
> > [ pruned mr Grover from the CC list ]
> > 
> > On Mon, Mar 03, 2003 at 01:23:25PM +0100, Pavel Machek wrote:
> > > Well, it does not happen on my machines, but I've already seen it
> > > happen on computer with two harddrives.
> > 
> > This is a laptop with only one. Anything I can do to help, let me know. Alan
> > has suggested that an IDE transaction was still in progress, perhaps a small
> > wait could prove/disprove this assumption?
> 
> Start adding printks to see whats going on. Try going ext2. Try
> killing sys_sync() from kernel/suspend.c.
> 
> 									Pavel

[-- Attachment #2: Type: text/html, Size: 1707 bytes --]

Re: Re: S4bios support for 2.5.63

[Ken Hughes]

On 2003.03.05 23:22 Ken Hughes wrote:
> On Tue, 2003-03-04 at 12:39, Roger Luethi wrote:
>> On Tue, 04 Mar 2003 11:06:50 +1300, Nigel Cunningham wrote:
>> > You were hitting the BUG_ON before swsusp was even trying to write 
>> the
>> > image?!! That is interesting! Since count_and_copy is first called 
>> post
>> > driver suspend in the current version, perhaps they are somehow 
>> related.
>> > (This is before swsusp tries to write any of the image to disk).
>> 
>> Huh? After a glance at the code I agree that drivers_suspend happens 
>> before
>> count_and_copy_data_pages, but that means hitting the BUG_ON in
>> idedisk_suspend before the panic in count_and_copy_data_pages is 
>> what I'd
>> expect. How is that remarkable? ... My current kernel has HIGHMEM 
>> enabled,
>> but previous ones that failed the same way didn't.
> 
> I was surprised because I thought you were getting the BUG_ON during
> writing the image. Now I see that it's well beforehand.
> 
>> Anyway, a few more tests showed that hdparm -u1 helps if I have lots 
>> of
>> memory used (say for fs caches). In two out of two tests, I saw 
>> Pavel's
>> request to send him 1 GB RAM via email.
> 
> On this topic, would you be willing to test a 2.4 version that 
> supported
> highmem? I haven't written support yet, but hope to do it shortly. (I
> don't have that much ram myself so you can send me 1GB if you prefer
> :>).
>> Suspending directly from a clean boot (after issuing the same hdparm 
>> -u1
>> commands for both disks) I hit the BUG_ON in idedisk_suspend (two ut 
>> of
>> two tests, too).

Not sure if this helps any, but I just tried S4 on my Toshiba Satellite 
5105
under 2.5.64 (the first time I've been able to get 2.5.x to boot with 
any
ACPI support).  From the root login I've been able to do
     echo "4" >/proc/acpi/sleep
and get suspend/resume to work fine.  I then tried it from X11R6 and got
the "kernel BUG at drivers/ide/ide-disk.c:1557!" error.

I tried debugging this a little and was surprised to find that I only 
get
this oops about half the time while running X:  the other half this 
system
completes the suspend, and resume brings me right back where I left off
(which would be nice; this doesn't work under 2.4.20).

I also noticed that when the suspend works, the "freeing memory: ....."
messages prints out about 100 periods.  The first 20 or so come slowly,
then it zips through most of the others.  When it oops's, it prints out
about 15 or so periods before the panic.  This seems similar to what 
Bert was
saying in an earlier message:

> Sure, I get this too:
> 
> It now says (copied by hand):
> 
>         freeing memory: .....................|
> (this 'freeing' takes ages, around 30 seconds, while in progress, the 
> disk
>  light blinks every once in a while, perhaps each time while a dot is 
> being
> printed)
>         syncing disks
>         suspending devices

FWIW, I have one hard drive and I'm using ext3 file systems.

----
Ken




-------------------------------------------------------
This SF.net email is sponsored by: Etnus, makers of TotalView, The debugger 
for complex code. Debugging C/C++ programs can leave you feeling lost and 
disoriented. TotalView can help you find your way. Available on major UNIX 
and Linux platforms. Try it free. www.etnus.com

Re: Re: S4bios support for 2.5.63

[Nigel Cunningham]

On Thu, 2003-03-06 at 20:42, Ken Hughes wrote:
> I also noticed that when the suspend works, the "freeing memory: ....."
> messages prints out about 100 periods.  The first 20 or so come slowly,
> then it zips through most of the others.  When it oops's, it prints out
> about 15 or so periods before the panic.  This seems similar to what 
> Bert was
> saying in an earlier message:

This is because of the algorithm being used. 2.5 swsusp currently tries
to free as much memory as it can, and then writes the remainder to disk.
Freeing the memory can take quite a while. A port of the 2.4 code is in
progress (hopefully it will be accepted :>).

Regards,

Nigel



-------------------------------------------------------
This SF.net email is sponsored by: Etnus, makers of TotalView, The debugger 
for complex code. Debugging C/C++ programs can leave you feeling lost and 
disoriented. TotalView can help you find your way. Available on major UNIX 
and Linux platforms. Try it free. www.etnus.com