Re: help needed with invalid method in GPE block

["Charl P. Botha" <c.p.botha-ra0OqMccq8edIhEUFHOBvg@public.gmane.org>]

On Tue, 2003-03-18 at 01:19, Charl P. Botha wrote:
> On Mon, Mar 17, 2003 at 03:57:00PM -0800, Moore, Robert wrote:
> > Here's what the code should look like
> > 
> >     /* Ensure that we have a valid GPE number for this GPE block */
> > 
> >     if ((GpeNumber < GpeBlock->BlockBaseNumber) ||
> >         (GpeNumber >= (GpeBlock->BlockBaseNumber + (GpeBlock->RegisterCount
> > * 8))))
> >     {
> >         /* 
> >          * Not valid for this GPE block, just ignore it
> >          * However, it may be valid for a different GPE block, since GPE0
> > and GPE1
> >          * methods both appear under \_GPE.
> >          */
> >         return (AE_OK);
> >     }
> 
> Aaaah, the "if" is now clearly corrected.  The way it was did constitute a
> bug, right?  It resulted in control methods that were valid for the second
> GPE block not getting added.

BTW, before making this change, my laptop would go INSTANTLY to sleep if
I pressed the sleep button.  After applying it, messages flash by
indicating that the kernel is preparing devices for the suspend.

This would mean that, in my case, the handler for method _L1D() was not
being added (in either GPE block), so the Notify() by that method was
not getting handled by the kernel, which was a bad thing.

Will this fix go into the next BK push, or whatever it's called?

Thanks,
Charl

-- 
charl p. botha http://cpbotha.net/ http://visualisation.tudelft.nl/


-------------------------------------------------------
This SF.net email is sponsored by: Does your code think in ink? 
You could win a Tablet PC. Get a free Tablet PC hat just for playing. 
What are you waiting for?
http://ads.sourceforge.net/cgi-bin/redirect.pl?micr5043en