Patch for ospmd thermal gui

Patch for ospmd thermal gui

[Knut Neumann]

[-- Attachment #1: Type: text/plain, Size: 1336 bytes --]

Hello Andrew,

as you suggested last year I made the ospmd_gui have a thermal page. Now
I found the time to clean the patch up and send it to you.

While working on the clean-up, it struck me that I took a wrong
direction in comparison to what you have in mind about libpower/ospmd:

I always thought to transparently export the acpi interface through
ospmd/libpower. That is why I made one struct (PM_THERMAL_DATA) per
zone. Now that seems plain wrong to me.

As I understand today you want ospmd to gather those information needed
for power management (policies) from /proc/acpi and export control of
ospmd via libpower - is that right?

In conclusion that would rather mean to have access to eg cooling
mode/temperature (in ospmd _and_ libpower) via:

pm_set_thermal_cooling
pm_get_thermal_cooling
pm_get_thermal_temperature

to be able to either set cooling mode from the gui directly or have a
policy in ospmd that eg switches cooling mode to active when a certain
temperature is reached.

Sorry for not simply doing it and sending a patch - but it seems to me
that I rather create more work for you by doing it wrong than by trying
to understand your picture of ospmd/libpower development first.

Regards
-Knut
-- 
Knut Neumann <knut.neumann-4bfl1RV3iZDOEhgYWvzSCYQuADTiUCJX@public.gmane.org>


[-- Attachment #2: thermalgui.patch --]
[-- Type: text/x-patch, Size: 18978 bytes --]

diff -Nur ospmd-20030327.autotools/gui/Makefile.am ospmd/gui/Makefile.am
--- ospmd-20030327.autotools/gui/Makefile.am	Mon Mar 31 18:39:54 2003
+++ ospmd/gui/Makefile.am	Mon Mar 31 15:05:28 2003
@@ -7,7 +7,8 @@
 	moc_BatDetails.cpp		\
 	moc_CriticalAlarmDialog.cpp	\
 	moc_BatteryPage.cpp		\
-	moc_PowerPage.cpp
+	moc_PowerPage.cpp		\
+	moc_ThermalPage.cpp
 
 BUILT_SOURCES		=		\
 	$(MOC_FILES)
@@ -40,6 +41,8 @@
 	ButtonPage.cpp		\
 	LowAlarmDialog.h	\
 	ButtonPage.h		\
+	ThermalPage.h		\
+	ThermalPage.cpp		\
 	$(MOC_FILES)
 
 ospmd_gui_LDADD = $(top_srcdir)/libpower/libpower.la -L/usr/X11R6/lib $(LIB_QT)
diff -Nur ospmd-20030327.autotools/gui/PropertySheet.cpp ospmd/gui/PropertySheet.cpp
--- ospmd-20030327.autotools/gui/PropertySheet.cpp	Mon Mar 31 18:38:28 2003
+++ ospmd/gui/PropertySheet.cpp	Mon Mar 31 15:08:16 2003
@@ -126,7 +126,7 @@
 
 PropertySheet::PropertySheet( QWidget *parent, const char *name, bool modal, WFlags f )
     : QTabDialog( parent, name, modal, f ), gi(parent,name), bp(parent,name),
-	pBat(parent,name), pp(parent,name)
+      pBat(parent,name), pp(parent,name), tp(parent, name)
 {
 	int err;
 	pt = NULL;
@@ -176,6 +176,7 @@
 
 	addTab( &pp, "Power" );
 
+	addTab( &tp, "Thermal" );
 
 	// Note that the dialog can have as many as four buttons.
 	// There is always an OK button.
diff -Nur ospmd-20030327.autotools/gui/PropertySheet.h ospmd/gui/PropertySheet.h
--- ospmd-20030327.autotools/gui/PropertySheet.h	Mon Mar 31 18:38:28 2003
+++ ospmd/gui/PropertySheet.h	Mon Mar 31 15:10:32 2003
@@ -184,6 +184,7 @@
 #include "ButtonPage.h"
 #include "BatteryPage.h"
 #include "PowerPage.h"
+#include "ThermalPage.h"
 
 /*Linux OSPM GUI main QTabDialog "property sheet" include*/
 #include "PropertySheetDefs.h"
@@ -206,7 +207,8 @@
 	ButtonPage bp;
 	Batteries pBat;
 	PowerPage pp;
-
+	ThermalPage tp;
+	
 public slots:
 	void CloseMe();
 
diff -Nur ospmd-20030327.autotools/gui/ThermalPage.cpp ospmd/gui/ThermalPage.cpp
--- ospmd-20030327.autotools/gui/ThermalPage.cpp	Thu Jan  1 01:00:00 1970
+++ ospmd/gui/ThermalPage.cpp	Mon Mar 31 17:06:19 2003
@@ -0,0 +1,207 @@
+/*
+  Filename: ThermalPage.cpp
+  Purpose:  To display information on the computers Thermal Zone(s)
+*/
+
+/******************************************************************************
+ *
+ * 1. Copyright Notice
+ *
+ * Some or all of this work - Copyright (c) 1999-2002, Intel Corp.
+ * All rights reserved.
+ *
+ * 2. License
+ *
+ * 2.1. This is your license from Intel Corp. under its intellectual property
+ * rights.  You may have additional license terms from the party that provided
+ * you this software, covering your right to use that party's intellectual
+ * property rights.
+ *
+ * 2.2. Intel grants, free of charge, to any person ("Licensee") obtaining a
+ * copy of the source code appearing in this file ("Covered Code") an
+ * irrevocable, perpetual, worldwide license under Intel's copyrights in the
+ * base code distributed originally by Intel ("Original Intel Code") to copy,
+ * make derivatives, distribute, use and display any portion of the Covered
+ * Code in any form, with the right to sublicense such rights; and
+ *
+ * 2.3. Intel grants Licensee a non-exclusive and non-transferable patent
+ * license (with the right to sublicense), under only those claims of Intel
+ * patents that are infringed by the Original Intel Code, to make, use, sell,
+ * offer to sell, and import the Covered Code and derivative works thereof
+ * solely to the minimum extent necessary to exercise the above copyright
+ * license, and in no event shall the patent license extend to any additions
+ * to or modifications of the Original Intel Code.  No other license or right
+ * is granted directly or by implication, estoppel or otherwise;
+ *
+ * The above copyright and patent license is granted only if the following
+ * conditions are met:
+ *
+ * 3. Conditions
+ *
+ * 3.1. Redistribution of Source with Rights to Further Distribute Source.
+ * Redistribution of source code of any substantial portion of the Covered
+ * Code or modification with rights to further distribute source must include
+ * the above Copyright Notice, the above License, this list of Conditions,
+ * and the following Disclaimer and Export Compliance provision.  In addition,
+ * Licensee must cause all Covered Code to which Licensee contributes to
+ * contain a file documenting the changes Licensee made to create that Covered
+ * Code and the date of any change.  Licensee must include in that file the
+ * documentation of any changes made by any predecessor Licensee.  Licensee
+ * must include a prominent statement that the modification is derived,
+ * directly or indirectly, from Original Intel Code.
+ *
+ * 3.2. Redistribution of Source with no Rights to Further Distribute Source.
+ * Redistribution of source code of any substantial portion of the Covered
+ * Code or modification without rights to further distribute source must
+ * include the following Disclaimer and Export Compliance provision in the
+ * documentation and/or other materials provided with distribution.  In
+ * addition, Licensee may not authorize further sublicense of source of any
+ * portion of the Covered Code, and must include terms to the effect that the
+ * license from Licensee to its licensee is limited to the intellectual
+ * property embodied in the software Licensee provides to its licensee, and
+ * not to intellectual property embodied in modifications its licensee may
+ * make.
+ *
+ * 3.3. Redistribution of Executable. Redistribution in executable form of any
+ * substantial portion of the Covered Code or modification must reproduce the
+ * above Copyright Notice, and the following Disclaimer and Export Compliance
+ * provision in the documentation and/or other materials provided with the
+ * distribution.
+ *
+ * 3.4. Intel retains all right, title, and interest in and to the Original
+ * Intel Code.
+ *
+ * 3.5. Neither the name Intel nor any other trademark owned or controlled by
+ * Intel shall be used in advertising or otherwise to promote the sale, use or
+ * other dealings in products derived from or relating to the Covered Code
+ * without prior written authorization from Intel.
+ *
+ * 4. Disclaimer and Export Compliance
+ *
+ * 4.1. INTEL MAKES NO WARRANTY OF ANY KIND REGARDING ANY SOFTWARE PROVIDED
+ * HERE.  ANY SOFTWARE ORIGINATING FROM INTEL OR DERIVED FROM INTEL SOFTWARE
+ * IS PROVIDED "AS IS," AND INTEL WILL NOT PROVIDE ANY SUPPORT,  ASSISTANCE,
+ * INSTALLATION, TRAINING OR OTHER SERVICES.  INTEL WILL NOT PROVIDE ANY
+ * UPDATES, ENHANCEMENTS OR EXTENSIONS.  INTEL SPECIFICALLY DISCLAIMS ANY
+ * IMPLIED WARRANTIES OF MERCHANTABILITY, NONINFRINGEMENT AND FITNESS FOR A
+ * PARTICULAR PURPOSE.
+ *
+ * 4.2. IN NO EVENT SHALL INTEL HAVE ANY LIABILITY TO LICENSEE, ITS LICENSEES
+ * OR ANY OTHER THIRD PARTY, FOR ANY LOST PROFITS, LOST DATA, LOSS OF USE OR
+ * COSTS OF PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES, OR FOR ANY INDIRECT,
+ * SPECIAL OR CONSEQUENTIAL DAMAGES ARISING OUT OF THIS AGREEMENT, UNDER ANY
+ * CAUSE OF ACTION OR THEORY OF LIABILITY, AND IRRESPECTIVE OF WHETHER INTEL
+ * HAS ADVANCE NOTICE OF THE POSSIBILITY OF SUCH DAMAGES.  THESE LIMITATIONS
+ * SHALL APPLY NOTWITHSTANDING THE FAILURE OF THE ESSENTIAL PURPOSE OF ANY
+ * LIMITED REMEDY.
+ *
+ * 4.3. Licensee shall not export, either directly or indirectly, any of this
+ * software or system incorporating such software without first obtaining any
+ * required license or other approval from the U. S. Department of Commerce or
+ * any other agency or department of the United States Government.  In the
+ * event Licensee exports any such software from the United States or
+ * re-exports any such software from a foreign destination, Licensee shall
+ * ensure that the distribution and export/re-export of the software is in
+ * compliance with all laws, regulations, orders, or other restrictions of the
+ * U.S. Export Administration Regulations. Licensee agrees that neither it nor
+ * any of its subsidiaries will export/re-export any technical data, process,
+ * software, or service, directly or indirectly, to any country for which the
+ * United States government or any agency thereof requires an export license,
+ * other governmental approval, or letter of assurance, without first obtaining
+ * such license, approval or letter.
+ *
+ *****************************************************************************/
+
+
+#include "ThermalPage.h"
+
+char* thermal_mode[]={"<Not Supported>", "Active", "Passive"};
+char* thermal_state[]={"Ok", "Critical"};
+
+ThermalPage::ThermalPage( QWidget *parent, const char *name): QWidget(parent, name)
+{
+	int count = 0;
+
+	qfFont = new QFont ("Helvetica", 11, QFont::Bold);
+
+	qlIntro = new QLabel(this);
+	qlIntro->setFont(*qfFont);
+	qlIntro->setGeometry(20,20,420,40);
+	qlIntro->setFrameStyle( QFrame::Box | QFrame::Raised );
+	qlIntro->setMargin(2);
+	qlIntro->setAlignment( Qt::AlignTop | Qt::AlignLeft );
+	qlIntro->setTextFormat( Qt::RichText );
+	qlIntro->setIndent(2);
+	qsIntro = new QString();
+
+	if( qsIntro != NULL )
+	{
+		qsIntro->sprintf("Select Thermal Zone from List to display information about it.\n");
+		qlIntro->setText(*qsIntro);
+	}
+
+	qlZK = new QLabel (this);
+	qlZK->setFont (*qfFont);
+	qlZK->setGeometry (20,80,240,20);
+	qsZK = new QString ();
+	qsZK->sprintf("Thermal Zone");
+	qlZK->setText(*qsZK);
+
+	cbZoneKey = new QComboBox(FALSE, this);
+	cbZoneKey->setFont(*qfFont);
+	cbZoneKey->setGeometry(180, 80, 110, 20);
+
+	pm_get_thermal_data (&data);
+
+	/* [FIXME: Have a key item in PM_THERMAL_DATA] */
+	
+	cbZoneKey->insertItem ("THRM");
+
+	qlCM = new QLabel(this);
+	qlCM->setFont(*qfFont);
+	qlCM->setGeometry(20,120,240,20);
+	qsCM = new QString ();
+	qsCM->sprintf("Cooling Mode: \t\t%s", thermal_mode[data.cooling_mode]);
+	qlCM->setText(*qsCM);
+
+	qlPF = new QLabel(this);
+	qlPF->setFont(*qfFont);
+	qlPF->setGeometry(20,140,240,20);
+	qsPF = new QString ();
+	qsPF->sprintf("Polling Frequency: \t%i", data.polling_frequency);
+	qlPF->setText(*qsPF);
+
+	qlST = new QLabel(this);
+	qlST->setFont(*qfFont);
+	qlST->setGeometry(20,160,240,20);
+	qsST = new QString ();
+	qsST->sprintf("State: \t\t\t%s", thermal_state[data.state]);
+	qlST->setText(*qsST);
+
+	qlTP = new QLabel(this);
+	qlTP->setFont(*qfFont);
+	qlTP->setGeometry(20,180,240,20);
+	qsTP = new QString ();
+	qsTP->sprintf("Temperature: \t\t%i °C", data.temperature);
+	qlTP->setText(*qsTP);
+}
+
+ThermalPage::~ThermalPage ()
+{
+ 	delete qsTP;
+	delete qlTP;
+
+ 	delete qsST;
+	delete qlST;
+
+ 	delete qsPF;
+	delete qlPF;
+
+ 	delete qsCM;
+	delete qlCM;
+
+	delete qsIntro;
+	delete qlIntro;
+
+	delete qfFont;
+}
diff -Nur ospmd-20030327.autotools/gui/ThermalPage.h ospmd/gui/ThermalPage.h
--- ospmd-20030327.autotools/gui/ThermalPage.h	Thu Jan  1 01:00:00 1970
+++ ospmd/gui/ThermalPage.h	Mon Mar 31 17:03:09 2003
@@ -0,0 +1,188 @@
+
+// Filename: ThermalPage.h
+
+/******************************************************************************
+ *
+ * 1. Copyright Notice
+ *
+ * Some or all of this work - Copyright (c) 1999-2002, Intel Corp.
+ * All rights reserved.
+ *
+ * 2. License
+ *
+ * 2.1. This is your license from Intel Corp. under its intellectual property
+ * rights.  You may have additional license terms from the party that provided
+ * you this software, covering your right to use that party's intellectual
+ * property rights.
+ *
+ * 2.2. Intel grants, free of charge, to any person ("Licensee") obtaining a
+ * copy of the source code appearing in this file ("Covered Code") an
+ * irrevocable, perpetual, worldwide license under Intel's copyrights in the
+ * base code distributed originally by Intel ("Original Intel Code") to copy,
+ * make derivatives, distribute, use and display any portion of the Covered
+ * Code in any form, with the right to sublicense such rights; and
+ *
+ * 2.3. Intel grants Licensee a non-exclusive and non-transferable patent
+ * license (with the right to sublicense), under only those claims of Intel
+ * patents that are infringed by the Original Intel Code, to make, use, sell,
+ * offer to sell, and import the Covered Code and derivative works thereof
+ * solely to the minimum extent necessary to exercise the above copyright
+ * license, and in no event shall the patent license extend to any additions
+ * to or modifications of the Original Intel Code.  No other license or right
+ * is granted directly or by implication, estoppel or otherwise;
+ *
+ * The above copyright and patent license is granted only if the following
+ * conditions are met:
+ *
+ * 3. Conditions
+ *
+ * 3.1. Redistribution of Source with Rights to Further Distribute Source.
+ * Redistribution of source code of any substantial portion of the Covered
+ * Code or modification with rights to further distribute source must include
+ * the above Copyright Notice, the above License, this list of Conditions,
+ * and the following Disclaimer and Export Compliance provision.  In addition,
+ * Licensee must cause all Covered Code to which Licensee contributes to
+ * contain a file documenting the changes Licensee made to create that Covered
+ * Code and the date of any change.  Licensee must include in that file the
+ * documentation of any changes made by any predecessor Licensee.  Licensee
+ * must include a prominent statement that the modification is derived,
+ * directly or indirectly, from Original Intel Code.
+ *
+ * 3.2. Redistribution of Source with no Rights to Further Distribute Source.
+ * Redistribution of source code of any substantial portion of the Covered
+ * Code or modification without rights to further distribute source must
+ * include the following Disclaimer and Export Compliance provision in the
+ * documentation and/or other materials provided with distribution.  In
+ * addition, Licensee may not authorize further sublicense of source of any
+ * portion of the Covered Code, and must include terms to the effect that the
+ * license from Licensee to its licensee is limited to the intellectual
+ * property embodied in the software Licensee provides to its licensee, and
+ * not to intellectual property embodied in modifications its licensee may
+ * make.
+ *
+ * 3.3. Redistribution of Executable. Redistribution in executable form of any
+ * substantial portion of the Covered Code or modification must reproduce the
+ * above Copyright Notice, and the following Disclaimer and Export Compliance
+ * provision in the documentation and/or other materials provided with the
+ * distribution.
+ *
+ * 3.4. Intel retains all right, title, and interest in and to the Original
+ * Intel Code.
+ *
+ * 3.5. Neither the name Intel nor any other trademark owned or controlled by
+ * Intel shall be used in advertising or otherwise to promote the sale, use or
+ * other dealings in products derived from or relating to the Covered Code
+ * without prior written authorization from Intel.
+ *
+ * 4. Disclaimer and Export Compliance
+ *
+ * 4.1. INTEL MAKES NO WARRANTY OF ANY KIND REGARDING ANY SOFTWARE PROVIDED
+ * HERE.  ANY SOFTWARE ORIGINATING FROM INTEL OR DERIVED FROM INTEL SOFTWARE
+ * IS PROVIDED "AS IS," AND INTEL WILL NOT PROVIDE ANY SUPPORT,  ASSISTANCE,
+ * INSTALLATION, TRAINING OR OTHER SERVICES.  INTEL WILL NOT PROVIDE ANY
+ * UPDATES, ENHANCEMENTS OR EXTENSIONS.  INTEL SPECIFICALLY DISCLAIMS ANY
+ * IMPLIED WARRANTIES OF MERCHANTABILITY, NONINFRINGEMENT AND FITNESS FOR A
+ * PARTICULAR PURPOSE.
+ *
+ * 4.2. IN NO EVENT SHALL INTEL HAVE ANY LIABILITY TO LICENSEE, ITS LICENSEES
+ * OR ANY OTHER THIRD PARTY, FOR ANY LOST PROFITS, LOST DATA, LOSS OF USE OR
+ * COSTS OF PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES, OR FOR ANY INDIRECT,
+ * SPECIAL OR CONSEQUENTIAL DAMAGES ARISING OUT OF THIS AGREEMENT, UNDER ANY
+ * CAUSE OF ACTION OR THEORY OF LIABILITY, AND IRRESPECTIVE OF WHETHER INTEL
+ * HAS ADVANCE NOTICE OF THE POSSIBILITY OF SUCH DAMAGES.  THESE LIMITATIONS
+ * SHALL APPLY NOTWITHSTANDING THE FAILURE OF THE ESSENTIAL PURPOSE OF ANY
+ * LIMITED REMEDY.
+ *
+ * 4.3. Licensee shall not export, either directly or indirectly, any of this
+ * software or system incorporating such software without first obtaining any
+ * required license or other approval from the U. S. Department of Commerce or
+ * any other agency or department of the United States Government.  In the
+ * event Licensee exports any such software from the United States or
+ * re-exports any such software from a foreign destination, Licensee shall
+ * ensure that the distribution and export/re-export of the software is in
+ * compliance with all laws, regulations, orders, or other restrictions of the
+ * U.S. Export Administration Regulations. Licensee agrees that neither it nor
+ * any of its subsidiaries will export/re-export any technical data, process,
+ * software, or service, directly or indirectly, to any country for which the
+ * United States government or any agency thereof requires an export license,
+ * other governmental approval, or letter of assurance, without first obtaining
+ * such license, approval or letter.
+ *
+ *****************************************************************************/
+
+
+#ifndef THERMALPAGE_H
+#define THERMALPAGE_H
+
+#include <sys/types.h>
+#include <sys/stat.h>
+#include <sys/wait.h>
+#include <sys/time.h>
+#include <sys/socket.h>
+#include <sys/ioctl.h>
+#include <sys/un.h>  //include for domain type AF_UNIX
+#include <netinet/in.h>  //Used for domain type AF_INET
+#include <arpa/inet.h> 
+#include <stdlib.h>
+#include <errno.h>
+#include <stdio.h>
+#include <string.h>
+#include <fcntl.h>
+#include <unistd.h>
+#include <ctype.h>
+
+#include <qobject.h>
+#include <qwidget.h>
+#include <qcolor.h>
+#include <qabstractlayout.h>
+#include <qlayout.h>
+#include <qlabel.h>
+#include <qstring.h>
+#include <qbutton.h>
+#include <qpushbutton.h>
+#include <qgroupbox.h>
+#include <qrangecontrol.h>
+#include <qslider.h>
+#include <qcombobox.h>
+#include <qpalette.h>
+#include <qmessagebox.h>
+
+#include "power.h"
+
+
+class ThermalPage : public QWidget
+{
+	Q_OBJECT
+
+ public:
+	ThermalPage(QWidget *parent, const char *name=0 );
+	~ThermalPage();
+
+ private:
+	PM_THERMAL_DATA data;
+
+	QComboBox *cbZoneKey;
+	
+	QFont *qfFont;
+	QLabel *qlIntro;
+	QString *qsIntro;
+
+	QLabel *qlZK;
+	QString *qsZK;
+	
+	QLabel *qlCM;
+	QString *qsCM;
+
+	QLabel *qlPF;
+	QString *qsPF;
+
+	QLabel *qlST;
+	QString *qsST;
+
+	QLabel *qlTP;
+	QString *qsTP;
+
+};
+
+#endif
+

RE: Patch for ospmd thermal gui

[Grover, Andrew]

> From: Knut Neumann [mailto:knut.neumann-4bfl1RV3iZDOEhgYWvzSCYQuADTiUCJX@public.gmane.org] 
> as you suggested last year I made the ospmd_gui have a 
> thermal page. Now
> I found the time to clean the patch up and send it to you.

Thanks!

(BTW we are going to switch from the ACPI CA license to the BSD license,
is that OK with you?)

> I always thought to transparently export the acpi interface through
> ospmd/libpower. That is why I made one struct (PM_THERMAL_DATA) per
> zone. Now that seems plain wrong to me.
> 
> As I understand today you want ospmd to gather those 
> information needed
> for power management (policies) from /proc/acpi and export control of
> ospmd via libpower - is that right?

Yes. I'm assuming the user will be using a GUI-specific PM control panel
program, so my thought was that all these would act on the same power
policy by using libpower to talk to ospmd. This makes the interface
libpower exposes VERY IMPORTANT. It should not change once we lock it
down. I think at some point we need to review it (does it have enough
information? Too much?). IIRC we also are using internal data structures
in it, so we will probably want to fix that.

> In conclusion that would rather mean to have access to eg cooling
> mode/temperature (in ospmd _and_ libpower) via:
> 
> pm_set_thermal_cooling
> pm_get_thermal_cooling
> pm_get_thermal_temperature
> 
> to be able to either set cooling mode from the gui directly or have a
> policy in ospmd that eg switches cooling mode to active when a certain
> temperature is reached.

Well, cooling mode is only supposed to be specified by the user, so I
don't think ospmd would change it by itself. However, there is a lot of
room for ospmd to take the user's preference and then do the right thing
based on that. For example, what do we do when the battery gets low? If
the user has said to suspend the system when battery reaches 10%, then
ospmd needs to track that and make it happen at the right time.

Regards -- Andy


-------------------------------------------------------
This SF.net email is sponsored by: ValueWeb: 
Dedicated Hosting for just $79/mo with 500 GB of bandwidth! 
No other company gives more support or power for your dedicated server
http://click.atdmt.com/AFF/go/sdnxxaff00300020aff/direct/01/

RE: Patch for ospmd thermal gui

[Knut Neumann]

Am Mon, 2003-03-31 um 20.36 schrieb Grover, Andrew:
> Thanks!

I should have mentioned that this patch is incremental to the other one
I sent to you, which added autotools support...

> (BTW we are going to switch from the ACPI CA license to the BSD license,
> is that OK with you?)

No problem. 

> Yes. I'm assuming the user will be using a GUI-specific PM control panel
> program, so my thought was that all these would act on the same power
> policy by using libpower to talk to ospmd. This makes the interface
> libpower exposes VERY IMPORTANT. 

Would you have the time to draw up an API for libpower (which maybe
should be named libospmd?!)? This could prevent some misunderstandings -
and I would happily start implementing it....

> Well, cooling mode is only supposed to be specified by the user, so I
> don't think ospmd would change it by itself. 

Hmmm..AFAIU ospmd is supposed to take care of user-specified power
policies, which are set through libpower: so I would think the user
should rather not be able to directly activate active cooling but it
should be done by ospmd in two cases: the user specified active cooling
when temperature reaches a certain point - or some (default) value is
reached which is assumed critical for passive cooling. 

> However, there is a lot of
> room for ospmd to take the user's preference and then do the right thing
> based on that. For example, what do we do when the battery gets low? If
> the user has said to suspend the system when battery reaches 10%, then
> ospmd needs to track that and make it happen at the right time.

Ok. I understand now that I somehow missed the point. It seems to be a
good idea to complete the design of the gui pm control panel or the
libpower API. Would you think you have some time in the near future to
do one of those? Otherwise I could do some work on such a gui program by
taking the small pm-control-applet which was pre-installed on my vaio
under windows and the existing gui as a start...though I would rather
like to do it in gnome/gtk since I am not that familiar with QT. 


-Knut
-- 
Knut Neumann <knut.neumann-4bfl1RV3iZDOEhgYWvzSCYQuADTiUCJX@public.gmane.org>
Physikalische Grundpraktika - Heinrich-Heine Universitaet Duesseldorf
Raum 25.33.01.63  -   Universitaetsstrasse 1   -  D-40225 Duesseldorf
fon: +49-211-81-11314                           fax: +49-211-81-13105











-------------------------------------------------------
This SF.net email is sponsored by: ValueWeb: 
Dedicated Hosting for just $79/mo with 500 GB of bandwidth! 
No other company gives more support or power for your dedicated server
http://click.atdmt.com/AFF/go/sdnxxaff00300020aff/direct/01/

Re: RE: Patch for ospmd thermal gui

[Pavel Machek]

Hi!

> Would you have the time to draw up an API for libpower (which maybe
> should be named libospmd?!)? This could prevent some misunderstandings -
> and I would happily start implementing it....

libpower is *way* nicer name.
-- 
				Pavel
Written on sharp zaurus, because my Velo1 broke. If you have Velo you don't need...



-------------------------------------------------------
This SF.net email is sponsored by: ValueWeb: 
Dedicated Hosting for just $79/mo with 500 GB of bandwidth! 
No other company gives more support or power for your dedicated server
http://click.atdmt.com/AFF/go/sdnxxaff00300020aff/direct/01/