public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
* ACPI patch status (2.6)
@ 2003-09-30  6:18 Len Brown
       [not found] ` <1064902694.2535.159.camel-D2Zvc0uNKG8@public.gmane.org>
  0 siblings, 1 reply; 6+ messages in thread
From: Len Brown @ 2003-09-30  6:18 UTC (permalink / raw)
  To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f

FYI,
The following changes are currently in the ACPI test tree
http://linux-acpi.bkbits.net/linux-acpi-test-2.6.0
available for testing before push to 2.6.0

The associated plain patches are also available here:
ftp.kernel.org:/pub/linux/kernel/people/lenb/acpi/patches/test/

Yes, it has been too long since the last push into 2.6.
The good news is that we'll have finally got 2.6 back in sync with 2.4.

If you seen any regressions, please let me know.

thanks,
-Len

http://ftp.kernel.org/pub/linux/kernel/people/lenb/acpi/patches/README.ACPI

------

ChangeSet-NapXrNxjHSzEb4TTkPOJTA@public.gmane.org, 2003-09-30 01:09:21-04:00, len.brown@intel.com
  [ACPI] GV3 IO port is 16-bits (Venkatesh Pallipadi)

ChangeSet-NapXrNxjHSzoSwJSnaUrKw@public.gmane.org, 2003-09-30 00:53:46-04:00, len.brown@intel.com
  [ACPI] acpi_pci_link_allocate() should stick with irq.active if set.
(Andrew de Quincey)
  Fixes OSDL #1186 "broken USB" and others

ChangeSet-NapXrNxjHSyhc2M4uTCxZA@public.gmane.org, 2003-09-30 00:15:16-04:00, len.brown@intel.com
  [ACPI] add CONFIG_ACPI_RELAXED_AML to config menu

ChangeSet-NapXrNxjHSwp2p4RgGY0lw@public.gmane.org, 2003-09-30 00:06:29-04:00, len.brown@intel.com
  [ACPI] CONFIG_ACPI is no longer necessary to enable HT (from 2.4.23)
  if (CONFIG_ACPI || CONFIG_SMP) CONFIG_ACPI_BOOT=y

ChangeSet-NapXrNxjHSwCFy6MiDM1gQ@public.gmane.org, 2003-09-29 23:13:34-04:00, len.brown@intel.com
  [ACPI] ACPI Component Architecture 20030918 (Bob Moore)

  Found and fixed a longstanding problem with the late execution of
  the various deferred AML opcodes (such as Operation Regions,
  Buffer Fields, Buffers, and Packages)...
  This fixes the "region size computed incorrectly" problem.

  Fixed several 64-bit issues with prototypes, casting and data types.

  Removed duplicate prototype from acdisasm.h

ChangeSet-NapXrNxjHSyNbVT0sNCpDA@public.gmane.org, 2003-09-29 12:32:13-04:00, len.brown@intel.com
  [ACPI] CONFIG_ACPI_RELAXED_AML from 2.4
  http://bugzilla.kernel.org/show_bug.cgi?id=1248

ChangeSet-NapXrNxjHSyWvgyCK5BHAA@public.gmane.org, 2003-09-25 16:17:01-04:00, len.brown@intel.com
  [ACPI] For ThinkPad -- carry on in face of ECDT probe failure (Andi
Kleen)

ChangeSet-NapXrNxjHSz7J4fLV6oaFA@public.gmane.org, 2003-09-23 17:38:00-04:00, len.brown@intel.com
  [ACPI] remove __initdata from acpi_disabled for module use (Andi
Kleen)

ChangeSet-NapXrNxjHSxer9vXpyaIOA@public.gmane.org, 2003-09-19 10:22:14-07:00, len.brown@intel.com
  [ACPI] fix IO-APIC mode SCI storm due to sharing with PCI device
(David Shaohua Li)
  http://bugzilla.kernel.org/show_bug.cgi?id=1165

ChangeSet-NapXrNxjHSzBWNZp46sVrw@public.gmane.org, 2003-09-18 20:14:20-07:00, len.brown@intel.com
  [ACPI] acpi_disabled is used after __initdata is freed.
  fixes random battery module loading problem -- SuSE bug #30477 (Andi
Kleen)

ChangeSet-NapXrNxjHSyRBaQiXl/DHw@public.gmane.org, 2003-09-18 16:40:04-07:00, len.brown@intel.com
  [ACPI] Fix IO-APIC mode SCI interrupt storm on Tyan
  http://bugzilla.kernel.org/show_bug.cgi?id=774

ChangeSet-NapXrNxjHSwkZRhte9MuKA@public.gmane.org, 2003-09-18 16:22:16-07:00, len.brown@intel.com
  [ACPI] avoid alloc_bootmem() for accessing ACPI tables
  some platforms use ACPI tables to find memory (Jesse Barnes)

ChangeSet-NapXrNxjHSx1qXLPWCKRTw@public.gmane.org, 2003-09-18 12:01:37-07:00, len.brown@intel.com
  ACPI_CA_VERSION                 0x20030916

ChangeSet-NapXrNxjHSyamEhOJLDLTw@public.gmane.org, 2003-09-18 11:59:12-07:00, len.brown@intel.com
  remove ASUS A7V BIOS version 1011 from blacklist (Eric Valette)

ChangeSet-NapXrNxjHSyxd20e5Us4rQ@public.gmane.org, 2003-09-18 11:41:51-07:00, len.brown@intel.com
  IBM ThinkPAD T30/T40 oops (David Shaohua Li)
  https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=98849

ChangeSet-NapXrNxjHSzIn+4bvDfk6g@public.gmane.org, 2003-09-18 11:29:42-07:00, len.brown@intel.com
  Extended IRQ resource type for nForce (Andrew de Quincey)

ChangeSet-NapXrNxjHSwbpGf+3Q3hGA@public.gmane.org, 2003-09-18 10:58:41-07:00, len.brown@intel.com
  [ACPI] Handle systems that specify non-ACPI-compliant SCI over-rides
(Jun Nakajima)

ChangeSet-NapXrNxjHSzxhsza/HYD6Q@public.gmane.org, 2003-09-18 10:54:11-07:00, len.brown@intel.com
  Handle BIOS with _CRS that fails (Jun Nakajima)

ChangeSet-NapXrNxjHSxtCJruIQNo1w@public.gmane.org, 2003-09-18 00:52:06-04:00, len.brown@intel.com
  [ACPI] merge 2.4.22 cleanup into 2.6
  Restores CONFIG_ACPI_HT_ONLY as an alternative to CONFIG_ACPI
  rather than a prerequisite

ChangeSet-1Cvhk1ijdKctxE93JcnU2Q@public.gmane.org, 2003-09-15 00:34:00-04:00, len.brown@intel.com
  sync 2.4.22 changes into 2.6
  Note that this restores CONFIG_ACPI_HT_ONLY as a sub-set of
CONFIG_ACPI rather than a dependency.





-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: ACPI patch status (2.6)
       [not found] ` <1064902694.2535.159.camel-D2Zvc0uNKG8@public.gmane.org>
@ 2003-09-30  6:53   ` Nate Lawson
       [not found]     ` <20030929235203.O79536-Y6VGUYTwhu0@public.gmane.org>
  2003-09-30  7:07   ` Andi Kleen
  1 sibling, 1 reply; 6+ messages in thread
From: Nate Lawson @ 2003-09-30  6:53 UTC (permalink / raw)
  To: Len Brown; +Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f

Thanks.  I don't see the patch I submitted (buffer overflow in resource
lists) below.  Is there a good facility where you track patches that I
should submit them instead?

-Nate

On Mon, 30 Sep 2003, Len Brown wrote:
> FYI,
> The following changes are currently in the ACPI test tree
> http://linux-acpi.bkbits.net/linux-acpi-test-2.6.0
> available for testing before push to 2.6.0
>
> The associated plain patches are also available here:
> ftp.kernel.org:/pub/linux/kernel/people/lenb/acpi/patches/test/
>
> Yes, it has been too long since the last push into 2.6.
> The good news is that we'll have finally got 2.6 back in sync with 2.4.
>
> If you seen any regressions, please let me know.
>
> thanks,
> -Len
>
> http://ftp.kernel.org/pub/linux/kernel/people/lenb/acpi/patches/README.ACPI
>
> ------
>
> ChangeSet-NapXrNxjHSzEb4TTkPOJTA@public.gmane.org, 2003-09-30 01:09:21-04:00, len.brown@intel.com
>   [ACPI] GV3 IO port is 16-bits (Venkatesh Pallipadi)
>
> ChangeSet-NapXrNxjHSzoSwJSnaUrKw@public.gmane.org, 2003-09-30 00:53:46-04:00, len.brown@intel.com
>   [ACPI] acpi_pci_link_allocate() should stick with irq.active if set.
> (Andrew de Quincey)
>   Fixes OSDL #1186 "broken USB" and others
>
> ChangeSet-NapXrNxjHSyhc2M4uTCxZA@public.gmane.org, 2003-09-30 00:15:16-04:00, len.brown@intel.com
>   [ACPI] add CONFIG_ACPI_RELAXED_AML to config menu
>
> ChangeSet-NapXrNxjHSwp2p4RgGY0lw@public.gmane.org, 2003-09-30 00:06:29-04:00, len.brown@intel.com
>   [ACPI] CONFIG_ACPI is no longer necessary to enable HT (from 2.4.23)
>   if (CONFIG_ACPI || CONFIG_SMP) CONFIG_ACPI_BOOT=y
>
> ChangeSet-NapXrNxjHSwCFy6MiDM1gQ@public.gmane.org, 2003-09-29 23:13:34-04:00, len.brown@intel.com
>   [ACPI] ACPI Component Architecture 20030918 (Bob Moore)
>
>   Found and fixed a longstanding problem with the late execution of
>   the various deferred AML opcodes (such as Operation Regions,
>   Buffer Fields, Buffers, and Packages)...
>   This fixes the "region size computed incorrectly" problem.
>
>   Fixed several 64-bit issues with prototypes, casting and data types.
>
>   Removed duplicate prototype from acdisasm.h
>
> ChangeSet-NapXrNxjHSyNbVT0sNCpDA@public.gmane.org, 2003-09-29 12:32:13-04:00, len.brown@intel.com
>   [ACPI] CONFIG_ACPI_RELAXED_AML from 2.4
>   http://bugzilla.kernel.org/show_bug.cgi?id=1248
>
> ChangeSet-NapXrNxjHSyWvgyCK5BHAA@public.gmane.org, 2003-09-25 16:17:01-04:00, len.brown@intel.com
>   [ACPI] For ThinkPad -- carry on in face of ECDT probe failure (Andi
> Kleen)
>
> ChangeSet-NapXrNxjHSz7J4fLV6oaFA@public.gmane.org, 2003-09-23 17:38:00-04:00, len.brown@intel.com
>   [ACPI] remove __initdata from acpi_disabled for module use (Andi
> Kleen)
>
> ChangeSet-NapXrNxjHSxer9vXpyaIOA@public.gmane.org, 2003-09-19 10:22:14-07:00, len.brown@intel.com
>   [ACPI] fix IO-APIC mode SCI storm due to sharing with PCI device
> (David Shaohua Li)
>   http://bugzilla.kernel.org/show_bug.cgi?id=1165
>
> ChangeSet-NapXrNxjHSzBWNZp46sVrw@public.gmane.org, 2003-09-18 20:14:20-07:00, len.brown@intel.com
>   [ACPI] acpi_disabled is used after __initdata is freed.
>   fixes random battery module loading problem -- SuSE bug #30477 (Andi
> Kleen)
>
> ChangeSet-NapXrNxjHSyRBaQiXl/DHw@public.gmane.org, 2003-09-18 16:40:04-07:00, len.brown@intel.com
>   [ACPI] Fix IO-APIC mode SCI interrupt storm on Tyan
>   http://bugzilla.kernel.org/show_bug.cgi?id=774
>
> ChangeSet-NapXrNxjHSwkZRhte9MuKA@public.gmane.org, 2003-09-18 16:22:16-07:00, len.brown@intel.com
>   [ACPI] avoid alloc_bootmem() for accessing ACPI tables
>   some platforms use ACPI tables to find memory (Jesse Barnes)
>
> ChangeSet-NapXrNxjHSx1qXLPWCKRTw@public.gmane.org, 2003-09-18 12:01:37-07:00, len.brown@intel.com
>   ACPI_CA_VERSION                 0x20030916
>
> ChangeSet-NapXrNxjHSyamEhOJLDLTw@public.gmane.org, 2003-09-18 11:59:12-07:00, len.brown@intel.com
>   remove ASUS A7V BIOS version 1011 from blacklist (Eric Valette)
>
> ChangeSet-NapXrNxjHSyxd20e5Us4rQ@public.gmane.org, 2003-09-18 11:41:51-07:00, len.brown@intel.com
>   IBM ThinkPAD T30/T40 oops (David Shaohua Li)
>   https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=98849
>
> ChangeSet-NapXrNxjHSzIn+4bvDfk6g@public.gmane.org, 2003-09-18 11:29:42-07:00, len.brown@intel.com
>   Extended IRQ resource type for nForce (Andrew de Quincey)
>
> ChangeSet-NapXrNxjHSwbpGf+3Q3hGA@public.gmane.org, 2003-09-18 10:58:41-07:00, len.brown@intel.com
>   [ACPI] Handle systems that specify non-ACPI-compliant SCI over-rides
> (Jun Nakajima)
>
> ChangeSet-NapXrNxjHSzxhsza/HYD6Q@public.gmane.org, 2003-09-18 10:54:11-07:00, len.brown@intel.com
>   Handle BIOS with _CRS that fails (Jun Nakajima)
>
> ChangeSet-NapXrNxjHSxtCJruIQNo1w@public.gmane.org, 2003-09-18 00:52:06-04:00, len.brown@intel.com
>   [ACPI] merge 2.4.22 cleanup into 2.6
>   Restores CONFIG_ACPI_HT_ONLY as an alternative to CONFIG_ACPI
>   rather than a prerequisite
>
> ChangeSet-1Cvhk1ijdKctxE93JcnU2Q@public.gmane.org, 2003-09-15 00:34:00-04:00, len.brown@intel.com
>   sync 2.4.22 changes into 2.6
>   Note that this restores CONFIG_ACPI_HT_ONLY as a sub-set of
> CONFIG_ACPI rather than a dependency.
>
>
>
>
>
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Welcome to geek heaven.
> http://thinkgeek.com/sf
> _______________________________________________
> Acpi-devel mailing list
> Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/acpi-devel
>


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: ACPI patch status (2.6)
       [not found] ` <1064902694.2535.159.camel-D2Zvc0uNKG8@public.gmane.org>
  2003-09-30  6:53   ` Nate Lawson
@ 2003-09-30  7:07   ` Andi Kleen
       [not found]     ` <20030930070706.GB8827-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
  1 sibling, 1 reply; 6+ messages in thread
From: Andi Kleen @ 2003-09-30  7:07 UTC (permalink / raw)
  To: Len Brown; +Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f

On Tue, Sep 30, 2003 at 02:18:14AM -0400, Brown, Len wrote:
> FYI,
> The following changes are currently in the ACPI test tree
> http://linux-acpi.bkbits.net/linux-acpi-test-2.6.0
> available for testing before push to 2.6.0
> 
> The associated plain patches are also available here:
> ftp.kernel.org:/pub/linux/kernel/people/lenb/acpi/patches/test/
> 
> Yes, it has been too long since the last push into 2.6.
> The good news is that we'll have finally got 2.6 back in sync with 2.4.
> 
> If you seen any regressions, please let me know.

My ACPI tolerant patch is not included. Without this it will not boot
on many HP servers and some other multiprocessor boxes.

-Andi


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: ACPI patch status (2.6)
       [not found]     ` <20030929235203.O79536-Y6VGUYTwhu0@public.gmane.org>
@ 2003-09-30 17:07       ` Len Brown
  0 siblings, 0 replies; 6+ messages in thread
From: Len Brown @ 2003-09-30 17:07 UTC (permalink / raw)
  To: Nate Lawson; +Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f

> Is there a good facility where you track patches that I
> should submit them instead?

Always learning, but the best process I know goes something like below.
In summary, the mailing list is great, but if you want to be sure an
issue and its fix get properly handled and don't fall through the
cracks, then bugzilla is your friend.

thanks,
-Len


1. issue discovered

2. Check to see if somebody else already discoverd it

	Query bugzilla -- http://bugzilla.kernel.org/
	and/or at the distro bugzilla.

	google for it
	poke around the list archives
	http://sourceforge.net/mailarchive/forum.php?forum=acpi-devel
	http://sourceforge.net/mailarchive/forum.php?forum=acpi-support

3. If no, ask others if they see the same problem or have a fix
	acpi-support-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
	acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org

4. If no, file a new bug
	http://bugzilla.kernel.org/ for base 2.4 or 2.6 kernels
		Category: Power Management
		Component: ACPI
	http://bugzilla.redhat.com/ for RHEL, Fedora etc.
	http://bugzilla.suse.de for SuSE
	etc.

	Put useful stuff in the bug report.  Eg. for interrupt issues:

	Please attach the output from dmidecode, available in
	/usr/sbin/, or here: http://www.nongnu.org/dmidecode/

	Please attach the output from acpidmp, available in /usr/sbin/,
	or in here
	http://www.intel.com/technology/iapc/acpi/downloads/pmtools-20010730.tar.gz
	Please attach /proc/interrupts and the dmesg output
	showing the failure, if possible.

5. Debug
	As bug is debugged, attach the useful stuff to the bug report --
	don't just send it to the mailing list or it may get lost.

	Attach proposed patches in bugzilla.
	Submitter tests proposed patch and verifies it works.
	bugzilla should be set to RESOLVED w/ CODE_FIX at this point.

6. Get it integrated
	If I haven't noticed the bugzilla and picked up the fix
	already, send me a pointer to it and 
	cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
	to make sure others get the opportunity to be aware of
	the proposed change.

7. Receive notice it is integrated.
	When I pull in a patch, I'll reply to the contributor
	and will cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
	I'll cc LKML too if that is where it came from
	so the ACK is included in the thread.
	

8. Test the fix along with the others.
	Your pristine fix may have been toasted along the way.
	Update from the latest BK tree
	http://linux-acpi.bkbits.net/linux-acpi-test-2.4.22
	http://linux-acpi.bkbits.net/linux-acpi-test-2.4.23
	http://linux-acpi.bkbits.net/linux-acpi-test-2.6.0

	Or apply the plain patches from here:
	ftp://ftp.kernel.org/pub/linux/kernel/people/lenb/acpi/patches/test

	(See README here:
	ftp://ftp.kernel.org/pub/linux/kernel/people/lenb/acpi/patches/README.ACPI

	And let me know if it got broke.

9. ACPI test tree periodicaly gets released to baseline kernel
	When the fix is in the base kernel,
	bugzilla should be marked CLOSED.





-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

^ permalink raw reply	[flat|nested] 6+ messages in thread

* acpi_tolerant (Re: ACPI patch status (2.6))
       [not found]     ` <20030930070706.GB8827-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
@ 2003-09-30 17:45       ` Len Brown
       [not found]         ` <1064943934.2583.100.camel-D2Zvc0uNKG8@public.gmane.org>
  0 siblings, 1 reply; 6+ messages in thread
From: Len Brown @ 2003-09-30 17:45 UTC (permalink / raw)
  To: Andi Kleen, Andrew de Quincey; +Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f

> > If you seen any regressions, please let me know.
> 
> My ACPI tolerant patch is not included. Without this it will not boot
> on many HP servers and some other multiprocessor boxes.

Thanks Andi,
I've included your "PIC fallback and SMP boxes" note below to give
others background if they haven't seen it yet.

My  understanding was that the acpi_tolerant patch is in response to
Andrew de Quincy's "Full dropback to PIC mode" patch -- the one that
creates pic.c.  That change is in the mm tree, but not yet in 2.4, 2.6,
or the acpi 2.4 or 2.6 trees.

If I'm confused and you believe that the acpi_tolerant patch is needed
for the current acpi tree to boot on some SMP servers, please straighten
me out.

thanks,
-Len

------------

Hi,

We had good success with Andrew's PIC fallback patches on SuSE Linux.
A lot of boxes that needed pci=noacpi or acpi=off before work now.

Unfortunately there were also some regressions, mostly on bigger SMP 
boxes (e.g. some HP servers). What usually happened was that some
unimportant device like one USB port would fail to set or get an
interrupt.

That would cause a full PIC mode fallback, which is not a good idea
on a SMP system and usually results in a failed boot.

People didn't notice the not working USB port before (or maybe it 
worked anyways).

I did a bit of an hack to work around this now. On a SMP system PIC 
mode fallback is probably not a good idea because it will perform awful
and more likely not work at all. This patch checks
if the box is a "true" SMP system (not just an uniprocessor box
with huperthreading), and if yes enables tolerant mode. Tolerant
mode means we don't do PIC fallback for failing to set an ACPI link.

This could be more improved, e.g. acpi_pci_get_prt_list should
probably also tolerate partial failure.

Another bigger problem we have with the PIC fallback is that there
are a some chipsets that don't like it when you first set a few
interrupts in APIC mode and then go back to PIC mode (e.g. 
that's the case on all NForce3 and some VIA boards). I'm not sure what 
to do with them yet. For our use for x86-64 I added an hack to always
force
PIC mode for Nvidia and VIA, but that's clearly an hack.

The patch is for a SuSE tree, will probably not apply directly to plain
2.4.

-Andi


diff -u linux-2.4.21/arch/i386/kernel/mpparse.c-o
linux-2.4.21/arch/i386/kernel/mpparse.c
--- linux-2.4.21/arch/i386/kernel/mpparse.c-o   2003-09-22
12:48:56.000000000 +0200
+++ linux-2.4.21/arch/i386/kernel/mpparse.c     2003-09-22
13:27:34.000000000 +0200
@@ -1293,6 +1293,8 @@
 
 #ifdef CONFIG_ACPI_PCI
 
+extern int acpi_tolerant;
+
 int __init mp_parse_prt (void)
 {
        struct list_head        *node = NULL;
@@ -1305,6 +1307,13 @@
        int                     edge_level = 0;
        int                     active_high_low = 0;
 
+#ifdef CONFIG_SMP
+       /* Hack: on "real" (not just HT) SMP boxes we do not fall back 
+          to PIC mode easily. Ignore interrupt setup failures then. */
+       if (acpi_tolerant != 2 && smp_num_cpus/smp_num_siblings > 1) 
+               acpi_tolerant = 1;
+#endif 
+
        /* Get the current PRT */
        prt_list = acpi_pci_get_prt_list();
    
@@ -1326,6 +1335,14 @@
                if (entry->link.handle) {
                        irq = acpi_pci_link_get_irq(entry->link.handle,
entry->link.index, &edge_level, &active_high_low);
                        if (irq < 0) {
+                               if (acpi_tolerant) { 
+                                       printk(KERN_INFO "Ignoring
failure to set interrupt for device %02x:%02x:%02x on pin %d (oldirq
%d)\n", 
+                                              entry->id.bus,
entry->id.device,
+                                              entry->id.function,
entry->pin,
+                                              entry->irq); 
+                               
+                                       continue; 
+                               }
                                acpi_pci_destroy_prt_list(prt_list);
                                return -ENODEV;
                        }
diff -u linux-2.4.21/arch/i386/kernel/setup.c-o
linux-2.4.21/arch/i386/kernel/setup.c
--- linux-2.4.21/arch/i386/kernel/setup.c-o     2003-09-22
12:48:58.000000000 +0200
+++ linux-2.4.21/arch/i386/kernel/setup.c       2003-09-22
13:27:37.000000000 +0200
@@ -202,6 +202,8 @@
 
 int acpi_tables __initdata = 0; 
 
+int acpi_tolerant; 
+
 extern int blk_nohighio;
 
 #ifndef CONFIG_SMP
@@ -897,6 +899,9 @@
                     acpi_force = 1;
                } 
 
+               else if (!memcmp(from, "acpi=tolerant", 13)) 
+                    acpi_tolerant = 2; 
+
                 /* disable IO-APIC */
                 else if (!memcmp(from, "noapic", 6))
                         disable_ioapic_setup();



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: acpi_tolerant (Re: ACPI patch status (2.6))
       [not found]         ` <1064943934.2583.100.camel-D2Zvc0uNKG8@public.gmane.org>
@ 2003-09-30 18:11           ` Andi Kleen
  0 siblings, 0 replies; 6+ messages in thread
From: Andi Kleen @ 2003-09-30 18:11 UTC (permalink / raw)
  To: Len Brown
  Cc: Andi Kleen, Andrew de Quincey,
	acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f

On Tue, Sep 30, 2003 at 01:45:34PM -0400, Brown, Len wrote:
> > > If you seen any regressions, please let me know.
> > 
> > My ACPI tolerant patch is not included. Without this it will not boot
> > on many HP servers and some other multiprocessor boxes.
> 
> Thanks Andi,
> I've included your "PIC fallback and SMP boxes" note below to give
> others background if they haven't seen it yet.
> 
> My  understanding was that the acpi_tolerant patch is in response to
> Andrew de Quincy's "Full dropback to PIC mode" patch -- the one that
> creates pic.c.  That change is in the mm tree, but not yet in 2.4, 2.6,
> or the acpi 2.4 or 2.6 trees.

Yep. But that tree needs acpi-tolerant too


> If I'm confused and you believe that the acpi_tolerant patch is needed
> for the current acpi tree to boot on some SMP servers, please straighten
> me out.

No, you're right. It only makes sense with PIC fallback. But PIC 
fallback is included in your test tree, right? If yes then you
should merge acpi-tolerant too.

BTW IMHO you should merge both (PIC mode and the other fixes including
acpi-tolerant) ASAP to mainline. There are tons of ACPI bug reports for 
2.6 all the time that would be fixed by them. It would be much better to
test there than in some test tree that nobody uses anyways. That would
also give the patches a much better test.

-Andi


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2003-09-30 18:11 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-09-30  6:18 ACPI patch status (2.6) Len Brown
     [not found] ` <1064902694.2535.159.camel-D2Zvc0uNKG8@public.gmane.org>
2003-09-30  6:53   ` Nate Lawson
     [not found]     ` <20030929235203.O79536-Y6VGUYTwhu0@public.gmane.org>
2003-09-30 17:07       ` Len Brown
2003-09-30  7:07   ` Andi Kleen
     [not found]     ` <20030930070706.GB8827-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
2003-09-30 17:45       ` acpi_tolerant (Re: ACPI patch status (2.6)) Len Brown
     [not found]         ` <1064943934.2583.100.camel-D2Zvc0uNKG8@public.gmane.org>
2003-09-30 18:11           ` Andi Kleen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox