public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Sarjeant <greg-QNIYhHqVzB9kr2E5YSwMOQ@public.gmane.org>
To: "Grover, Andrew" <andrew.grover-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Nate Lawson <nate-Y6VGUYTwhu0@public.gmane.org>,
	acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: RE: Gateway 200X (again) - No power button events
Date: Tue, 20 Jan 2004 19:07:32 -0500	[thread overview]
Message-ID: <1074643651.5488.14.camel@localhost> (raw)
In-Reply-To: <F760B14C9561B941B89469F59BA3A8470255EFE4-sBd4vmA9Se4Lll3ZsUKC9FDQ4js95KgL@public.gmane.org>

On Tue, 2004-01-20 at 18:27, Grover, Andrew wrote:
> That is correct. So, the code ignores a CM power button if a FF button
> is found. There is a bit in the FADT that declares if the power button
> is fixed or control-method.
> 
> PWR_BUTTON A zero indicates the power button is handled as a fixed
> feature programming model; a one indicates the power
> button is handled as a control method device. If the system
> does not have a power button, this value would be "1" and
> no sleep button device would be present.
> 
> (I think that "sleep" should be "power" but anyways...)
> 
> So the FF pwr button gets priority. You can comment out a few lines in
> scan.c acpi_bus_scan_fixed(), and it should not register the FF power
> button. That might be interesting to try.
> 
> Regards -- Andy

Aha! That did the trick.

I commented out these three lines:

	if (acpi_fadt.pwr_button == 0)
		result = acpi_bus_add(&device, acpi_root, 
			NULL, ACPI_BUS_TYPE_POWER_BUTTON);


And now dmesg reports:

ACPI: Processor [CPU0] (supports C1 C2 C3, 8 throttling states)
ACPI: Lid Switch [LID0]
ACPI: Sleep Button (CM) [SLPB]
ACPI: Power Button (CM) [PWRB]
ACPI: AC Adapter [ADP1] (on-line)
ACPI: Battery Slot [BAT1] (battery present)
[ACPI Debug] String: Not Support
ACPI: Thermal Zone [THRM] (50 C)
ACPI: Fan [FAN0] (on)

So, it is picking up the Control Method Power Button, and I get events
from it now. Outstanding.

When I was googling around, I saw a lot of references to a patch for 2.4
that ignores Fixed Feature buttons when Control Method buttons are
found. For example:

http://www.funet.fi/pub/Linux/PEOPLE/Linus/v2.4/patch-html/patch-2.4.14/linux_drivers_acpi_ospm_button_bn_osl.c.html

Hm - now that I look at it again, the author name is familiar :)

Is this something that might find its way into the main kernel tree?
Should I submit a bug for this behavior?

Thanks for the suggestion!
Greg



-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn

  parent reply	other threads:[~2004-01-21  0:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-20 23:27 Gateway 200X (again) - No power button events Grover, Andrew
     [not found] ` <F760B14C9561B941B89469F59BA3A8470255EFE4-sBd4vmA9Se4Lll3ZsUKC9FDQ4js95KgL@public.gmane.org>
2004-01-21  0:07   ` Greg Sarjeant [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-01-21  0:23 Grover, Andrew
     [not found] ` <F760B14C9561B941B89469F59BA3A84702C9323C-sBd4vmA9Se4Lll3ZsUKC9FDQ4js95KgL@public.gmane.org>
2004-01-24 19:58   ` Greg Sarjeant
2004-01-20 20:15 Grover, Andrew
     [not found] ` <F760B14C9561B941B89469F59BA3A84702C93238-sBd4vmA9Se4Lll3ZsUKC9FDQ4js95KgL@public.gmane.org>
2004-01-20 20:17   ` Nate Lawson
2004-01-20 20:28   ` Greg Sarjeant
     [not found]     ` <1074630523.3313.17.camel-bi+AKbBUZKZeoWH0uzbU5w@public.gmane.org>
2004-01-20 21:17       ` Greg Sarjeant
     [not found]         ` <1074633425.3317.20.camel-bi+AKbBUZKZeoWH0uzbU5w@public.gmane.org>
2004-01-21 10:23           ` Ducrot Bruno
     [not found]             ` <20040121102356.GU25416-kk6yZipjEM5g9hUCZPvPmw@public.gmane.org>
2004-01-21 15:25               ` Greg Sarjeant
2004-01-19 17:34 Greg Sarjeant
     [not found] ` <1074533658.11008.18.camel-bi+AKbBUZKZeoWH0uzbU5w@public.gmane.org>
2004-01-19 19:51   ` Greg Sarjeant
     [not found]     ` <1074541900.2813.5.camel-bi+AKbBUZKZeoWH0uzbU5w@public.gmane.org>
2004-01-20 15:57       ` Greg Sarjeant
2004-01-20 20:03       ` Nate Lawson
     [not found]         ` <20040120120211.U96919-Y6VGUYTwhu0@public.gmane.org>
2004-01-21 10:11           ` Ducrot Bruno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1074643651.5488.14.camel@localhost \
    --to=greg-qniyhhqvzb9kr2e5yswmoq@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=andrew.grover-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=nate-Y6VGUYTwhu0@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox