Re: [RFC] ACPI power-off on P4 HT

[Stian Jordet <liste-NI9zH3lwcMKHXe+LvDLADg@public.gmane.org>]

tor, 26.02.2004 kl. 14.07 skrev Willy Tarreau:
> On Thu, Feb 26, 2004 at 01:28:49PM +0100, Stian Jordet wrote:
> > Hi Willy,
> > 
> > Do you have a similar patch for 2.6?
> 
> No, but since Marcelo recently told me that acpi_power_off() was the same in
> 2.4 and 2.6, I think it should apply without much difficulties. A dirty gpm
> cut-n-paste in vi should be enough ;-)

Well, I cut-n-paste it into drivers/acpi/sleep/poweroff.c (which must
have been the place it fits in 2.6). Get this compile failures:

drivers/acpi/sleep/poweroff.c: In function `acpi_power_off':
drivers/acpi/sleep/poweroff.c:30: warning: implicit declaration of
function `apicid_to_phys_cpu_present'
drivers/acpi/sleep/poweroff.c:30: error: invalid operands to binary &
drivers/acpi/sleep/poweroff.c:69: warning: implicit declaration of
function `disable_IO_APIC'
make[3]: *** [drivers/acpi/sleep/poweroff.o] Error 1
make[2]: *** [drivers/acpi/sleep] Error 2
make[1]: *** [drivers/acpi] Error 2
make: *** [drivers] Error 2

But I'm sure a patch like yours for 2.6 would have fixed my, since using
a non-smp kernel works everytime :) Anyway, thanks for your efforts,
hope someone will get this fixed soon :)

Best regards,
Stian



-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click