Re: Re: fix ACPI poweroff in 2.4.25-rc2

[Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]

Willy,
Zwane was right, set_cpus_allowed() fixes the SMP poweroff problem.  The
patch is here:

http://bugzilla.kernel.org/show_bug.cgi?id=1141

thanks,
-Len

On Wed, 2004-03-03 at 15:20, Willy Tarreau wrote:
> Hi,
> 
> On Wed, Mar 03, 2004 at 07:46:56PM +0000, Matthew Wilcox wrote:
> > On Wed, Mar 03, 2004 at 11:17:25AM -0700, Bjorn Helgaas wrote:
> > > ===== drivers/acpi/system.c 1.18 vs edited =====
> > > --- 1.18/drivers/acpi/system.c	Tue Mar  2 14:50:40 2004
> > > +++ edited/drivers/acpi/system.c	Wed Mar  3 10:43:11 2004
> > > @@ -95,7 +95,9 @@
> > >  {
> > >  	if (unlikely(in_interrupt())) 
> > >  		BUG();
> > > +#ifdef CONFIG_ACPI_SLEEP
> > >  	acpi_system_save_state(ACPI_STATE_S5);
> > > +#endif
> > 
> > Should we not rather define a null acpi_system_save_state() function if
> > CONFIG_ACPI_SLEEP is not set?
> 
> well, since I know of at least one machine on which this patch is not
> enough, and since Pavel says that it might cause reboots on some systems,
> I think that this line has a few chances to stay here anyway. I wish I had
> some time to propose a cleaner version of the patch I sent last week.
> Zwane proposed to try with set_cpus_allowed(). I don't know if this could work
> here, because I don't know how to use it. Perhaps something like
>   set_cpus_allowed(boot_cpu) ; schedule() ?
> 
> Regards,
> Willy
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: IBM Linux Tutorials
> Free Linux tutorial presented by Daniel Robbins, President and CEO of
> GenToo technologies. Learn everything from fundamentals to system
> administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
> _______________________________________________
> Acpi-devel mailing list
> Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/acpi-devel



-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click