Re: stack overflow

[Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]

On Wed, 2004-03-10 at 08:32, Andi Kleen wrote:

> If you have some recursion either fix it or at least add an error
> out when the stack gets too low. We can add an "stack_left" function
> exported by the architecture.

I think we'll want to put some fun-time sanity checks for illegal
recursion into the interpreter.  That should be less invasive than doing
the full blown stack check -- which can be enabled as a separate DEBUG
test when needed.

> > Sorting the list of stack frame sizes below shows
> > acpi_evaluate_integer() is the winner with 320 bytes on the stack.  Note
> > that this isn't from passing structures, but from allocating local
> > structures.  On i386 acpi_parse_object is 124 bytes, on x86_64 it will
> > be bigger...
> 
> I would suggest to fix anything > 100 bytes at least 
> (and double check anything that could be expanded on 64bit) 

Agreed, Bob and I will fix the big stack users.

thanks,
-Len




-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click