Re: [PATCH] ACPI poweroff fixes for 2.4.26-pre2

["Sérgio Monteiro Basto" <sergiomb-hHo3WeeoaswVhHzd4jOs4w@public.gmane.org>]

so acpi_system_save_state(state) does do nothing at all ?
or does return nothing at all ?

On Thu, 2004-03-25 at 22:29, Pavel Machek wrote:
> On Čt 25-03-04 22:22:07, Sérgio Monteiro Basto wrote:
> > hi(gh)!
> > On Mon, 2004-03-22 at 10:59, Pavel Machek wrote:
> > > Hi!
> > > 
> > > > > and status = acacpi_system_save_state()pi_system_save_state(state); 
> > > > > on line 341 of drivers/acpi/system.c ?
> > > > 
> > > > OK sorry, I didn't notice it. So you'll simply have to remove the
> > > > first hunk of the patch so that acpi_system_save_state() stays defined
> > > > at least when CONFIG_ACPI_SLEEP is defined.
> > > 
> > > In such case... at least insert BUG() into fake acpi_system_save_state method.
> > 
> > Well you say that is a bug and I ask how do you translate 
> > status = acpi_system_save_state(state); if not I think that will be
> > inefficient. 
> 
> ? Sorry, parse error on my part.
> 
> *If* you replace acpi_system_save_state() with stub that does nothing
> based on config option *and* someone tries to use it, they are not
> getting the functionality they want, right? And therefore calling it
> is a BUG().
> 								Pavel
-- 
Sérgio M. B.



-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&op=click