From mboxrd@z Thu Jan 1 00:00:00 1970 From: Len Brown Subject: Re: Fixing broken DSDT - code suggestions for comment please! Date: 17 May 2004 15:35:59 -0400 Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Message-ID: <1084822558.12353.365.camel@dhcppc4> References: <40A73460.2070407@mesias.co.uk> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <40A73460.2070407-Nk/s8sJ9yP7QXOPxS62xeg@public.gmane.org> Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Cam Cc: ACPI Developers List-Id: linux-acpi@vger.kernel.org Please verify that you still have this problem when running the latest iasl: http://www.intel.com/technology/IAPC/acpi/downloads.htm On Sun, 2004-05-16 at 05:29, Cam wrote: > Hi ACPI list, > > I have been trying to get ACPI running on my laptop but have found there > are problems with the DSDT. I have followed some instructions on getting > iasl and recompiling the DSDT but find some errors that go beyond the > scope of the list at: > > http://www.cpqlinux.com/acpi-howto.html#fix_broken_dsdt > > The errors are: > > > dsdt.dsl 2149: Store (Local0, Local0) > Error 1013 - ^ Method local variable > is not initialized (Local0) > > This occurs several times in the code, a typical case is: > > Method (_PS0, 0, NotSerialized) > { > Store (And (0xF0, TIA4), TIA4) > Store (0x01, _PSC) > Store (Local0, Local0) > } > > I'm guessing that is effectively a NOP so I can comment it out. > > Later there are two other errors not mentioned in the FAQ: > > dsdt.dsl 2390: Return (WQS (0x0E, Arg0)) > Error 1029 - ^ Called method returns no > value > > > dsdt.dsl 2395: Return (WQSB (0x0E, Arg0)) > Error 1029 - Called method returns no value ^ > > > > The offending code is: > > Method (WENR, 1, NotSerialized) > { > Return (WQS (0x0E, Arg0)) > } > > Method (WETR, 1, NotSerialized) > { > Return (WQSB (0x0E, Arg0)) > } > > All the calls to those methods seem to discard any return value, eg: > > If (\_SB.OKEC) > { > \_SB.PCI0.QSB.WENR (0x01F0) > } > > I couldn't find a reference to WETR > > > > So I thought to not return anything: > > Method (WENR, 1, NotSerialized) > { > /* Return (WQS (0x0E, Arg0))*/ > WQS (0x0E, Arg0) > } > > Method (WETR, 1, NotSerialized) > { > /* Return (WQSB (0x0E, Arg0))*/ > WQSB (0x0E, Arg0) > } > no. the problem is that WQS and WQSB need to have Return() statements. > I am more than a bit wary about trying this for real so would appreciate > any comments on the dsdt code above. If the fixes are good then maybe > they could be incorporated into the FAQ? > > Any comments gratefully received, > > -Cam > > > ------------------------------------------------------- > This SF.Net email is sponsored by: SourceForge.net Broadband > Sign-up now for SourceForge Broadband and get the fastest > 6.0/768 connection for only $19.95/mo for the first 3 months! > http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click > _______________________________________________ > Acpi-devel mailing list > Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org > https://lists.sourceforge.net/lists/listinfo/acpi-devel ------------------------------------------------------- This SF.Net email is sponsored by: SourceForge.net Broadband Sign-up now for SourceForge Broadband and get the fastest 6.0/768 connection for only $19.95/mo for the first 3 months! http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click