public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
* Fixing broken DSDT - code suggestions for comment please!
@ 2004-05-16  9:29 Cam
       [not found] ` <40A73460.2070407-Nk/s8sJ9yP7QXOPxS62xeg@public.gmane.org>
  0 siblings, 1 reply; 16+ messages in thread
From: Cam @ 2004-05-16  9:29 UTC (permalink / raw)
  To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f

Hi ACPI list,

I have been trying to get ACPI running on my laptop but have found there 
are problems with the DSDT. I have followed some instructions on getting 
iasl and recompiling the DSDT but find some errors that go beyond the 
scope of the list at:

http://www.cpqlinux.com/acpi-howto.html#fix_broken_dsdt

The errors are:


dsdt.dsl  2149:                     Store (Local0, Local0)
Error    1013 -                                 ^ Method local variable 
is not initialized (Local0)

This occurs several times in the code, a typical case is:

                 Method (_PS0, 0, NotSerialized)
                 {
                     Store (And (0xF0, TIA4), TIA4)
                     Store (0x01, _PSC)
                     Store (Local0, Local0)
                 }

I'm guessing that is effectively a NOP so I can comment it out.

Later there are two other errors not mentioned in the FAQ:

dsdt.dsl  2390:                     Return (WQS (0x0E, Arg0))
Error    1029 -                               ^ Called method returns no 
value
 

dsdt.dsl  2395:                     Return (WQSB (0x0E, Arg0))
Error    1029 - Called method returns no value ^
 


The offending code is:

                 Method (WENR, 1, NotSerialized)
                 {
                     Return (WQS (0x0E, Arg0))
                 }

                 Method (WETR, 1, NotSerialized)
                 {
                     Return (WQSB (0x0E, Arg0))
                 }

All the calls to those methods seem to discard any return value, eg:

         If (\_SB.OKEC)
         {
             \_SB.PCI0.QSB.WENR (0x01F0)
         }

I couldn't find a reference to WETR



So I thought to not return anything:

                 Method (WENR, 1, NotSerialized)
                 {
/*                    Return (WQS (0x0E, Arg0))*/
                     WQS (0x0E, Arg0)
                 }

                 Method (WETR, 1, NotSerialized)
                 {
/*                    Return (WQSB (0x0E, Arg0))*/
                     WQSB (0x0E, Arg0)
                 }

I am more than a bit wary about trying this for real so would appreciate 
  any comments on the dsdt code above. If the fixes are good then maybe 
they could be incorporated into the FAQ?

Any comments gratefully received,

-Cam


-------------------------------------------------------
This SF.Net email is sponsored by: SourceForge.net Broadband
Sign-up now for SourceForge Broadband and get the fastest
6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: Fixing broken DSDT - code suggestions for comment    please!
@ 2004-05-18 14:19 Franklin Marmon
       [not found] ` <1084889946.5037.2.camel-t0Me6uhKnbVYViWeMKg0xQC/G2K4zDHf@public.gmane.org>
  0 siblings, 1 reply; 16+ messages in thread
From: Franklin Marmon @ 2004-05-18 14:19 UTC (permalink / raw)
  To: ACPI Developers

I've posted this question before, if its just a question that shall go
unanswered someone please let me know so I stop reposting it different
ways:

Where would start searching for information on debugging a compiled
DSDT?  The iasl compiler believes it is fine, 0 errors, 0 warnings; but
I kernel panic in the one_complete_parse phase when booting using the
custom dsdt table.

Thank you,

frm




-------------------------------------------------------
This SF.Net email is sponsored by: SourceForge.net Broadband
Sign-up now for SourceForge Broadband and get the fastest
6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click

^ permalink raw reply	[flat|nested] 16+ messages in thread
* RE: Fixing broken DSDT - code suggestions for comment please!
@ 2004-05-21  0:33 Brown, Len
  0 siblings, 0 replies; 16+ messages in thread
From: Brown, Len @ 2004-05-21  0:33 UTC (permalink / raw)
  To: Chris McDermott; +Cc: ACPI Developers, Moore, Robert

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="us-ascii", Size: 1534 bytes --]

I've asked the web page gnomes to delete the obsolete
Linux binary.

Linux folks can build iasl from course

untar
cd compiler
make


cheers,
-Len
 

>-----Original Message-----
>From: Chris McDermott [mailto:lcm-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org] 
>Sent: Thursday, May 20, 2004 4:30 PM
>To: Brown, Len
>Cc: ACPI Developers; Moore, Robert
>Subject: Re: [ACPI] Fixing broken DSDT - code suggestions for 
>comment please!
>
>On Mon, May 17, 2004 at 21:00 -0400, Len Brown wrote: 
>> On Mon, 2004-05-17 at 20:54, Cam wrote:
>> > Len Brown wrote:
>> > > Please verify that you still have this problem
>> > > when running the latest iasl:
>> > > 
>> > > http://www.intel.com/technology/IAPC/acpi/downloads.htm
>> > 
>> > I was working with iasl-linux-20030918 which I think is 
>the latest. Do 
>> > you think the Store(Local0, Local0) is an iasl bug? I can 
>send the dsdt 
>> > binary if you are interested.
>> 
>> Follow the link above to download a version 6 months newer.
>
>Following the link above, I see a newer version of iasl for 
>Windows, but not 
>for Linux. Is there a version of iasl newer than 20030918 for 
>Linux? Am I
>missing something?
>
>thanks,
>-- 
>-chris
>
>


-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g.
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id149&alloc_id66&op=click

^ permalink raw reply	[flat|nested] 16+ messages in thread
* RE: Fixing broken DSDT - code suggestions for comment   please!
@ 2004-05-26  2:35 Yu, Luming
  0 siblings, 0 replies; 16+ messages in thread
From: Yu, Luming @ 2004-05-26  2:35 UTC (permalink / raw)
  To: marmon-GymH4r+vMzPQT0dZR+AlfA, ACPI Developers; +Cc: linux-acpi

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="us-ascii", Size: 931 bytes --]

 >
>I've posted this question before, if its just a question that shall go
>unanswered someone please let me know so I stop reposting it different
>ways:
>
>Where would start searching for information on debugging a compiled
>DSDT?  The iasl compiler believes it is fine, 0 errors, 0 warnings; but
>I kernel panic in the one_complete_parse phase when booting using the
>custom dsdt table.
>

  AFAIK, there is no AML debugging tool under linux. To debug the DSDT,
you have to add some statement like "store ( xxx, debug) " in your ASL
code. 

  PS, can you post the detailed message of the panic.

Thanks,
Luming


-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g.
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id149&alloc_id66&op=click

^ permalink raw reply	[flat|nested] 16+ messages in thread
* RE: Fixing broken DSDT - code suggestions for comment   please!
@ 2004-05-26 15:36 Moore, Robert
       [not found] ` <37F890616C995246BE76B3E6B2DBE055E08D59-sBd4vmA9Se5Qxe9IK+vIArfspsVTdybXVpNB7YpNyf8@public.gmane.org>
  0 siblings, 1 reply; 16+ messages in thread
From: Moore, Robert @ 2004-05-26 15:36 UTC (permalink / raw)
  To: Yu, Luming, marmon-GymH4r+vMzPQT0dZR+AlfA, ACPI Developers; +Cc: linux-acpi

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="us-ascii", Size: 1515 bytes --]

There *is* an interactive AML debugger in the ACPI CA package.  However,
it needs to be integrated into Linux.

As far as I can tell, the reason it hasn't been done yet is because the
whole concept of "interactive kernel debugging" is rather foreign to
Linux.

Bob


> -----Original Message-----
> From: Yu, Luming
> Sent: Tuesday, May 25, 2004 7:36 PM
> To: marmon-GymH4r+vMzPQT0dZR+AlfA@public.gmane.org; ACPI Developers
> Cc: linux-acpi
> Subject: RE: [ACPI] Fixing broken DSDT - code suggestions for comment
> please!
> 
>  >
> >I've posted this question before, if its just a question that shall
go
> >unanswered someone please let me know so I stop reposting it
different
> >ways:
> >
> >Where would start searching for information on debugging a compiled
> >DSDT?  The iasl compiler believes it is fine, 0 errors, 0 warnings;
but
> >I kernel panic in the one_complete_parse phase when booting using the
> >custom dsdt table.
> >
> 
>   AFAIK, there is no AML debugging tool under linux. To debug the
DSDT,
> you have to add some statement like "store ( xxx, debug) " in your ASL
> code.
> 
>   PS, can you post the detailed message of the panic.
> 
> Thanks,
> Luming


-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g.
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id149&alloc_id66&op=click

^ permalink raw reply	[flat|nested] 16+ messages in thread
* RE: Fixing broken DSDT - code suggestions for comment   please!
@ 2004-05-27  3:53 Yu, Luming
  0 siblings, 0 replies; 16+ messages in thread
From: Yu, Luming @ 2004-05-27  3:53 UTC (permalink / raw)
  To: Moore, Robert, marmon-GymH4r+vMzPQT0dZR+AlfA, ACPI Developers; +Cc: linux-acpi

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="us-ascii", Size: 746 bytes --]

 
>There *is* an interactive AML debugger in the ACPI CA package. 
> However,
>it needs to be integrated into Linux.
>
>As far as I can tell, the reason it hasn't been done yet is because the
>whole concept of "interactive kernel debugging" is rather foreign to
>Linux.
>
>Bob

I think Kdb and Kgdb in Linux are so-called "interactive kernel
debugging" tool.
So , AML debugger should be feasible to be ported into linux.

--Luming


-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g.
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id149&alloc_id66&op=click

^ permalink raw reply	[flat|nested] 16+ messages in thread
* RE: Fixing broken DSDT - code suggestions for comment   please!
@ 2004-05-28  3:52 Yu, Luming
       [not found] ` <3ACA40606221794F80A5670F0AF15F84047B206A-SRlDPOYGfgogGBtAFL8yw7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
  0 siblings, 1 reply; 16+ messages in thread
From: Yu, Luming @ 2004-05-28  3:52 UTC (permalink / raw)
  To: Nate Lawson, Moore, Robert
  Cc: marmon-GymH4r+vMzPQT0dZR+AlfA, ACPI Developers, linux-acpi

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="us-ascii", Size: 593 bytes --]

>
>If you're interested in seeing how we did it in FreeBSD, see
>src/sys/dev/acpica/Osd/OsdDebug.c and the #ifdef ACPI_DEBUGGER in the
>ACPI-CA code that we added.

Wha'ts the interactive kernel debug tool in FreeBSD? Does ASL debug
feature 
work in that debug tool?

Thanks,
Luming


-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g.
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id149&alloc_id66&op=click

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2004-05-28  7:33 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-05-16  9:29 Fixing broken DSDT - code suggestions for comment please! Cam
     [not found] ` <40A73460.2070407-Nk/s8sJ9yP7QXOPxS62xeg@public.gmane.org>
2004-05-17 11:27   ` Cam
2004-05-17 19:35   ` Len Brown
     [not found]     ` <1084822558.12353.365.camel-D2Zvc0uNKG8@public.gmane.org>
2004-05-18  0:54       ` Cam
     [not found]         ` <40A95EB3.5070206-Nk/s8sJ9yP7QXOPxS62xeg@public.gmane.org>
2004-05-18  1:00           ` Len Brown
     [not found]             ` <1084842006.12349.372.camel-D2Zvc0uNKG8@public.gmane.org>
2004-05-20 20:29               ` Chris McDermott
     [not found]                 ` <20040520202950.GK5920-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2004-05-21  8:51                   ` Cam
  -- strict thread matches above, loose matches on Subject: below --
2004-05-18 14:19 Franklin Marmon
     [not found] ` <1084889946.5037.2.camel-t0Me6uhKnbVYViWeMKg0xQC/G2K4zDHf@public.gmane.org>
2004-05-18 15:30   ` Bas Mevissen
2004-05-21  0:33 Brown, Len
2004-05-26  2:35 Yu, Luming
2004-05-26 15:36 Moore, Robert
     [not found] ` <37F890616C995246BE76B3E6B2DBE055E08D59-sBd4vmA9Se5Qxe9IK+vIArfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2004-05-27 20:42   ` Nate Lawson
2004-05-27  3:53 Yu, Luming
2004-05-28  3:52 Yu, Luming
     [not found] ` <3ACA40606221794F80A5670F0AF15F84047B206A-SRlDPOYGfgogGBtAFL8yw7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2004-05-28  7:33   ` Nate Lawson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox