PBLK length again

[Herman Sheremetyev <mlists-6MNMYbGzEYJWk0Htik3J/w@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 992 bytes --]

Hi All,

I have an Asus M6N and the Bios DSDT provides a PBLK length of 7 which
causes ACPI to always use the C1 processor state.  This laptop
definitely supports C2 and most people have just used custom DSDT's and
changed the value to 6.  I don't like using a custom DSDT so I made a
quick kernel patch (attached) to accept 7 as a good value.

I've searched the archives and found that other people have had issues
with PBLK being set to something other than 0 or 6 and at one point the
ACPI code was relaxed to allow for other values but then changed back to
the original strict mode due to issues with C2 being used when it
shouldn't be.  There was also talk of making the relaxed code optional
but it seems that never got off the ground.  

My question is, if I make a nicer patch that allows for either strict
interpretation versus a relaxed one, is there a chance that it will get
included?  It seems there is enough interest out there to make it worth
the effort.

Thanks,

-Herman

 

[-- Attachment #2: pblk_length-7-hack.patch --]
[-- Type: text/x-patch, Size: 864 bytes --]

--- linux-2.6.7/drivers/acpi/processor.c	2004-06-20 14:49:10.066168648 -0400
+++ linux-2.6.7.hack/drivers/acpi/processor.c	2004-06-19 21:26:33.000000000 -0400
@@ -2214,7 +2230,8 @@
 
 	if (!object.processor.pblk_address)
 		ACPI_DEBUG_PRINT((ACPI_DB_INFO, "No PBLK (NULL address)\n"));
-	else if (object.processor.pblk_length != 6)
+	else if ((object.processor.pblk_length != 6 ) && 
+		(object.processor.pblk_length != 7 ))
 		ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Invalid PBLK length [%d]\n",
 			object.processor.pblk_length));
 	else {
@@ -2233,7 +2250,7 @@
 		 *
 		 * (In particular, allocating the IO range for Cardbus)
 		 */
-		request_region(pr->throttling.address, 6, "ACPI CPU throttle");
+		request_region(pr->throttling.address, object.processor.pblk_length, "ACPI CPU throttle");
 		request_region(acpi_fadt.xpm_tmr_blk.address, 4, "ACPI timer");
 	}