public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Nigel Cunningham <ncunningham-jjFNsPSvq+iXDw4h08c5KA@public.gmane.org>
To: Bernard Blackham <bernard-4vSAtV5O1nc0n/F98K4Iww@public.gmane.org>
Cc: ACPI List
	<acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	Patrick Mochel
	<mochel-og82NyAXoxR0I81aPRRTmR2eb7JE58TQ@public.gmane.org>
Subject: Re: S4 sleep woes
Date: Mon, 02 Aug 2004 09:32:13 +1000	[thread overview]
Message-ID: <1091403133.11580.63.camel@laptop.cunninghams> (raw)
In-Reply-To: <20040731184636.GG3443-4vSAtV5O1nc0n/F98K4Iww@public.gmane.org>

Howdy.

On Sun, 2004-08-01 at 04:46, Bernard Blackham wrote:
> Ah, there appears to be one, yes (disk_show and disk_store in
> kernel/power/disk.c). Looking again, pmdisk appears to handle it
> correctly (just a little jump of logic). Guess that means it's a bug
> in software suspend 2. :)

I wasn't setting pm_disk_mode from suspend 2, but leaving it at it's
default. It looks to me (without testing it yet) like the fix is to
explicitly set pm_disk_mode to PM_DISK_PLATFORM when suspending and
restore the original value afterwards. Sound right, Patrick?

Regards,

Nigel



-------------------------------------------------------
This SF.Net email is sponsored by OSTG. Have you noticed the changes on
Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now,
one more big change to announce. We are now OSTG- Open Source Technology
Group. Come see the changes on the new OSTG site. www.ostg.com

  parent reply	other threads:[~2004-08-01 23:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-30  5:06 S4 sleep woes Bernard Blackham
     [not found] ` <20040730050615.GA24597-4vSAtV5O1nc0n/F98K4Iww@public.gmane.org>
2004-07-31 15:01   ` Karol Kozimor
     [not found]     ` <20040731150112.GA480-DETuoxkZsSqrDJvtcaxF/A@public.gmane.org>
2004-07-31 18:46       ` Bernard Blackham
     [not found]         ` <20040731184636.GG3443-4vSAtV5O1nc0n/F98K4Iww@public.gmane.org>
2004-08-01 23:32           ` Nigel Cunningham [this message]
2004-08-16 10:01       ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1091403133.11580.63.camel@laptop.cunninghams \
    --to=ncunningham-jjfnspsvq+ixdw4h08c5ka@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=bernard-4vSAtV5O1nc0n/F98K4Iww@public.gmane.org \
    --cc=mochel-og82NyAXoxR0I81aPRRTmR2eb7JE58TQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox