RE: [PATCH][RFC] fix ACPI IRQ routing after S3 suspend

[Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]

Shaohua,
pci=noacpi and acpi=noirq are boot workarounds --
not full-featured supported configurations -- YMMV!
We don't even guarantee that the ACPI SCI
will work with these configurations.
So I think we should spend 0 effort to support ACPI suspend/resume
in configurations where ACPI is partially disabled.

Sorry if this contradicts what I said yesterday,
I think I wasn't thinking clearly then.

thanks,
-Len


On Tue, 2004-08-03 at 22:36, Li, Shaohua wrote:
> Nathan,
> I agree your patch should be ok for the special case, but it's not
> sufficient. Please note a Link device is just an abstraction of PCI
> router, which possibly is in ICH. If we use pci=noacpi or acpi=noirq, we
> don't use link device but still use the router and may also change the
> sets of the router (look at i386/pci/irq.c) and so still fail after S3.
> Your patch can't handle this situation. This indicates adding
> suspend/resume code in pci_link.c is not a good idea. Generic solution
> should be to provide LPC driver.
> 
> Thanks,
> Shaohua
> 
> >-----Original Message-----
> >From: Nathan Bryant [mailto:nbryant-p32f3XyCuykqcZcGjlUOXw@public.gmane.org]
> >Sent: Wednesday, August 04, 2004 9:43 AM
> >To: Brown, Len
> >Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org; Linux Kernel list; Li, Shaohua;
> >Stefan D?singer
> >Subject: [PATCH][RFC] fix ACPI IRQ routing after S3 suspend
> >
> >
> >This patch should fix multiple user-visible problems with the ACPI IRQ
> >routing after S3 resume:
> >
> >"irq x: nobody cared"
> >"my interrupts are gone"
> >
> >It probably applies to multiple bugzilla entries and mailing list
> posts.
> >
> >Tested on my machine, which is experiencing similar problems. Seems to
> >work - although I get some non-fatal "nobody cared" messages that might
> >be caused by the i8042 driver.
> >
> >Comments?
> >Stefan, can you test this?



-------------------------------------------------------
This SF.Net email is sponsored by OSTG. Have you noticed the changes on
Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now,
one more big change to announce. We are now OSTG- Open Source Technology
Group. Come see the changes on the new OSTG site. www.ostg.com