public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: joanna marsden <jomarsden-zka7wQWIdxI3uPMLIKxrzw@public.gmane.org>
Cc: ACPI Developers
	<acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: acpi_pci_link_allocate() -- latent bug?
Date: 03 Aug 2004 23:52:09 -0400	[thread overview]
Message-ID: <1091591529.2297.69.camel@dhcppc4> (raw)
In-Reply-To: <410C5807.7000602-zka7wQWIdxI3uPMLIKxrzw@public.gmane.org>

Yes, per my response to Nathan's patch, I think
you did find an issue, but should be okay after his patch.

thanks,
-Len

On Sat, 2004-07-31 at 22:40, joanna marsden wrote:
> I am investigating an interrupt problem on my machine and came across 
> the following code, in drivers/acpi/pci_link.c
> 
> What happens here if the BIOS sets up these links at the IRQ router at 
> boot time, but doesn't restore them after a resume from S3? Is this a 
> latent bug? Seems like this routine would eventually be called from 
> pci_device_enable, but wouldn't perform the setup we need.
> 
> static int acpi_pci_link_allocate(struct acpi_pci_link* link) {
>         int irq;
>         int i;
> 
>         ACPI_FUNCTION_TRACE("acpi_pci_link_allocate");
> 
>         if (link->irq.setonboot)
>                 return_VALUE(0);
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by OSTG. Have you noticed the changes on
> Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now,
> one more big change to announce. We are now OSTG- Open Source Technology
> Group. Come see the changes on the new OSTG site. www.ostg.com
> _______________________________________________
> Acpi-devel mailing list
> Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/acpi-devel



-------------------------------------------------------
This SF.Net email is sponsored by OSTG. Have you noticed the changes on
Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now,
one more big change to announce. We are now OSTG- Open Source Technology
Group. Come see the changes on the new OSTG site. www.ostg.com

      parent reply	other threads:[~2004-08-04  3:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-01  2:40 acpi_pci_link_allocate() -- latent bug? joanna marsden
     [not found] ` <410C5807.7000602-zka7wQWIdxI3uPMLIKxrzw@public.gmane.org>
2004-08-04  3:52   ` Len Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1091591529.2297.69.camel@dhcppc4 \
    --to=len.brown-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=jomarsden-zka7wQWIdxI3uPMLIKxrzw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox