Re: Allow userspace do something special on overtemp

Re: Allow userspace do something special on overtemp

[Len Brown]

Simpler to delete the usermode call and rely on the (flexible)
acpid event, yes?

 thermal.c |   29 +----------------------------
 1 files changed, 1 insertion(+), 28 deletions(-)

cheers,
-Len


===== drivers/acpi/thermal.c 1.34 vs edited =====
--- 1.34/drivers/acpi/thermal.c	Thu Jul  8 01:56:01 2004
+++ edited/drivers/acpi/thermal.c	Thu Aug 12 11:13:59 2004
@@ -61,7 +61,6 @@
 #define ACPI_THERMAL_MODE_ACTIVE	0x00
 #define ACPI_THERMAL_MODE_PASSIVE	0x01
 #define ACPI_THERMAL_MODE_CRT   	0xff
-#define ACPI_THERMAL_PATH_POWEROFF	"/sbin/poweroff"
 
 #define ACPI_THERMAL_MAX_ACTIVE	10
 
@@ -422,30 +421,6 @@
 
 
 static int
-acpi_thermal_call_usermode (
-	char			*path)
-{
-	char			*argv[2] = {NULL, NULL};
-	char			*envp[3] = {NULL, NULL, NULL};
-
-	ACPI_FUNCTION_TRACE("acpi_thermal_call_usermode");
-
-	if (!path)
-		return_VALUE(-EINVAL);
-
-	argv[0] = path;
-
-	/* minimal command environment */
-	envp[0] = "HOME=/";
-	envp[1] = "PATH=/sbin:/bin:/usr/sbin:/usr/bin";
-	
-	call_usermodehelper(argv[0], argv, envp, 0);
-
-	return_VALUE(0);
-}
-
-
-static int
 acpi_thermal_critical (
 	struct acpi_thermal	*tz)
 {
@@ -468,10 +443,8 @@
 	if (result)
 		return_VALUE(result);
 
-	printk(KERN_EMERG "Critical temperature reached (%ld C), shutting
down.\n", KELVIN_TO_CELSIUS(tz->temperature));
+	printk(KERN_EMERG "Critical temperature reached (%ld C).\n",
KELVIN_TO_CELSIUS(tz->temperature));
 	acpi_bus_generate_event(device, ACPI_THERMAL_NOTIFY_CRITICAL,
tz->trips.critical.flags.enabled);
-
-	acpi_thermal_call_usermode(ACPI_THERMAL_PATH_POWEROFF);
 
 	return_VALUE(0);
 }

Re: Allow userspace do something special on overtemp

[Randy.Dunlap]

On 12 Aug 2004 11:19:05 -0400 Len Brown wrote:

| Simpler to delete the usermode call and rely on the (flexible)
| acpid event, yes?
| 
|  thermal.c |   29 +----------------------------
|  1 files changed, 1 insertion(+), 28 deletions(-)

a.  Yes, it should be more flexible than just 'overtemp'.

b.  For userspace, there are:

acpid -  http://sourceforge.net/projects/acpid/

acpi tools, like ospmd (by Andy Grover) - in CVS at
  http://sourceforge.net/projects/acpi/

What others are there?

And ospmd (at least) needs some care.  Andy wanted to give it up
1 or 2 years ago, so I took it over for awhile.  However, it
still needs more care, so if anyone out there wants to maintain it,
please speak up.

--
~Randy

Re: Allow userspace do something special on overtemp

[Stefan Seyfried]

Randy.Dunlap wrote:
> On 12 Aug 2004 11:19:05 -0400 Len Brown wrote:
> 
> | Simpler to delete the usermode call and rely on the (flexible)
> | acpid event, yes?
> | 
> |  thermal.c |   29 +----------------------------
> |  1 files changed, 1 insertion(+), 28 deletions(-)
> 
> a.  Yes, it should be more flexible than just 'overtemp'.
> 
> b.  For userspace, there are:
> 
> acpid -  http://sourceforge.net/projects/acpid/
> 
> acpi tools, like ospmd (by Andy Grover) - in CVS at
>   http://sourceforge.net/projects/acpi/
> 
> What others are there?

powersaved - http://forge.novell.com/modules/xfmod/project/?powersave
handles APM, ACPI and cpufreq
-- 
seife

"Any ideas, John?"
"Well, surrounding thems out."

Re: [ACPI] Re: Allow userspace do something special on overtemp

[Stefan Dösinger]

Hi,
Isn't this a little bit dangerous? What if acpid is not set up to handle this?

Re: Re: Allow userspace do something special on overtemp

[Len Brown]

On Thu, 2004-08-12 at 13:27, Stefan Dösinger wrote:
> Hi,
> Isn't this a little bit dangerous? What if acpid is not set up to
> handle this?
> 

There are two levels of hardware thermal control that will
kick in -- TM1 and TM2, and if they fail the hardware will
turn itself off.  Speaking for Intel processors only.

The reason is that the hardware needs to handle this case
where the OS crashes while in ACPI mode and is unable
to do any thermal control itself.

cheers,
-Len




-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285