From: Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
Cc: Rusty trivial patch monkey Russell
<trivial-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>,
Andrew Morton <akpm-LJ1TwQYPT6cQrrorzV6ljw@public.gmane.org>,
ACPI mailing list
<acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: acpi-thermal: fix confusing define
Date: 20 Oct 2004 17:13:20 -0400 [thread overview]
Message-ID: <1098306800.26603.4347.camel@d845pe> (raw)
In-Reply-To: <20041020181221.GA25015-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
applied.
thanks,
-len
On Wed, 2004-10-20 at 14:12, Pavel Machek wrote:
> Hi!
>
> We have PASSIVE, ACTIVE and CRT cooling policies... Ouch, the last one
> should probably be called CRITICAL otherwise everyone thinks
> "TV?". This patch fixes it, please apply,
> Pavel
>
> --- foo/drivers/acpi/thermal.c 9 Oct 2004 04:09:18 -0000 1.27
> +++ foo/drivers/acpi/thermal.c 20 Oct 2004 17:53:41 -0000
> @@ -60,8 +60,8 @@
> #define ACPI_THERMAL_NOTIFY_HOT 0xF1
> #define ACPI_THERMAL_MODE_ACTIVE 0x00
> #define ACPI_THERMAL_MODE_PASSIVE 0x01
> -#define ACPI_THERMAL_MODE_CRT 0xff
> +#define ACPI_THERMAL_MODE_CRITICAL 0xff
> #define ACPI_THERMAL_PATH_POWEROFF "/sbin/poweroff"
>
> #define ACPI_THERMAL_MAX_ACTIVE 10
>
> @@ -953,7 +964,7 @@
> seq_puts(seq, "<setting not supported>\n");
> }
>
> - if ( tz->cooling_mode == ACPI_THERMAL_MODE_CRT )
> + if ( tz->cooling_mode == ACPI_THERMAL_MODE_CRITICAL )
> seq_printf(seq, "cooling mode: critical\n");
> else
> seq_printf(seq, "cooling mode: %s\n",
> @@ -1262,7 +1276,7 @@
> tz->cooling_mode = ACPI_THERMAL_MODE_ACTIVE;
> } else {
> /* _ACx and _PSV are optional, but _CRT is
> required */
> - tz->cooling_mode = ACPI_THERMAL_MODE_CRT;
> + tz->cooling_mode = ACPI_THERMAL_MODE_CRITICAL;
> }
> }
>
> --
> People were complaining that M$ turns users into beta-testers...
> ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
>
>
-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
prev parent reply other threads:[~2004-10-20 21:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-20 18:12 acpi-thermal: fix confusing define Pavel Machek
[not found] ` <20041020181221.GA25015-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2004-10-20 21:13 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1098306800.26603.4347.camel@d845pe \
--to=len.brown-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=akpm-LJ1TwQYPT6cQrrorzV6ljw@public.gmane.org \
--cc=pavel-+ZI9xUNit7I@public.gmane.org \
--cc=trivial-8n+1lVoiYb80n/F98K4Iww@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox