From: Len Brown <len.brown@intel.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: ACPI Developers <acpi-devel@lists.sourceforge.net>,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/acpi: remove unused exported functions
Date: 05 Nov 2004 21:10:08 -0500 [thread overview]
Message-ID: <1099707007.13834.1969.camel@d845pe> (raw)
In-Reply-To: <20041105215021.GF1295@stusta.de>
On Fri, 2004-11-05 at 16:50, Adrian Bunk wrote:
> The patch below completely removes 7 functions that were
> EXPORT_SYMBOL'ed but had exactly zero users in the kernel and makes
> another one that was previously EXPORT_SYMBOL'ed static.
>
> It also removes another unused global function to completely remove
> drivers/acpi/hardware/hwtimer.c which contained no function used
> anywhere in the kernel.
>
> Please comment on whether this patch is correct or whether in-kernel
> users of these functions are pending.
>
>
> diffstat output:
> drivers/acpi/acpi_ksyms.c | 8 -
> drivers/acpi/events/evxfevnt.c | 191 -----------------------------
> drivers/acpi/hardware/Makefile | 2
> drivers/acpi/hardware/hwtimer.c | 200
> -------------------------------
> drivers/acpi/resources/rsxface.c | 52 --------
> drivers/acpi/scan.c | 6
> drivers/acpi/utilities/utxface.c | 89 -------------
> include/acpi/achware.h | 17 --
> include/acpi/acpi_bus.h | 1
> include/acpi/acpixf.h | 24 ---
> 10 files changed, 6 insertions(+), 584 deletions(-)
No, I can't apply this one as-is.
Some of these routines are not called now
simply because Linux/ACPI is evolving and we don't
yet take advantage of some of the things supported
by ACPICA core we use.
thanks,
-Len
next prev parent reply other threads:[~2004-11-06 2:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-05 21:50 [2.6 patch] drivers/acpi: remove unused exported functions Adrian Bunk
2004-11-06 2:10 ` Len Brown [this message]
2004-11-06 11:48 ` Adrian Bunk
2004-11-06 15:31 ` Arnaldo Carvalho de Melo
2004-11-06 21:29 ` Adrian Bunk
2004-11-06 21:21 ` Arnaldo Carvalho de Melo
[not found] ` <418D403E.30608-KCZ47A4bww4P48s/oLjRZg@public.gmane.org>
2004-11-08 17:01 ` Len Brown
2004-11-09 1:40 ` [2.6 patch] kill acpi_ksyms.c Adrian Bunk
[not found] ` <20041109014021.GB15077-HeJ8Db2Gnd6zQB+pC5nmwQ@public.gmane.org>
2004-11-12 4:56 ` Len Brown
2004-11-10 1:21 ` [2.6 patch] drivers/acpi: #ifdef unused functions away Adrian Bunk
[not found] ` <20041110012134.GB4089-HeJ8Db2Gnd6zQB+pC5nmwQ@public.gmane.org>
2004-11-11 15:17 ` Matthew Wilcox
[not found] ` <20041111151727.GB1108-+pPCBgu9SkPzIGdyhVEDUDl5KyyQGfY2kSSpQ9I8OhVaa/9Udqfwiw@public.gmane.org>
2004-11-11 15:36 ` Adrian Bunk
[not found] ` <20041111153650.GD8417-HeJ8Db2Gnd6zQB+pC5nmwQ@public.gmane.org>
2004-11-11 15:40 ` Matthew Wilcox
[not found] ` <20041111154017.GC1108-+pPCBgu9SkPzIGdyhVEDUDl5KyyQGfY2kSSpQ9I8OhVaa/9Udqfwiw@public.gmane.org>
2004-11-11 15:46 ` Adrian Bunk
[not found] ` <20041111154656.GE8417-HeJ8Db2Gnd6zQB+pC5nmwQ@public.gmane.org>
2004-11-11 16:08 ` Matthew Wilcox
[not found] ` <20041111160842.GD1108-+pPCBgu9SkPzIGdyhVEDUDl5KyyQGfY2kSSpQ9I8OhVaa/9Udqfwiw@public.gmane.org>
2004-11-11 19:17 ` Len Brown
2004-11-10 23:38 ` [2.6 patch] drivers/acpi: remove unused exported functions Pavel Machek
2004-11-06 20:39 ` [ACPI] " Matthew Wilcox
2004-11-06 21:26 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1099707007.13834.1969.camel@d845pe \
--to=len.brown@intel.com \
--cc=acpi-devel@lists.sourceforge.net \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox